Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 Jan 2022 09:07:00 -0800
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     Lukas Czerner <lczerner@redhat.com>
Cc:     fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] common/rc: set maximum label length for ext4
Message-ID: <20220131170700.GA8288@magnolia>
References: <20211123101119.5112-1-lczerner@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211123101119.5112-1-lczerner@redhat.com>
Precedence: bulk

On Tue, Nov 23, 2021 at 11:11:19AM +0100, Lukas Czerner wrote:
> Set maximum label length for ext4 in _label_get_max() to be able to test
> online file system label set/get ioctls.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
>  common/rc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 8e351f17..50d6d0bd 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -4545,6 +4545,9 @@ _label_get_max()
>  	f2fs)
>  		echo 255
>  		;;
> +	ext2|ext3|ext4)
> +		echo 16

After reviewing the ext4 ondisk format, 16 is the correct value.

Though I wonder, what actually prevents generic/492 from running on old
kernels without GETLABEL support?

Either way this patch is ok, so...
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> +		;;
>  	*)
>  		_notrun "$FSTYP does not define maximum label length"
>  		;;
> -- 
> 2.31.1
>