Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: Ogu9eFOyBtg9dM6EsmEJAQVPIZxWwTlEWDq8aR6bJLyHxQPyx6S5wpqZiXuVZz5gCks5KQizTI
 xK0SPj/lvtkaadNLDETbX6EMGyv5jrdvEwjVTLBcHWWnuxGLa5M1DWzhRspiD4hqCZ7ZJmhqKA
 y9E2Ix6PRpzTvqo1z7Yot3Q0raSNY7w3hZ/Y/50BYaZfEIIxqjnVvHHvMPuljyNByWGsdtRgBN
 m/yex7j3NjgODPN23en4Lfjk5QFIWPgKdpZPva/nA1HGZZ7mu6wbu+7XlM29fA0o77oTgzk7f8
 Zfwo2yl/1iLoNjPs9cQkfMKD
IronPort-SDR: 7rp953d7QjEFNKLqgIeM3C8qjiiemF4hvgK0BB+vqRPd2D0tvrzCj4GySzcfK3s/k2xLDs/DLr
 H4bFH1Kze61TgAZdKyKVCZYvLuvbyQuPKt4TKazw0F5hPc94koKnsXP1igH9/dneEA2S0NUghG
 7kzZODIulF2osHtXH6vDK4vemqWEjjc/GrVJ8x0ECOAiuEPukD7r8PUafasNNW1AVy4ILg8Rh5
 iBhYWfq61Vz05rYIcHI1pBoUn7BJd/b2z4XN79NKZ0SpJuLO55FsLvjn5b5aIPdOoLHE2j9jcb
 ECU=
WDCIronportException: Internal
From:   Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Cc:     linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
        Naohiro Aota <naohiro.aota@wdc.com>,
        Johannes Thumshirn <johannes.thumshirn@wdc.com>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: [PATCH 3/7] ext4/021: check _scratch_mkfs_sized return code
Date:   Mon,  7 Feb 2022 15:55:37 +0900
Message-Id: <20220207065541.232685-4-shinichiro.kawasaki@wdc.com>
In-Reply-To: <20220207065541.232685-1-shinichiro.kawasaki@wdc.com>
References: <20220207065541.232685-1-shinichiro.kawasaki@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

The test cases ext4/021 calls _scratch_mkfs before _scratch_mkfs_sized,
and does not check return code of _scratch_mkfs_sized. Even if
_scratch_mkfs_sized failed, _scratch_mount after it cannot detect the
sized mkfs failure because _scratch_mkfs already created a file system
on the device. This results in unexpected test condition.

To avoid the unexpected test condition, check return code of
_scratch_mkfs_sized.

Suggested-by: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
 tests/ext4/021 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/ext4/021 b/tests/ext4/021
index 62768c60..a9277abf 100755
--- a/tests/ext4/021
+++ b/tests/ext4/021
@@ -24,7 +24,7 @@ _scratch_unmount
 
 # With 4k block size, this amounts to 10M FS instance.
 fssize=$((2560 * $blocksize))
-_scratch_mkfs_sized $fssize >> $seqres.full 2>&1
+_scratch_mkfs_sized $fssize >> $seqres.full 2>&1 || _fail "mkfs failed"
 _require_metadata_journaling $SCRATCH_DEV
 
 offset=0
-- 
2.34.1