Received-SPF: softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     "Darrick J. Wong" <djwong@kernel.org>
CC:     "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
        "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
        "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
        Naohiro Aota <Naohiro.Aota@wdc.com>,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH 2/7] generic/{171,172,173,174,204}: check
 _scratch_mkfs_sized return code
Thread-Topic: [PATCH 2/7] generic/{171,172,173,174,204}: check
 _scratch_mkfs_sized return code
Thread-Index: AQHYG++/fU37Bwzf9kG7eXUDEk67SKyKYhcAgAB+qIA=
Date:   Wed, 9 Feb 2022 08:09:08 +0000
Message-ID: <20220209080907.r5olnguhpdllqe77@shindev>
References: <20220207065541.232685-1-shinichiro.kawasaki@wdc.com>
 <20220207065541.232685-3-shinichiro.kawasaki@wdc.com>
 <20220209003548.GC8288@magnolia>
In-Reply-To: <20220209003548.GC8288@magnolia>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2CFeMWvAth0Qj1lIGlj8IzeqBKZhe3QfWxq7moGL4R/k789qeA+4QHqCBuof?=
 =?us-ascii?Q?8nOGo5kmLOcjwpeVnYiKPgkPDvouOsLbcjaB+h8GxtXyNcm3PQpPCl+1jmAO?=
 =?us-ascii?Q?9g1Dz0HneU/27gG7MAy9sDensOZHcYce3JSkH5TUzmG7hAAyDzjX8JXR9n5b?=
 =?us-ascii?Q?hjacEUkWu6Wir6BHfchd76eWh4cW99T95zNXkB8micTLfSCmYQJ159ok4SDn?=
 =?us-ascii?Q?hha9A0dtgNBGGlIiWsqBTzTbs/J20zOxe5gTJ81ul5PeHIkE8uRYLKUNVPOm?=
 =?us-ascii?Q?hki8I6/lP06bO9fRgpYBKsTZNWVLonA4mKAqACdizgKGkwN+6uZy4Td0Zh65?=
 =?us-ascii?Q?hu3bHDZKWB9Zf30MS6OtpP1RBbL3HaJQX5NPmZ5k145+AMKWftrBEnECa5fC?=
 =?us-ascii?Q?tu5s/sH/151nd44vXKBwh6eX6V/5Z6G9buYFgcEVHPZ5QkFK8ezFohDUcgaF?=
 =?us-ascii?Q?aZl/yI5w4UyqmDC5pdjFsL+VoXgwRhfXwdPj6FuWPw34OeQmxyOl7motU5Ax?=
 =?us-ascii?Q?Sy4/T57DDF3rYpUGCMJtpISj4iKjOoCE2eV2mVYVfWty/Z6ALRT1iHYxaQJB?=
 =?us-ascii?Q?klPFLGgWptn9PFZMjJGpAZWYvDeKByw7J2+VzLcE1HPTd+yHQ7cyJ5Q/SQ83?=
 =?us-ascii?Q?icJR5HlZzTr1d8RtuYTz/i++387C2vW+zru+XhZmq1ytCzTya2xoeFjER8MJ?=
 =?us-ascii?Q?Gldimvrah8ysZhJ79rknb4whJEB/2Bl36YnTf0obPsLyGRESPx/r53yYPIZL?=
 =?us-ascii?Q?+JquUizQeSGwrqFSYzXL7cCAgOAryXjeafl1YpSk/Tf4aedJqFM2+6dce9XP?=
 =?us-ascii?Q?BN0kGKGYgrLNctY/A1T6MSOjtUPQTZ0VA7wBlxx5dqrSShJrt73z181Y8y1m?=
 =?us-ascii?Q?oOaLnj0X0EyF6qz/4DrO+BdhNv/Vxeg2GMjbuTEvafF44lSUd7UrNNl8hM8y?=
 =?us-ascii?Q?+VjvolDFmwCcGT+4V3F0UEb1onKMrXI1cBX/7cmEfuGAJTEfYapvtlZZQImv?=
 =?us-ascii?Q?xcOH38eA+xdQxWKxz3HiV1u1nMs62O2IvVqMPCB6+2ukOKMiscyzSl4h5Xwm?=
 =?us-ascii?Q?YCGXjc6ZQUOloVG0baF5dGoVMTKOLFQU2DHV8SbgB2EoCDY4/JjfVRSob0hr?=
 =?us-ascii?Q?0fUsXukaubyoS+MTJ1rRnNpCyi1zm8DX7NlC03JaBBq83Hl9PRzUNne2+cbA?=
 =?us-ascii?Q?q0Rgsum9L50rfqyizrctCxTBFN0o1q1jMBYixVMSJNqRTlArTwEb/Gnq7LlC?=
 =?us-ascii?Q?5fz/ZyGJ9GEN3LhCQtGGLuU17EWy5S3xPKWcfHm9LdkjzFr8iWXHfBbhN0Xv?=
 =?us-ascii?Q?u7wgg+z6ZegqpvpkQvmsefHHqFG3XWIAxGeBKwHSkBGKSwOpLWxeiHdsoLKr?=
 =?us-ascii?Q?uLlePx3B61iWDmjF5CIYecPDD2FQQi0UMUdsoWhtNgVIOgApeRkpdUAAgh1U?=
 =?us-ascii?Q?vQi3RDj5tZqLozjuSIer7oIRKYmXF9MnCqh3o23iBXfymtuWTONFTsrk+zPB?=
 =?us-ascii?Q?vcBZBMJUs0QTXfezZYuB4AFLNhEQsqA6NQP3BYo1mqWl/rjRWK3tIGvDM6Yq?=
 =?us-ascii?Q?qjOaL94aDZ5I5b7szBPK7YV6jfVR7rhK0cdobM9B3CmC27S4RAOiAab1iTy0?=
 =?us-ascii?Q?cvWtTmnE8N09BqK/VWeo2GlTPZMjFG1qPHh4q9oLavcLwxpdKn2EgE3uJT7y?=
 =?us-ascii?Q?XXy8EvPP+jcKOAsdh54IAjUE5bg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9934DA6C7266AB4E920CC0EB4990EDAA@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2283fb71-c5e0-449b-f549-08d9eba3729b
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 08:09:08.3874
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Qm6/e2t6p8sJqTxIOTlMOk8HZeyZfIr0yJegZ831dCjOCqg78HlL6Rityml9gaNDboVKi8pXONKpAQ2W8H31kW8Et2yu6EumEmoJM+ubu+g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB3989
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Feb 08, 2022 / 16:35, Darrick J. Wong wrote:
> On Mon, Feb 07, 2022 at 03:55:36PM +0900, Shin'ichiro Kawasaki wrote:
> > The test cases generic/{171,172,173,174,204} call _scratch_mkfs before
> > _scratch_mkfs_sized, and they do not check return code of
> > _scratch_mkfs_sized. Even if _scratch_mkfs_sized failed, _scratch_mount
> > after it cannot detect the sized mkfs failure because _scratch_mkfs
> > already created a file system on the device. This results in unexpected
> > test condition of the test cases.
> >=20
> > To avoid the unexpected test condition, check return code of
> > _scratch_mkfs_sized in the test cases.
> >=20
> > Suggested-by: Naohiro Aota <naohiro.aota@wdc.com>
> > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
>=20
> Hm.  I wonder, are there other tests that employ this _scratch_mkfs ->
> scratch_mkfs_sized sequence and need patching?
>=20
> $ git grep -l _scratch_mkfs_sized | while read f; do grep -q
> '_scratch_mkfs[[:space:]]' $f && echo $f; done
> common/encrypt
> common/rc
> tests/ext4/021
> tests/generic/171
> tests/generic/172
> tests/generic/173
> tests/generic/174
> tests/generic/204
> tests/generic/520
> tests/generic/525
> tests/xfs/015
>=20
> generic/520 is a false positive, and you patched the rest.  OK, good.
>=20
> I wonder if the maintainer will ask for the _scratch_mkfs_sized in the
> failure output, but as far as I'm concerned:
>=20
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

Thank you for reviewing. As for g/204, I will remove _scratch_mkfs call as =
you
suggested in other e-mail. So, I think this error check addition is no long=
er
required for g/204, and will drop the g/204 hunk from this patch. I wonder =
if
I can add your Reviewed-by tag with this change, but to be strict, I plan n=
ot
to add the tag for v2 post.

--=20
Best Regards,
Shin'ichiro Kawasaki=