Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ypOjbzajne+u+VcZtk2YgVFlV/9FztTVmVZBdGrhM9WRzyntr7YsE53m+TwXm+qD0ditlhQuYd
 OR+PIx6LM/aw1aVzwm55dysUnjgEGeUW4q52XYsGA887JlyH9G9Ds27pw+n+/HNs3vaNZ3kTc8
 7Mp0ArapH3+fG1vGrp+CQZSxYbyHQNV611wnHeF46hDgtWjV8OHuMHEY9NtW2FNdLE3pgRq1qf
 PjWbHWlhTlYk3G5nPz/v6Xw87AtpArob8d9t2LOy1W4a2VrNKpKhf/fjVdHNsUP4ivT5R5tiKy
 bcbDBAcsNVU7TkrPMhAXdE/9
IronPort-SDR: HdPriuEKVhWsCgCMJH7nM3u0NNBHMW4LdTwQRup3PhxoOSboYk5/ZH42P9eGibQOPOZTmhxnrQ
 OLotWoFkTD5ZUzvrdFsNhXMH+alx/vYgbVt6EHvjwCT+UWmy8j6AjnSEAZJp6+Vw5KBD+3LGYX
 yxy3n8JG1zepbuigMyXqTdJ6BDn5IfCAnmfw/2TZVCiSkX1ej9pav8NEzYdedgLojkMCetSLSd
 JtSsF2A7iehXr3DlI8nx4rBrujJXk6WUFW/K/Q+jvsLu+W7V2KpmcrXFy3ifJIpA5dG+Vw6kY6
 lu8=
WDCIronportException: Internal
From:   Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Cc:     linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
        Naohiro Aota <naohiro.aota@wdc.com>,
        Johannes Thumshirn <johannes.thumshirn@wdc.com>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: [PATCH v2 5/6] xfs/015: check _scratch_mkfs_sized return code
Date:   Wed,  9 Feb 2022 21:33:04 +0900
Message-Id: <20220209123305.253038-6-shinichiro.kawasaki@wdc.com>
In-Reply-To: <20220209123305.253038-1-shinichiro.kawasaki@wdc.com>
References: <20220209123305.253038-1-shinichiro.kawasaki@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

The test cases xfs/015 calls _scratch_mkfs before _scratch_mkfs_sized,
and does not check return code of _scratch_mkfs_sized. Even if
_scratch_mkfs_sized failed, _scratch_mount after it cannot detect the
sized mkfs failure because _scratch_mkfs already created a file system
on the device. This results in unexpected test condition.

To avoid the unexpected test condition, check return code of
_scratch_mkfs_sized.

Suggested-by: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/015 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/015 b/tests/xfs/015
index 86fa6336..2bb7b8d5 100755
--- a/tests/xfs/015
+++ b/tests/xfs/015
@@ -43,7 +43,7 @@ _scratch_mount
 _require_fs_space $SCRATCH_MNT 131072
 _scratch_unmount
 
-_scratch_mkfs_sized $((32 * 1024 * 1024)) > $tmp.mkfs.raw
+_scratch_mkfs_sized $((32 * 1024 * 1024)) > $tmp.mkfs.raw || _fail "mkfs failed"
 cat $tmp.mkfs.raw | _filter_mkfs >$seqres.full 2>$tmp.mkfs
 # get original data blocks number and agcount
 . $tmp.mkfs
-- 
2.34.1