Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     "Darrick J. Wong" <djwong@kernel.org>
CC:     "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
        "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
        "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
        Naohiro Aota <Naohiro.Aota@wdc.com>,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v2 2/6] generic/204: remove unnecessary _scratch_mkfs call
Thread-Topic: [PATCH v2 2/6] generic/204: remove unnecessary _scratch_mkfs
 call
Thread-Index: AQHYHbE2IBcn5+zDo0iR6hGUaqqMrKyLzicAgAHOugA=
Date:   Fri, 11 Feb 2022 02:07:35 +0000
Message-ID: <20220211020734.x7nxgvdl4ltesjb2@shindev>
References: <20220209123305.253038-1-shinichiro.kawasaki@wdc.com>
 <20220209123305.253038-3-shinichiro.kawasaki@wdc.com>
 <20220209223124.GE8313@magnolia>
In-Reply-To: <20220209223124.GE8313@magnolia>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N1bcNoI9vVQCaU57VSZEGEfbOmpzCTUt0Q7tTjFSVM41XtRnBhjWkKYEI+zV?=
 =?us-ascii?Q?3NatasYPVkV7uGYWHbfnLYXtsZaJG4AYAwHCKXKZ60QG486HtHuT+wd98f6j?=
 =?us-ascii?Q?j6ItbCh64TQ6JoOKHiM1AJaMBtNPmpin59R30u/pxUC7DpIajOt6gpBava89?=
 =?us-ascii?Q?2o0zVDBt1LASLwepAq4Xulk/eMR5Hm6ny4KLMSM49/di+Nb8PCNOSeAEhNYi?=
 =?us-ascii?Q?MMbbs9RNdvrEFlT9fIde/eqGHYkTvWrVEgUE9Zjsj0nYKdQju54cCDGQ+UZs?=
 =?us-ascii?Q?pnXweap9kGf+S8pnO0FhRvPtQAQ8m0W6jwZkKg3gxnPWH2i+NDVy7Sg8oavZ?=
 =?us-ascii?Q?Zjx1i36s+0FS6+myjnyg38iqxQRWqWNcxfsr9d+BMO8OYW4+4gkyi/VR86l2?=
 =?us-ascii?Q?sn7SlUodeMr+2WoM5X5VuUn91nrPE2EtH1jRdX9vJ5iDkqhMlYoeAznJ4Lna?=
 =?us-ascii?Q?msW/SNM9wUm7ekOllRwKSB3RD7RwRysbTDdZdbgj48Vs2SgOHJXCz70JVq9M?=
 =?us-ascii?Q?h8ovoXNxSDT1FFkMquHJitN8lpB6i7MSzANxUOnaOpLlbl4Q0u8RQzoLlr70?=
 =?us-ascii?Q?w8FR4PqdXPMdb2WZLQzE1u62fXLXv7kR52HUYfpYxSlSLS/q7fkz9xi8QSZp?=
 =?us-ascii?Q?S0lkP2Hz7krqgoPk7hOnKP87HHOOBckgrofL8xP/CwHmKRS9C7BKdUZcRfx+?=
 =?us-ascii?Q?rukxGLXN4sHQH/e1Dqy++Apk0OydNVnn9Gc7TIy5uUqL6ZSvshr2RMZG775y?=
 =?us-ascii?Q?Hc9vHCsKT9dYTqNrt9BhRqHjS12aldG/LZcP0WCkwBnKv9b3R/URdGUD0SRS?=
 =?us-ascii?Q?H+iCSSVnR6IJwPfUIJbk+SbIQ2/c5GG4sy0x13J3m+miyRL0G9x2epRKWNX4?=
 =?us-ascii?Q?WnZlts0C1S1hXzNYJIYCssJy/cZ4sRBEEedwDgzvfikdwB7LDvLELJC/dTXM?=
 =?us-ascii?Q?hBgAhqOE9fqs3JK6ZXyVN5HHvfMh9M4+VoOhQlbcO9ZrjJ9kw1rv7H0v3jSc?=
 =?us-ascii?Q?oA3MZQVAcGQ8NdFLDRAQhDluW/zN6uY/bLmHAmoJ6p2A18ilgFduwA4H+YSW?=
 =?us-ascii?Q?nRrND8y3l8sIj/odJHButGWxxPEyUyUd8jbTsq5zrPQQvnEJ7qwUUOhc5Oop?=
 =?us-ascii?Q?MDdbzAWz/4EIbqKvcpPzOOP8ROlnRFMyOZrTjnshEWGVRzthM3HtrTHX3ZPp?=
 =?us-ascii?Q?ebvKcjbC/AOm37PIdoF0ss/qQsf6Al4aK52uUgkItMlkwjsF3MF+TMREM/mR?=
 =?us-ascii?Q?tvcSWdRimW10f1Bs97qXLUOyZlyclUkSwaJ+HeNevJ+6/sUIToGqG7re1Ksz?=
 =?us-ascii?Q?aOYScIwYfsHtMqtRu/uqk4xWzPuksoFsMcla3h1LUjZGtvwn7sBNjCabwpC7?=
 =?us-ascii?Q?elrqjtUqBx568yGFWD9TrgrQyCmlIth3sncfY9OPI6x9SqFvsru6ZHf/sfEN?=
 =?us-ascii?Q?a+ymPj0WxU//SOI4F1ynsbaJFaC0tTE3VmuA/lVN9ygLPH4xmqNEDQVwEOHQ?=
 =?us-ascii?Q?CvJCQmUDqOl7HbhZgjEuUbG2TCcFvvvtIYduXfzOJsTxxsExHW3sdY4wK22j?=
 =?us-ascii?Q?eCNsTFKWtjysd17x8gYIGaROe1zjUCrmGWKJU8cp+glZt0biBNVw42zbGZMK?=
 =?us-ascii?Q?hePFXYP+s/qOYLgbZ93BOlBmDF8ilZnN9Uag3PqPM//QE1u2Itbiq142Dp+T?=
 =?us-ascii?Q?Ph2R/hZkT8WEZpG7K7rR4YcruKc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <99C1B80739909948936F0C1225B27B08@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09bcc3c5-9540-4640-f436-08d9ed0345c8
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 02:07:35.9399
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KzuzP6NwMaUszVjwmKtjsqYmmTYlOoUHej5sqs3e9mDVZTEMGnZFJtXkcb0SoA7FL4Z92bu6j9LNXJLIFpyqH4fo+7Q1i+BhqtKksjNJlQY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0932
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Feb 09, 2022 / 14:31, Darrick J. Wong wrote:
> On Wed, Feb 09, 2022 at 09:33:01PM +0900, Shin'ichiro Kawasaki wrote:
> > The test case generic/204 calls _scratch_mkfs to get data block size an=
d
> > i-node size of the filesystem and obtained data block size is passed to
> > the following _scratch_mfks_sized call as an option. However, the
> > _scratch_mkfs call is unnecessary since the sizes can be obtained by
> > _scratch_mkfs_sized call without the data block size option.
> >=20
> > Also the _scratch_mkfs call is harmful when the _scratch_mkfs succeeds
> > and the _scratch_mkfs_sized fails. In this case, the _scratch_mkfs
> > leaves valid working filesystem on scratch device then following mount
> > and IO operations can not detect the failure of _scratch_mkfs_sized.
> > This results in the test case run with unexpected test condition.
> >=20
> > Hence, remove the _scratch_mkfs call and the data block size option for
> > _scratch_mkfs_sized call.
> >=20
> > Suggested-by: Darrick J. Wong <djwong@kernel.org>
> > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
>=20
> Looks ok, assuming you've verified that fstests with FSTYP=3Dxfs doesn't
> regress...
>=20
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

Thanks for reviewing. I tested the test case with FSTYP=3Dxfs on a few devi=
ces and
3 variety of MKFS_OPTIONS (no option, "-b size=3D1024 -i size=3D512" and
"-b size=3D4096 -i size=3D2048") and all passed. Also I ran whole fstests w=
ith
FSTYP=3Dxfs, and confirmed that this change does not cause additional failu=
re.

--=20
Best Regards,
Shin'ichiro Kawasaki=