Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0c7b50d3-9bca-9462-05ca-b4ef846cc49a@nvidia.com>
Date:   Fri, 11 Feb 2022 19:04:18 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2 2/3] mm/gup.c: Migrate device coherent pages when
 pinning instead of failing
Content-Language: en-US
To:     Alistair Popple <apopple@nvidia.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org
Cc:     Felix.Kuehling@amd.com, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        hch@lst.de, jgg@nvidia.com, jglisse@redhat.com,
        willy@infradead.org, alex.sierra@amd.com
References: <cover.0d3c846b1c6c294e055ff7ebe221fab9964c1436.1644207242.git-series.apopple@nvidia.com>
 <dd9960b327ca49a9103d9f97868ea7b0b81186c4.1644207242.git-series.apopple@nvidia.com>
 <4b6b472d-07b6-0c96-22ed-9a77a878cf61@nvidia.com>
 <2315725.OX4gP1S1Nc@nvdebian>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <2315725.OX4gP1S1Nc@nvdebian>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWpYZ1FJYXdxQzFydTZ4Vk4xRXF3M0VKMUpzSVhoL1R5WFZVSkFoa1Ria2xK?=
 =?utf-8?B?cmhkYlZGUHdYWkRIQjdPNXQ0T0krZVZyekRnRTJEQmthQi9hV2RZSTl6aWxp?=
 =?utf-8?B?clN3eXlsdVpYeElsVjZXUitlenR1UHdnaVFXUmxaWDBNMDNFM1BOQ0RzZGRZ?=
 =?utf-8?B?NThvckVqRzNOZFhKYVljbEc1S1pZTytkaWg5OGt2R1d6TStWYmYzdVJ0L3VL?=
 =?utf-8?B?aWdaT2JYWGt0NW9VRFdWeGJZNkcyRGNUNGR6UVdaVjRKNFR1VFpHSCtPLzlm?=
 =?utf-8?B?KytxQXBFQ3BrRjZNd0YvYk1DSEFRNXRCRE5Nd1QwVVRFK0VlUUt1TEZsb0xL?=
 =?utf-8?B?Z1g1ZHdXWGZkVUl6YTRXOHFldFVXV1BYZFRSOVBENWJGWnhaQTZqZkZWWHIy?=
 =?utf-8?B?cDRjWnVWNnhiZkZsaEVTYXF0R01vRkc0L2h6c0FOWGJIYXdjZTgzVi9ENmJP?=
 =?utf-8?B?cXU1WEUrMTdFTWxFMGNGQkV4YVc1TzM3ZWpuUTRrNXlCM1YzUE5UUUR6NWpR?=
 =?utf-8?B?ZHBXUktqeStoSkkvVzZ1WERZVlJrMDlWN1AvZXQ1MzhmdDd2dFdybG85SWFk?=
 =?utf-8?B?WElQNjNaWEFuTk1yTGRUWnpENXowSmRsYm1TTnE5WDR6VkpKWXlWSFFQR3Rz?=
 =?utf-8?B?c3BLQ2hmSkh4dHdGNXpkaS9DWU9wUllyRnQvYjltaTl6azJoRlJxdDhkZnp2?=
 =?utf-8?B?QmxvbjVCcVpWbjR2b0ZaOWFHWGFHYldXRDJkNlVYT2pGSjZhSCttWiswZXJm?=
 =?utf-8?B?bGZjZnZXVWVTcjVMMi9XOERjaWhYRkxsbmxrbGVrSENneGNLT0c0VmxQelNE?=
 =?utf-8?B?RjlFK2FGZTU3aHlNR1ZERTZ4cWxmQVAvcDNUNnY5amZ3cldHVi9UR1BQVlFp?=
 =?utf-8?B?aTZodkh5ZmEyRmdhV0NRMURrc3BBZkpzVnh6UXBVSEQ3VHlZYlNEVXRsZTZR?=
 =?utf-8?B?aE9xbHY1clZRc1NDUEJjMEFnNmpjWTk4Mm5ZRCsrV2RoUXYwQU0rUUVzVEF6?=
 =?utf-8?B?NmhNa2lwd0RLTitNWU1NWWhoVXgxa2FGTG9xMUFrNVEvYUhDdU93K2RWN1lx?=
 =?utf-8?B?UkkvZkJ4WURqbHNEcWNpaStBNUkrUFZqMWpQQzdVbURCTzVJR2FOeGJSd3BE?=
 =?utf-8?B?TFVRY0tJczVIbXlSVUd0YWFKMFVoWnVaRmJ3UUVDNkhqcFNXU1NVd0o3aDF5?=
 =?utf-8?B?aVIrTUpMeEhlMW96TFJZMHpqMmRZckhzN3gxbFhzN2tTamQ4SWNQSU9EejJ4?=
 =?utf-8?B?QUtHcG1Nd2tsT0k3UzdyUGR3MmQ5bTdKcEpoRG5OTXNvS1NOWmltVzl2bHY2?=
 =?utf-8?B?cVVjZ1M1ai9WT25hWTdYRHFLNUFRazRycVorNTJZa2huZmFJRGdBNDROVXlo?=
 =?utf-8?B?V0JCZ2VmWElmSnVPQjRiUkRSbUdoVjBKTFhnMlZjOE5zd1R5MFMrTHQ2OTAx?=
 =?utf-8?B?cUNKNjRnL1JkSnFQMXFRRlYvbXE2WGZzZFYyM3FBVlU1bFhUWDQ0VDVjREU5?=
 =?utf-8?B?ZDA5VXlMUlZzR3NiVjYwUVFVL3ZZbk80eW9vVXdjeXFCM0oyNFV3ZUFFa2Jk?=
 =?utf-8?B?MnVUUnB0elFrNDNYUTduZkhEU2hNeFZsdFl1VDh1TUkxVkZGZGt3bWRvZEwz?=
 =?utf-8?B?MVV1ZENZbEtSeTBQMWUxNmo1OGZJMUI1UzNSaWZlS3g2OVI5YitlcDJ0TTFY?=
 =?utf-8?B?Yy85OVZVZHNvazg4TEVlMEpVdVdQUXI5NThVU3RMZ2lZbW83bjJDc2pTazU5?=
 =?utf-8?B?SFlHWmJMN2lvRCt1ckFnMllTa3JDMzdzcGc3M1JleWVVNnBJRVR2T0UrY1RN?=
 =?utf-8?B?QnY2ejE1Z2lyMGRPYWpiVEdvM2dYNDJaQmRSWU1tQ0pVY1VpVGhMS3I5Q1hL?=
 =?utf-8?B?R1E3dWxtWGNsdWNkQ0pPMWJONjRrT3V3OHcyS1c2QjM1WVd6YVJ0YTdsZTAv?=
 =?utf-8?B?T0M5aWtMYW1JV092NzFVUnJRanBHZVpTdnJrSEoyeHgzRmJxSnM3M1d1b0JM?=
 =?utf-8?B?VVFwNkhBT0FUaU1SV3RzdXhGNW1SWmNtM2NySkhET1E4S2E3K2J1TWVmcEJz?=
 =?utf-8?B?SzNtRmo3UThZRUU0Z0JNb21KWjY0WHJwaUhVRGY5MmFNRjFpYVNBbDZqa0Zq?=
 =?utf-8?B?L2FYd2tKTmhVMTRnYlUwK3JtQ1FqSGIreUJrN0lLT1o4a0hyNlk3aXZnUXVM?=
 =?utf-8?Q?GChuqf3qxxCZbVLJ6ki1ovU=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2b77376-650a-4304-4525-08d9edd45d46
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2022 03:04:20.5258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8kdpmNOuYWG2v2FERjvMZM3OP5I2Fn3Rljd9ATWmR/bz32F0MJZrWtY9oo0fbiCDc2HJS4hVOAGDvV9l6RC7JQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3737
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On 2/11/22 18:51, Alistair Popple wrote:
...
>>> @@ -1888,15 +1942,40 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
>>>    			continue;
>>>    		prev_head = head;
>>>    		/*
>>> -		 * If we get a movable page, since we are going to be pinning
>>> -		 * these entries, try to move them out if possible.
>>> +		 * Device coherent pages are managed by a driver and should not
>>> +		 * be pinned indefinitely as it prevents the driver moving the
>>> +		 * page. So when trying to pin with FOLL_LONGTERM instead try
>>> +		 * migrating page out of device memory.
>>>    		 */
>>>    		if (is_dev_private_or_coherent_page(head)) {
>>> +			/*
>>> +			 * device private pages will get faulted in during gup
>>> +			 * so it shouldn't be possible to see one here.
>>> +			 */
>>>    			WARN_ON_ONCE(is_device_private_page(head));
>>> -			ret = -EFAULT;
>>> -			goto unpin_pages;
>>> +			WARN_ON_ONCE(PageCompound(head));
>>> +
>>> +			/*
>>> +			 * migration will fail if the page is pinned, so convert
>>> +			 * the pin on the source page to a normal reference.
>>> +			 */
>>> +			if (gup_flags & FOLL_PIN) {
>>> +				get_page(head);
>>> +				unpin_user_page(head);
>>
>> OK...but now gup_flags can no longer be used as a guide for how to
>> release these pages, right? In other words, up until this point,
>> FOLL_PIN meant "call unpin_user_page() in order to release". However,
>> now this page must be released via put_page().
> 
> This is the source page (head). We are unpinning it because we can't migrate a
> pinned page, however we still need a reference on it for migrate_vma hence the
> get_page followed by unpin. In the non-FOLL_PIN case we already have a
> reference from gup.
> 
>> See below...
>>
>>> +			}
>>> +
>>> +			pages[i] = migrate_device_page(head, gup_flags);
> 
> migrate_device_page() will return a new page that has been correctly pinned
> with gup_flags by try_grab_page(). Therefore this page can still be released
> with unpin_user_page() or put_page() as appropriate for the given gup_flags.
> 
> The reference we had on the source page (head) always gets dropped in
> migrate_vma_finalize().

OK. Good.

The above would be good to have in a comment, right around here, imho.
Because we have this marvelous mix of references for migration (get_page())
and other, and it's a bit hard to see that it's all correct without a
hint or two.

...
> 
> Which unless I've missed something is still the correct thing to do.
> 
>> This reminds me: out of the many things to monitor, the FOLL_PIN counts
>> in /proc/vmstat are especially helpful, whenever making changes to code
>> that deals with this:
>>
>> 	nr_foll_pin_acquired
>> 	nr_foll_pin_released
>>
>> ...and those should normally be equal to each other when "at rest".
>>

I hope this is/was run, just to be sure?


thanks,
-- 
John Hubbard
NVIDIA