Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Feb 2022 15:41:07 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     David Hildenbrand <david@redhat.com>,
        Felix Kuehling <felix.kuehling@amd.com>,
        Alex Sierra <alex.sierra@amd.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org
Subject: Re: [PATCH v6 01/10] mm: add zone device coherent type memory support
Message-ID: <20220215194107.GZ4160@nvidia.com>
References: <20220201154901.7921-1-alex.sierra@amd.com>
 <20220201154901.7921-2-alex.sierra@amd.com>
 <beb38138-2266-1ff8-cc82-8fe914bed862@redhat.com>
 <f2af73c1-396b-168f-7f86-eb10b3b68a26@redhat.com>
 <a24d82d9-daf9-fa1a-8b9d-5db7fe10655e@amd.com>
 <078dd84e-ebbc-5c89-0407-f5ecc2ca3ebf@redhat.com>
 <20220215144524.GR4160@nvidia.com>
 <20220215183209.GA24409@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220215183209.GA24409@lst.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SiapKLedQeE9EysQ6XrDY/lsLa3JvPcxTNb7eas6QVYwk6akpt7qXDeQ0gB/?=
 =?us-ascii?Q?mBuHyoplPSAMubwbqeLt4zlDoN0V9ZM+J0DwTUXndPvJ/TCOiGd5TMoULbID?=
 =?us-ascii?Q?kYB4QysaBQz7J/Bav4On1/EZpaMTlJpS4BWGBds1YZNeZBXJMY768AL+Xd7y?=
 =?us-ascii?Q?ugHWkQaCmmULUZORiipP9zBwomF+pL7eZNiF0uQI3uRgKO0HHkd2dErvGvpP?=
 =?us-ascii?Q?+6lWWdDaluzI3ibs22qaoRqP4aLZ4OWPeSbayTg8oUaqgsh9Pbi/e1FRo2/P?=
 =?us-ascii?Q?uNRJB3NGaPhBluW3FXbDliM5jkxI8MMwGxxEX0wuAAdtMpI6RV4eKI5zeGUZ?=
 =?us-ascii?Q?EnOFBuaS3rVaKODhkxh7qhIs4hkLBrWQZn16wBFguiroIIJgrN60ByXldIHs?=
 =?us-ascii?Q?C7Ps5qRhATKgdF2av4UByZcIz25/0VwA0TbnP9yngyM+svsWAu+hEDamjmzd?=
 =?us-ascii?Q?iLprd07sHLSxpAixvanvobiNc9n3gcKzUUgwTiVK3kvs1ozg2joPp9BA1Cxj?=
 =?us-ascii?Q?iPRWpKs4sLi8EFaC/p43dlZmJV3ZqEM71VcvzJ4kEc2+yb+a9B2skaASC+wQ?=
 =?us-ascii?Q?6zKHK9jjU4RsFPbDfHqv3dypCZ8orv58t5aTOu2LAAt4Xfaly4OQlgCc2Ixp?=
 =?us-ascii?Q?8fBMYo7plv6CVztLjQIcEJG2kK88Nh9yAfPjtb3chdIdc/ccN1L1fj8JVqjN?=
 =?us-ascii?Q?vedkYOnloY5+l1v6ZPE5zK3/suXzQf5aFvULhJEZtx/js6yozDynszk6n2jb?=
 =?us-ascii?Q?YOUAN/kt9Ejb/WkmdcKtldNR0KoaEap1lu57jnIfq4+FEAZ/PfU/CzPndrPq?=
 =?us-ascii?Q?1Thneji1+XPkjpvZh2bwHoSK0P9RJgFmqeT1tFAbTHG94T2wIZkCYd2uk3Yl?=
 =?us-ascii?Q?yfzX+LtHGRt9p8JByhcMbtv785HAcAflKetEr50B0utqCHNSNmcrFpF/TWVl?=
 =?us-ascii?Q?yB9zlE1+LEKTlStvbfn5dPj+Nx332FYq8P6yi+oIojIiuTi7WpyK9viH7n94?=
 =?us-ascii?Q?cVdItTxXXhJb5q3eoebn6mWtvrDGnbxuzkBCtqUDxRIm/Bxr/rsa1Vt5KBVH?=
 =?us-ascii?Q?2ul1RZmoED106VK7SYSgi13+56yZx07GH1tIkiwE6hxByFlNIjWtYQZkStzF?=
 =?us-ascii?Q?JUSiQDSreoeskZxWrxS3UMbzYVPur7LYZH5admzumKQo/RVqa81lqEHQuolA?=
 =?us-ascii?Q?zzj4ppsmoKnU7xJvpBNLbOew1sknHEajXqMez14/MbeR4/kkdZg7IcFnkzQC?=
 =?us-ascii?Q?73RLlG17XegvrgwmC498yfhwcYLyqIoTUSDaVIJkJoRmf/4+CDrPx6/LR38R?=
 =?us-ascii?Q?z1w5Aw02vT888VBjfOJzHBT+d/m/jPPRcX21ht9NFLYog5EsSbgfxP8NulSU?=
 =?us-ascii?Q?5oyXemPc2xyo3IbozwwpSlN3Kf04Kw0+AlxQNsbU9TwfsdKAZHjbuI908O5t?=
 =?us-ascii?Q?uM1y8VLgTXLUTCAxrG/7NMBeInVpW9/FFERP2sNZ5geUTRtiRxKaB3UWx8P+?=
 =?us-ascii?Q?rubt+G86FzYAr26OK0+TKCKWTxYyitFs85b8Aw97b8wKr2piF8imNSXKD7dj?=
 =?us-ascii?Q?5AjdeiMZoDez3JFsTvU=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce9ed6c9-e468-44c2-58eb-08d9f0bb1d04
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4181.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 19:41:08.8055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ebfX0zdAcAyLd5D0mp7ojeMRgTcF6hXiIlUekifakEADrQqGmK/LCkAdmMmx9XXW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3392
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Tue, Feb 15, 2022 at 07:32:09PM +0100, Christoph Hellwig wrote:
> On Tue, Feb 15, 2022 at 10:45:24AM -0400, Jason Gunthorpe wrote:
> > > Do you know if DEVICE_GENERIC pages would end up as PageAnon()? My
> > > assumption was that they would be part of a special mapping.
> > 
> > We need to stop using the special PTEs and VMAs for things that have a
> > struct page. This is a mistake DAX created that must be undone.
> 
> Yes, we'll get to it.  Maybe we can do it for the non-DAX devmap
> ptes first given that DAX is more complicated.

Probably, I think we can check the page->pgmap type to tell the
difference.

I'm not sure how the DEVICE_GENERIC can work without this, as DAX was
made safe by using the unmap_mapping_range(), which won't work
here. Is there some other trick being used to keep track of references
inside the AMD driver?

Jason