Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp734475pxm; Fri, 25 Feb 2022 18:41:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPS4jyXklBajROGgyvNL/rUyGg/05G6KktiHkheUKUPvrDlY/WTy8tosyHQSyBUa1OB9Kr X-Received: by 2002:a63:a18:0:b0:374:7b9f:4ec4 with SMTP id 24-20020a630a18000000b003747b9f4ec4mr8519842pgk.481.1645843298843; Fri, 25 Feb 2022 18:41:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645843298; cv=none; d=google.com; s=arc-20160816; b=YTQw4SVmnbms04eRnQ4H32/8AW7kFH8B81BQ9PvlaG/0N0D4E7Q+A1isO3mZBIPC+K jr2IFxhfTGtowVO5zi9qkzHUipFknxtdzLKWZbJnTw4O4mG9VQK2XHu3nwy3Gnrn6obN Nw1WW732TnR2TVkEiIoJpYUYHaj/otLVuByMF+DBoUhs26F9dcy4Sr+AWNd1gUD51UXg roFYP6G3RLSKpm/KaKUr9IoAz50DU9db5WneIKC+aSfil2QKsDNjvYdLAZAmTytbHAha 2uw3fIt4BgTH+9/rUE3XUYB4I85/Ct0EjdKg5zi/9Hs1PP4K04gVOZRIca1fEK37y4Y1 Y97w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=y+FQanSM3iUCMuPIjebGO75+JE0n44JzwEIo4lR7R54=; b=JbmI87XLwWuiaWid+mHLEdYNO2tCSuNm3aNQi24dHtmwZYsJt8kmwdQwPFquTJeUzc c0aiPfCyFuU2KunTBXLnuZh0Lhp5jUFzcAs7TyXLIKtnVl0dhvbpU2RczBnExIVkv1he Wwup0D6WHRwXoGNaf/JOdh8WqUuciZ6WmVqG4Vlf5xjHTkr4i6DmFsHNVehdJGFyTTzc JjnnOxr4zL4RvnzKOgiOnpwZ8M1o94OOpQ+T1x5tyvHc6zS5koQ41wgIXJdba6EckTgX lR4MbtpHioHFyvZF0myGHz0QwWHY/+53WZ5Sp/KOAi1UK4RaS8CsLFp0zR89UhFv9gpf UJgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id i20-20020a63d454000000b0035e108e4c2fsi3198522pgj.538.2022.02.25.18.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 18:41:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2993C2AA3C7; Fri, 25 Feb 2022 18:06:30 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233882AbiBYX3M (ORCPT + 99 others); Fri, 25 Feb 2022 18:29:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230190AbiBYX3L (ORCPT ); Fri, 25 Feb 2022 18:29:11 -0500 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 814AF12341F for ; Fri, 25 Feb 2022 15:28:36 -0800 (PST) Received: from dread.disaster.area (pa49-186-17-0.pa.vic.optusnet.com.au [49.186.17.0]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id A74AA53067E; Sat, 26 Feb 2022 10:28:35 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nNk0o-00GR4A-LP; Sat, 26 Feb 2022 10:28:34 +1100 Date: Sat, 26 Feb 2022 10:28:34 +1100 From: Dave Chinner To: Artem Blagodarenko Cc: linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, Andrew Perepechko Subject: Re: [PATCH] ext4: truncate during setxattr leads to kernel panic Message-ID: <20220225232834.GR3061737@dread.disaster.area> References: <20220225110413.1663-1-artem.blagodarenko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220225110413.1663-1-artem.blagodarenko@gmail.com> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=e9dl9Yl/ c=1 sm=1 tr=0 ts=62196624 a=+dVDrTVfsjPpH/ci3UuFng==:117 a=+dVDrTVfsjPpH/ci3UuFng==:17 a=kj9zAlcOel0A:10 a=oGFeUVbbRNcA:10 a=7-415B0cAAAA:8 a=x6FlVVwMinsx5J1ogNAA:9 a=CjuIK1q_8ugA:10 a=rEb7KsgoP-gA:10 a=biEYGPWJfzWAr4FL6Ov7:22 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Feb 25, 2022 at 06:04:13AM -0500, Artem Blagodarenko wrote: > @@ -1791,7 +1821,7 @@ static int ext4_xattr_set_entry(struct ext4_xattr_info *i, > ret = 0; > out: > iput(old_ea_inode); > - iput(new_ea_inode); > + delayed_iput(old_ea_inode, diwork); That looks broken.... Cheers, Dave. -- Dave Chinner david@fromorbit.com