Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2464750pxm; Sun, 27 Feb 2022 22:36:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJzHYOg3xzuZv8G+FNwDBdynkSA8733Fhd3MukTlEwk87hdTNimcBIWFinZ4kwR07ORsVi/S X-Received: by 2002:a50:fb89:0:b0:413:94d8:7c56 with SMTP id e9-20020a50fb89000000b0041394d87c56mr8335454edq.143.1646030186640; Sun, 27 Feb 2022 22:36:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646030186; cv=none; d=google.com; s=arc-20160816; b=sT/VvfUy5iRYjxkaQYCQNpQoqIQuWilZzK/BA5xro37fNAdd4Cu7Zu8ORKbzEZd6iy Ui7+rMB2+PGBGTaBjai7mnPFDHFVtQmnF+XTzTWU0Ze4xj9PVyQKIs5TRAhgfEH/KvcF FNy9Yml5Lt2JjwaZ958MzejyWjIc4m7nZ5JqNHVhq2WZLyEc4Rencmudf1DFlTpv491y 2xFB3h63sk0oo4XSeab/On0KCuxX7ESCo8kJql/KKFqAse+40qP6STE4omFNfNOa/Ll5 jLehYUMnvldlTIkU8ZHKsXRmGOAcU+VqR+yhFCP39RwN6x+X6f7I2ZcPQ1Dr8f1yCeh6 MEOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:references:in-reply-to:subject :cc:to:from:mime-version:content-transfer-encoding:dkim-signature :dkim-signature; bh=OsOdRKyOPTsqFVySVeje99MCazN8FHXIRZGctTB3Fjc=; b=MxVAXGfoGhoW0/HcUiSPxR6j5zMGPH6+AU7FT9Vd9AyD4F2HsOsIiAdnGuyuMwzJZm K5WEqbBsyVKx7n29m3FGHHoR7LC72trPSj7yJgRCwzi5RiTouz8sE7a8eHPDX5paUONN WIn/G4WQAwx+JxVrnd5QwqeR5MUpMzE+NXpyIU7gYG4m3CAuBomV6jliJqBu049oYFdB JOuhXCfozTqpjptgjhgX52bE2t38LJZc1PIYyN0oV+QczYo3DUyL7VWysZTjYfqMbgK3 jXwsSMdZCuHEKZNuqh0ZXxI0CPQrBjSvvfmPAEZslhTN/FrUEfT397eHSL9r9wySUZnM VgmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=1aDnYNyC; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=ETy1bbk4; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qb35-20020a1709077ea300b006b51bc8230fsi6892291ejc.671.2022.02.27.22.36.01; Sun, 27 Feb 2022 22:36:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=1aDnYNyC; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=ETy1bbk4; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233060AbiB1FUQ (ORCPT + 99 others); Mon, 28 Feb 2022 00:20:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230123AbiB1FUP (ORCPT ); Mon, 28 Feb 2022 00:20:15 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8613939154; Sun, 27 Feb 2022 21:19:37 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E6BD921155; Mon, 28 Feb 2022 05:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646025575; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OsOdRKyOPTsqFVySVeje99MCazN8FHXIRZGctTB3Fjc=; b=1aDnYNyCMKoqi7852ELng+RjN9qj4H3oZKIs6lZKTxoiwJvkWraBZGmj+Lgr7uB+1SHFJz Yh2mZu17ZFxMhdj6twoLK7xeDGS6uw7JuUWs/fN+ewmZBdcdER+polBa/xGaRr74gldhFA Ag1t4rw/IZDJ70lWUTD3DCkE1pDKQVg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646025575; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OsOdRKyOPTsqFVySVeje99MCazN8FHXIRZGctTB3Fjc=; b=ETy1bbk4AvRTgoyR516RJsfNTn47d24xVl6EFjxT7PerkTAmm+E/x1KFcnx2xiTY9paC/z 4vNKWy2UyfSPGfDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6E5C712FC5; Mon, 28 Feb 2022 05:19:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5BzICmBbHGIXfAAAMHmgww (envelope-from ); Mon, 28 Feb 2022 05:19:28 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: "NeilBrown" To: "Andrew Morton" Cc: "Jan Kara" , "Wu Fengguang" , "Jaegeuk Kim" , "Chao Yu" , "Jeff Layton" , "Ilya Dryomov" , "Miklos Szeredi" , "Trond Myklebust" , "Anna Schumaker" , "Ryusuke Konishi" , "Darrick J. Wong" , "Philipp Reisner" , "Lars Ellenberg" , "Paolo Valente" , "Jens Axboe" , linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, ceph-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 02/11] MM: document and polish read-ahead code. In-reply-to: <20220227204728.b2eb5dd94ecc3e86912bacad@linux-foundation.org> References: <164447124918.23354.17858831070003318849.stgit@noble.brown>, <164447147257.23354.2801426518649016278.stgit@noble.brown>, <20220210122440.vqth5mwsqtv6vjpq@quack3.lan>, <164453611721.27779.1299851963795418722@noble.neil.brown.name>, <20220224182622.n7abfey3asszyq3x@quack3.lan>, <164602251992.20161.9146570952337454229@noble.neil.brown.name>, <20220227204728.b2eb5dd94ecc3e86912bacad@linux-foundation.org> Date: Mon, 28 Feb 2022 16:19:24 +1100 Message-id: <164602556430.20161.5451268677064506613@noble.neil.brown.name> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 28 Feb 2022, Andrew Morton wrote: > On Mon, 28 Feb 2022 15:28:39 +1100 "NeilBrown" wrote: > > > When writing documentation the intent of the author is of some interest, > > but the behaviour of the code is paramount. > > uh, er, ah, no. The code describes the behaviour of the code. The > comments are there to describe things other than the code's behaviour. > Things such as the author's intent. > > Any deviation between the author's intent and the code's behaviour is > called a "bug", so it's pretty important to understand authorial > intent, no? When the author is writing the documentation - then yes - definitely. When the "author" is several different people over a period of years, then it is not even certain that there is a single unified "intent". The author's intent is less interesting not so much because it is less relevant, but because it is less available. So when writing third-party post-hoc documentation, the focus has to be on the code, though with reference to the intent to whatever extent it is available. Bugs then show up where the actual behaviour turns out to be impossible to document coherently. Thanks, NeilBrown