Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <07A89A7C-93D0-4B86-BCE7-BC77F671C67C@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_39F772CF-8919-4126-AAF4-D52C6A0548FC";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH 3/3] e2fsprogs: use mallinfo2 instead of mallinfo if
 available
Date:   Mon, 28 Feb 2022 16:49:43 -0700
In-Reply-To: <20220217092500.40525-3-lczerner@redhat.com>
Cc:     "Theodore Y. Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org
To:     Lukas Czerner <lczerner@redhat.com>
References: <20220217092500.40525-1-lczerner@redhat.com>
 <20220217092500.40525-3-lczerner@redhat.com>
Precedence: bulk


--Apple-Mail=_39F772CF-8919-4126-AAF4-D52C6A0548FC
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Feb 17, 2022, at 2:25 AM, Lukas Czerner <lczerner@redhat.com> wrote:
>=20
> mallinfo has been deprecated with GNU C library version 2.33 in favor =
of
> mallinfo2 which works exactly the same as mallinfo but with larger =
field
> widths. Use mallinfo2 if available.
>=20
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>

Nice that a replacement for mallinfo() API was finally added to glibc.

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> configure               |  2 +-
> configure.ac            |  1 +
> e2fsck/iscan.c          | 11 ++++++++++-
> e2fsck/util.c           | 11 ++++++++++-
> lib/config.h.in         |  3 +++
> resize/resource_track.c | 13 ++++++++++---
> 6 files changed, 35 insertions(+), 6 deletions(-)
>=20
> diff --git a/configure b/configure
> index effd929d..530bc77c 100755
> --- a/configure
> +++ b/configure
> @@ -11254,7 +11254,7 @@ fi
> if test -n "$DLOPEN_LIB" ; then
>    ac_cv_func_dlopen=3Dyes
> fi
> -for ac_func in  	__secure_getenv 	add_key 	=
backtrace 	chflags 	dlopen 	fadvise64 	fallocate 	=
fallocate64 	fchown 	fcntl 	fdatasync 	fstat64 	fsync 	=
ftruncate64 	futimes 	getcwd 	getdtablesize 	getentropy 	=
gethostname 	getmntinfo 	getpwuid_r 	getrandom 	=
getrlimit 	getrusage 	jrand48 	keyctl 	llistxattr 	=
llseek 	lseek64 	mallinfo 	mbstowcs 	memalign 	=
mempcpy 	mmap 	msync 	nanosleep 	open64 	pathconf 	=
posix_fadvise 	posix_fadvise64 	posix_memalign 	prctl 	pread 	=
pwrite 	pread64 	pwrite64 	secure_getenv 	setmntent 	=
setresgid 	setresuid 	snprintf 	srandom 	stpcpy 	=
strcasecmp 	strdup 	strnlen 	strptime 	strtoull 	=
sync_file_range 	sysconf 	usleep 	utime 	utimes 	valloc
> +for ac_func in  	__secure_getenv 	add_key 	=
backtrace 	chflags 	dlopen 	fadvise64 	fallocate 	=
fallocate64 	fchown 	fcntl 	fdatasync 	fstat64 	fsync 	=
ftruncate64 	futimes 	getcwd 	getdtablesize 	getentropy 	=
gethostname 	getmntinfo 	getpwuid_r 	getrandom 	=
getrlimit 	getrusage 	jrand48 	keyctl 	llistxattr 	=
llseek 	lseek64 	mallinfo 	mallinfo2 	mbstowcs 	=
memalign 	mempcpy 	mmap 	msync 	nanosleep 	open64 	=
pathconf 	posix_fadvise 	posix_fadvise64 	posix_memalign 	=
prctl 	pread 	pwrite 	pread64 	pwrite64 	secure_getenv 	=
setmntent 	setresgid 	setresuid 	snprintf 	srandom 	=
stpcpy 	strcasecmp 	strdup 	strnlen 	strptime 	strtoull =
	sync_file_range 	sysconf 	usleep 	utime 	utimes 	=
valloc
> do :
>   as_ac_var=3D`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
> ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
> diff --git a/configure.ac b/configure.ac
> index dff3d1ca..8acc4e1c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1214,6 +1214,7 @@ AC_CHECK_FUNCS(m4_flatten([
> 	llseek
> 	lseek64
> 	mallinfo
> +	mallinfo2
> 	mbstowcs
> 	memalign
> 	mempcpy
> diff --git a/e2fsck/iscan.c b/e2fsck/iscan.c
> index 607e4752..33c6a4cd 100644
> --- a/e2fsck/iscan.c
> +++ b/e2fsck/iscan.c
> @@ -109,7 +109,16 @@ void print_resource_track(const char *desc,
> 		printf("%s: ", desc);
>=20
> #define kbytes(x)	(((unsigned long long)(x) + 1023) / 1024)
> -#ifdef HAVE_MALLINFO
> +#ifdef HAVE_MALLINFO2
> +	if (1) {
> +		struct mallinfo2 malloc_info =3D mallinfo2();
> +
> +		printf("Memory used: %lluk/%lluk (%lluk/%lluk), ",
> +		       kbytes(malloc_info.arena), =
kbytes(malloc_info.hblkhd),
> +		       kbytes(malloc_info.uordblks),
> +		       kbytes(malloc_info.fordblks));
> +	} else
> +#elif defined HAVE_MALLINFO
> 	/* don't use mallinfo() if over 2GB used, since it returns "int" =
*/
> 	if ((char *)sbrk(0) - (char *)track->brk_start < 2LL << 30) {
> 		struct mallinfo	malloc_info =3D mallinfo();
> diff --git a/e2fsck/util.c b/e2fsck/util.c
> index 3fe3c988..42740d9e 100644
> --- a/e2fsck/util.c
> +++ b/e2fsck/util.c
> @@ -430,7 +430,16 @@ void print_resource_track(e2fsck_t ctx, const =
char *desc,
> 		log_out(ctx, "%s: ", desc);
>=20
> #define kbytes(x)	(((unsigned long long)(x) + 1023) / 1024)
> -#ifdef HAVE_MALLINFO
> +#ifdef HAVE_MALLINFO2
> +	if (1) {
> +		struct mallinfo2 malloc_info =3D mallinfo2();
> +
> +		log_out(ctx, _("Memory used: %lluk/%lluk (%lluk/%lluk), =
"),
> +			kbytes(malloc_info.arena), =
kbytes(malloc_info.hblkhd),
> +			kbytes(malloc_info.uordblks),
> +			kbytes(malloc_info.fordblks));
> +	} else
> +#elif defined HAVE_MALLINFO
> 	/* don't use mallinfo() if over 2GB used, since it returns "int" =
*/
> 	if ((char *)sbrk(0) - (char *)track->brk_start < 2LL << 30) {
> 		struct mallinfo	malloc_info =3D mallinfo();
> diff --git a/lib/config.h.in b/lib/config.h.in
> index 9c9de65d..b5856bb5 100644
> --- a/lib/config.h.in
> +++ b/lib/config.h.in
> @@ -208,6 +208,9 @@
> /* Define to 1 if you have the `mallinfo' function. */
> #undef HAVE_MALLINFO
>=20
> +/* Define to 1 if you have the `mallinfo2' function. */
> +#undef HAVE_MALLINFO2
> +
> /* Define to 1 if you have the <malloc.h> header file. */
> #undef HAVE_MALLOC_H
>=20
> diff --git a/resize/resource_track.c b/resize/resource_track.c
> index f0efe114..f4667060 100644
> --- a/resize/resource_track.c
> +++ b/resize/resource_track.c
> @@ -63,8 +63,10 @@ void print_resource_track(ext2_resize_t rfs, struct =
resource_track *track,
> #ifdef HAVE_GETRUSAGE
> 	struct rusage r;
> #endif
> -#ifdef HAVE_MALLINFO
> -	struct mallinfo	malloc_info;
> +#ifdef HAVE_MALLINFO2
> +	struct mallinfo2 malloc_info;
> +#elif defined HAVE_MALLINFO
> +	struct mallinfo malloc_info;
> #endif
> 	struct timeval time_end;
>=20
> @@ -76,8 +78,13 @@ void print_resource_track(ext2_resize_t rfs, struct =
resource_track *track,
> 	if (track->desc)
> 		printf("%s: ", track->desc);
>=20
> -#ifdef HAVE_MALLINFO
> #define kbytes(x)	(((unsigned long)(x) + 1023) / 1024)
> +#ifdef HAVE_MALLINFO2
> +	malloc_info =3D mallinfo2();
> +	printf("Memory used: %luk/%luk (%luk/%luk), ",
> +		kbytes(malloc_info.arena), kbytes(malloc_info.hblkhd),
> +		kbytes(malloc_info.uordblks), =
kbytes(malloc_info.fordblks));
> +#elif defined HAVE_MALLINFO
>=20
> 	malloc_info =3D mallinfo();
> 	printf("Memory used: %luk/%luk (%luk/%luk), ",
> --
> 2.34.1
>=20


Cheers, Andreas


--Apple-Mail=_39F772CF-8919-4126-AAF4-D52C6A0548FC
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmIdX5cACgkQcqXauRfM
H+DPYBAArZNJTkZ64edLbWljPOk6F6ucwFrK40HgBg1ojrFdYFwfIKphumAdmcde
JcloiEsIC8m3dg5ud0BBJHbHUPoG/UddLTEfh4UoK9AUkmRVwq50TxBPwl4xqmAy
Lp9YJM4Pvn5+B+wqUQKUA+VKVVU/1vs95rRoegFJL6lmalxouHUXSz7Bel+FNPFE
+N1HQugDL/1lPbjgNJjc+Bi5CoNwoy0OppNkoCbSAGl2GiJXJFqzq/iyM9nbK08f
SRnJyaRr3Kf4wGuBerrwDatwjaM0NPBGOQ05srZnHA4X0JyLR1e9WyV9jrzijDNy
x7acU/QuKQIje51Gd8cDw+6p8Laj7gMAuUp/OiW4YklDAKZMX71zTsYGrslBFQRe
Ya2QArZPGzObRWLrl0iNHFsIpLa+/Ex9Ue81tdTfpKZdoWwLRHe41vtElG738aNM
B0vkzLrWrPAJHOkSpGGMKVPxChfWU3n3Js+KVFwIg8s7QM4wpNKP1mBYUgbLi8Kd
uh7hH1larxP5BOWuw71N4wTW46WfpThCWlvm1Mqx/ZJCAaaWbx+UvREiDDuZrT1u
EAtVQFEyZm4qj+tksdYVWfXYPbFo+qo4UJ6bot54y8njzm4cnr8hMKvnTkd1cCHi
RXHC//UdxAHqkgmQ5bCZr3CGpvzKnWX9MHOTt9HzsN44886DjWE=
=GfMG
-----END PGP SIGNATURE-----

--Apple-Mail=_39F772CF-8919-4126-AAF4-D52C6A0548FC--