Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <353c7bbd-b20e-8a7a-029a-cda9b531e5e8@amd.com>
Date:   Tue, 1 Mar 2022 11:30:13 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] mm: split vm_normal_pages for LRU and non-LRU handling
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        Alex Sierra <alex.sierra@amd.com>, jgg@nvidia.com
Cc:     rcampbell@nvidia.com, willy@infradead.org, apopple@nvidia.com,
        dri-devel@lists.freedesktop.org, linux-xfs@vger.kernel.org,
        linux-mm@kvack.org, jglisse@redhat.com,
        amd-gfx@lists.freedesktop.org, akpm@linux-foundation.org,
        linux-ext4@vger.kernel.org, hch@lst.de
References: <20220218192640.GV4160@nvidia.com>
 <20220228203401.7155-1-alex.sierra@amd.com>
 <2a042493-d04d-41b1-ea12-b326d2116861@redhat.com>
 <41469645-55be-1aaa-c1ef-84a123fdb4ea@amd.com>
 <bfae7d17-eb50-55b1-1275-5ba0f86a5273@redhat.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <bfae7d17-eb50-55b1-1275-5ba0f86a5273@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzN0SkE2L2loMWcyMGduVEoxNzNWMW9qRzZtalVkbXFKRDJ3SEx4a2FNdjVj?=
 =?utf-8?B?NU1aZzJQVDBrWDN3NHpNdFI4djlLV2liQzUrbzU4cGgzL25vaTRiZEh6ZDB2?=
 =?utf-8?B?dkcvYXRNdkNETE1Ld2JTdUJYNS9CTU92emY4elBJWXpHeXozUGh6NXhscElU?=
 =?utf-8?B?UkJ5ZzE1dXFQakFBd2hmVVRSaE40Q1BEbXZNRkt6dElwSGlhUWFuTWR5NHVG?=
 =?utf-8?B?QnFpNzRXU2NCSjQzclhDNWdWbEIyNG1YQTVaMTFucG1KQy8yZk01ZXkvWXRn?=
 =?utf-8?B?OFVIbXY2THBPUDJ2WlM3TGMzZzExMFQ0ZGVnTWhFOTZEeFZOdlhtZ0FsRTl1?=
 =?utf-8?B?NlhvbjlOR3hPRDhGWnJZZTFmcWlZWE9NU1VneUQwZVZKTDZKTVVOSjUzbXR3?=
 =?utf-8?B?aStzUFRSSE5BZVg2SWg2UDFrU1Zpb056bDA5N3RSUnhWMG1BT0Fid1dxZ0tx?=
 =?utf-8?B?Z1Nod1c5YzNOQ29LVXp5SURUQUFOZVZGNGhsdllsSnZpSnpBaWlaYTN2YnhV?=
 =?utf-8?B?NGZ5c1dsQ2U2MFIxTU03VlpueWhTeVlzZ2dBWVZGY2JyVHZZNEo2QmF4Mmpz?=
 =?utf-8?B?TWZ6L043R3NNaFhBWHEzcjZXcER6cUZzTTUyNDhramhtamNQQmFJbTlnbm12?=
 =?utf-8?B?U2ltcERZWmE2d0cyRzFtdEdYa1RTc0pETUtUYlNwQXFiS29zRkVsQno4V1Y1?=
 =?utf-8?B?OGpQRzE2N0d2aTd4V3ZoMlg0eDlGRktQa2xsQ2JPQ1ZWK3dHSE1rUWdBdU5U?=
 =?utf-8?B?TUMzSjlMbk5jZWVlUHlweHkvRlNuMVlRUTBFNmlQM3lmWVdwclVmRnk4SXNy?=
 =?utf-8?B?ZVA3T3ZWNW1XaHVYaStzVlVUQWJTME5jMzRLWXBoeEJPN21aano0dUE1US9I?=
 =?utf-8?B?dDRNQk02aFVCY05oRC9HQnRvUENkaGNGSmdZYUJhQkg2T21BSkMybTZYTkVD?=
 =?utf-8?B?aDRHMzRBaUlISXY5OElWTEVDbExkbHJRTzdPY045S1RpQStrZDFXdmpOSEEr?=
 =?utf-8?B?Uk51dWVRT2FNS0haRkpkUWh4c2FtUmQ1RjNnb2RYeEZ3TmhFRXlDbm1LWkJy?=
 =?utf-8?B?RmxLand4aC85dkdiNEdoNlJGYjZPNGlZSlJLODJXRTZrRWo3Y2JibndwWmpz?=
 =?utf-8?B?Lzl1S0JGTkFoNWRHUDI2SUtPMHV6VmtLUkRWSVZMU0p1c1ppT1FWUUF3QnBk?=
 =?utf-8?B?a3JzS3NUbDBvUkUyQmVSdmluYWpvcGhZZVR3QzVQZUFHamRvVkoyV1hQZ0RG?=
 =?utf-8?B?VGlkUm1lTm04OER3SkdLTS9PU1lqd04rcGFvUG9OTFNhWXI4YnRjWFZvUC9G?=
 =?utf-8?B?Yk1UVXIrVnd5MmcwZjNsZ21wUlJyQjhXeWFmZStEc3A1cTg3NkdlelNQc2Fy?=
 =?utf-8?B?YktyRVZudEo4allEaWxjeE13dXlxUDRMdEszT1h3RHIra1oxclQ4b0s3VGdC?=
 =?utf-8?B?aHBQL2ljWG5qeXRPQ1duM1JTajdaKzIreFRhQnVmYkpzWng4VlJKYzZDRklk?=
 =?utf-8?B?Ykg5Mk5MZEwvY292cWNjN2hvWHRzZTAwVVN6SjY4aS9BL1l4cUdSSkZRblVB?=
 =?utf-8?B?N0RZdUNBNkJLQWhQc1V6M0RTOU9NdjE1d0YwZk5jLzV6KzJTMHZQeGlXMTVl?=
 =?utf-8?B?TzhubnAyQmtCQTFIZ2s4NC8xNEpuclpXVnh5bFE4ZDhoZzAxNEpIelNmWkNh?=
 =?utf-8?B?aXJGdjMzbzFWUWJINjVYd3JVK2JsaUlVTldXTVBMMXBNNjJQVlN1YkJsRGdY?=
 =?utf-8?B?dXJYTytJdlpBUUtXblMxSmQ5UUhsdHkwd3dHOElqMHNlbk1vVTdaMVltSFFS?=
 =?utf-8?B?amZVWjRGTVNLdXBIS2ZFZTdxL0VnZHE4V1ZvMEdLQnFoOEdkOWJPWHJBc2xl?=
 =?utf-8?B?M05oTXNPZ3cvK3BNSXk1UnZCTkpGcWdZZjg4SWxLWHJXNXZ4RWQ3dllHdWFP?=
 =?utf-8?B?dmVGbnFUODhyMU5oMGIrSU5MRXYzR253RzByUXUybUZIVkdJN0ZpbWFHNFp5?=
 =?utf-8?B?UEVET2hCZ1VrcmNHd041TmpIelRFS3JnckhLUVp5T0FRUmxnWHRUT0g1R295?=
 =?utf-8?B?cDRBVXE2Z3B3TTVLWU5jZk1vbzlhL3VQL0V5aTJEZHlCdWdENGNrbTVNb1U4?=
 =?utf-8?B?RFhTR3ViY2tzcTdmYllkRHBqL2RUdUVBcnJxblF2OCs3OWU2NHZCdVZubitF?=
 =?utf-8?Q?VxiuxIGsh3Zljiqo6AqUSxI=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c1b39ad-8441-4e24-fbf0-08d9fba0c444
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 16:30:15.7080
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aRSG0e4IShIfDWR0J1jrUeEoFUk3UEXjGT3BNV5FnoK0QDtBRWrwnkJVwVocCSbD7/al2ia1oyoHBfMSDTHgIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5841
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

Am 2022-03-01 um 11:22 schrieb David Hildenbrand:
>>>>    		if (PageReserved(page))
>>>> diff --git a/mm/migrate.c b/mm/migrate.c
>>>> index c31d04b46a5e..17d049311b78 100644
>>>> --- a/mm/migrate.c
>>>> +++ b/mm/migrate.c
>>>> @@ -1614,7 +1614,7 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr,
>>>>    		goto out;
>>>>    
>>>>    	/* FOLL_DUMP to ignore special (like zero) pages */
>>>> -	follflags = FOLL_GET | FOLL_DUMP;
>>>> +	follflags = FOLL_GET | FOLL_DUMP | FOLL_LRU;
>>>>    	page = follow_page(vma, addr, follflags);
>>> Why wouldn't we want to dump DEVICE_COHERENT pages? This looks wrong.
>> This function later calls isolate_lru_page, which is something you can't
>> do with a device page.
>>
> Then, that code might require care instead. We most certainly don't want
> to have random memory holes in a dump just because some anonymous memory
> was migrated to DEVICE_COHERENT.
I don't think this code is for core dumps. The call chain I see is

SYSCALL_DEFINE6(move_pages, ...) -> kernel_move_pages -> do_pages_move 
-> add_page_for_migration

As far as I can tell this is for NUMA migrations.

Regards,
   Felix