Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Ritesh Harjani <riteshh@linux.ibm.com>, linux-ext4@vger.kernel.org
Cc:     "Theodore Ts'o" <tytso@mit.edu>,
        syzbot+afa2ca5171d93e44b348@syzkaller.appspotmail.com,
        Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] jbd2: Fix use-after-free of transaction_t race
Date:   Wed,  2 Mar 2022 19:41:24 -0500
Message-Id: <164626805478.621144.10561349500023646398.b4-ty@mit.edu>
In-Reply-To: <948c2fed518ae739db6a8f7f83f1d58b504f87d0.1644497105.git.ritesh.list@gmail.com>
References: <948c2fed518ae739db6a8f7f83f1d58b504f87d0.1644497105.git.ritesh.list@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 10 Feb 2022 21:07:11 +0530, Ritesh Harjani wrote:
> jbd2_journal_wait_updates() is called with j_state_lock held. But if
> there is a commit in progress, then this transaction might get committed
> and freed via jbd2_journal_commit_transaction() ->
> jbd2_journal_free_transaction(), when we release j_state_lock.
> So check for journal->j_running_transaction everytime we release and
> acquire j_state_lock to avoid use-after-free issue.
> 
> [...]

Applied, thanks!

[1/1] jbd2: Fix use-after-free of transaction_t race
      commit: cc16eecae687912238ee6efbff71ad31e2bc414e

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>