Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp354363pxm; Wed, 2 Mar 2022 17:09:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJxzlKNKyw94O5RX5xyL8cUct5K+9HmrvlBIOnt0pCsnsXagvoq+ND1VgNe90w77cPczJzcc X-Received: by 2002:a17:902:d482:b0:151:7777:856f with SMTP id c2-20020a170902d48200b001517777856fmr13713911plg.165.1646269795166; Wed, 02 Mar 2022 17:09:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646269795; cv=none; d=google.com; s=arc-20160816; b=iA9nzGXYvgSXmXHmMs7mCK7PjtZBa4lnydKq7FHsocg4WadhC1lmpXtezgnhJ6jDtg BPPrxBF6LydJkCPX0t2m+GQi5QcGZ4PSTXxexRS0nLpMJoFTGDsj1t3sIyAoWD3i3LWs 6rHcpayWobGThoBdbdKKS8ZTXH4Lforjr1mgFRe0ATTd5aPx4psVI4QePXuSGnvjpK2b 3n/EQWRiShVtUcgWwIVbShQZkBaIotNTJL4C1Cn97q6mEUGYFIePBNKr4KRfeg+g8vfJ 2xy291Ws51uBy29KrW6IcM9Ee9aontvhmO5JJaXMAyc1ioQIZzI/CB4aHX8I3+G11LO8 KSNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=1O+2yBnxKPKzOHqhPKb9NBzW03umVmrouE35aZ/h+Nk=; b=xSiHbSKW2mmB9Lgjzg8YxsiUyVpx2lrOvuTGh6guFEBEexhyvgsQqSF9Tz5DWEOHWF lhE85HP5rD1BOze8zpyZg4KzK6AW2joxhdcyvk7FL/QuG9FjWbIxvD5lfLMRpvH3DbKU VUQQunAmU4Dui8Aubrb/ZvgEk/w0sFRRxDvFTbYj0hzB0jmhQCgguTMqZyqXqrLaubET IWXx/Gd1zj88DXnkhJEJAoCVzs11t5McNsGSm3wK1K+SSHltKvY0XVm0tjdZ+WSK7TBS pws1C4mAmq7OgoEFBrNP9GGPKCsGzsprfnSwGwjS+4YJbAicGHKiC7seSmBgS1iwyJNT saSg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id z19-20020a170902ee1300b0014f88e650f3si584514plb.309.2022.03.02.17.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 17:09:55 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F2DA766634; Wed, 2 Mar 2022 16:41:54 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230451AbiCCAm2 (ORCPT + 99 others); Wed, 2 Mar 2022 19:42:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230466AbiCCAm1 (ORCPT ); Wed, 2 Mar 2022 19:42:27 -0500 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 384CE403EB for ; Wed, 2 Mar 2022 16:41:43 -0800 (PST) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 2230fTQO019234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 2 Mar 2022 19:41:30 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 9C4EE15C0038; Wed, 2 Mar 2022 19:41:29 -0500 (EST) From: "Theodore Ts'o" To: Lukas Czerner Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, Ye Bin Subject: Re: [PATCH] ext4: fix remount with 'abort' option Date: Wed, 2 Mar 2022 19:41:23 -0500 Message-Id: <164626805478.621144.15168980198456730624.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220201131345.77591-1-lczerner@redhat.com> References: <20220201131345.77591-1-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, 1 Feb 2022 14:13:45 +0100, Lukas Czerner wrote: > After commit 6e47a3cc68fc ("ext4: get rid of super block and sbi from > handle_mount_ops()") the 'abort' options stopped working. This is > because we're using ctx_set_mount_flags() helper that's expecting an > argument with the appropriate bit set, but instead got > EXT4_MF_FS_ABORTED which is a bit position. ext4_set_mount_flag() is > using set_bit() while ctx_set_mount_flags() was using bitwise OR. > > [...] Applied, thanks! [1/1] ext4: fix remount with 'abort' option commit: e3952fcce1aad934f1322843b564ff86256444b2 Best regards, -- Theodore Ts'o