Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Mar 2022 14:43:53 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Yang Shi <shy828301@gmail.com>,
        vbabka@suse.cz, kirill.shutemov@linux.intel.com,
        songliubraving@fb.com, linmiaohe@huawei.com, riel@surriel.com,
        willy@infradead.org, ziy@nvidia.com, akpm@linux-foundation.org,
        tytso@mit.edu, adilger.kernel@dilger.ca, darrick.wong@oracle.com
Cc:     lkp@intel.com, kbuild-all@lists.01.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] mm: thp: only regular file could be THP eligible
Message-ID: <202203020034.2Ii9kTrs-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220228235741.102941-5-shy828301@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u/8pcs106ir03pneBq/9XzuVSSClg6ZjojxWxi32wml7lzZI48xOvo6at7Yw?=
 =?us-ascii?Q?vz1HlSWYyMeNNp9MSQ+p2mOLNzkGl5AbwKyFLMgDxug5tbDaUSeQ/V/SmmGc?=
 =?us-ascii?Q?dXQd8QiROoNt+ST4VTJ5+5omQ0K9E6YFqNdY8dKJVxKTbM23+SCgJjTygZRM?=
 =?us-ascii?Q?1YU1NRKnGIOIaj5msKLmWConfflWZG3C87VP6KPeO798ZYi++DGFDQLoJA3f?=
 =?us-ascii?Q?mYtgJOwrVQ1Lq2Vx5qKL5uaKqWuTuf5X1NGO+BSR2TtJxp2q4UpxXjs2hZTl?=
 =?us-ascii?Q?KWzPwGcoszgwYT1UrbQVBP98Ye5NprUSNlxzaMTal/TnDMG7E3YpOYeLveQL?=
 =?us-ascii?Q?cB4ixONdhkz7r0k4bcc5cYeXFhuGpO9j2HZDUQvCchMX7oIBDMUezgrO6fXL?=
 =?us-ascii?Q?CleJ4CGlQNqQZ/gXIz0MxyPE4IiBFROAmYj4K4YOUHJqT7WprFoNEUFYojLJ?=
 =?us-ascii?Q?gN9/Z5uWJhPJ1EJrwQmjzQH0p2FW0Xa/6k+WjtDjXPu5tPMJoU4xYPavSviv?=
 =?us-ascii?Q?lIcHnj2T8aBsVZ1tJBIFM8Eh8LDd9UauuZVvJoYb75OLgMQ6S7NSfBmYixfY?=
 =?us-ascii?Q?Ksm3S5PpO4AasZqAE51Y/DuqPKwl083xpyZPfifYJQy5B2Ra6mkJpFx4I5TC?=
 =?us-ascii?Q?l9uE4D8EPiotIP8HddqebjVGRVLuc03NlW8U7ZUxULKcAB/FqPcyvFbp28Ee?=
 =?us-ascii?Q?29iU7KPhUuYfQ9klfGK51nqg9vURSL+uaQ1W8tkZLezemylqN3z4h3GU74eD?=
 =?us-ascii?Q?14bfUyVBBGq+5at6WUPZ+70DaZgZ3kv/i09RZwzOqhIk8VeIcJTAnrlVOfkv?=
 =?us-ascii?Q?cL4MeIYs+af9zjeHuYmaolKXSA4sq89QvLtCXzioe2DQi4UQbhlm39L8wqEQ?=
 =?us-ascii?Q?YnHgSGacXGIvFPS/kTkr6Tv6ZvY01eqE64MBByz88OuoPvueQeXWwI2dQGk9?=
 =?us-ascii?Q?9eT6of+9IjqByhlZNV2q7V2S89GvuqHcrk5AR3EekMdQMO3bi1p5baxFp6GN?=
 =?us-ascii?Q?eo0zQIQNM6pyLKOpxoqBJ/274YhsHJXwCIf9a/2gvKG/3JOYlktWE2wBSFnc?=
 =?us-ascii?Q?bXZYRjSD9OdFO/bVtMZ38TmSJy2vvEJFtgb9S817pARMf661IqSJjGqd2ni0?=
 =?us-ascii?Q?mnwrQlwoMqcmRctwbL5JyDxzMISTNZsuMv9r9wnAC2u5M9VuJS5TSRV4m+uM?=
 =?us-ascii?Q?Mmtv3UEja36wpUc5Vh0ec/JQzaK+HtTbhTvbRP4QlLX0TITDb2OBlE0rPyri?=
 =?us-ascii?Q?D35j+PEK/EtAh/yvxFKi2NH+Hg92lfcdb6gLwqfEpzR4OElxR7Ebz1Rx3DB+?=
 =?us-ascii?Q?CKMm+JGWNYPifXlF7LjA72k4CkYck3XGqUsNGk4/qlNyXCSwnAwasfQRbeqc?=
 =?us-ascii?Q?lAxtPrg+VnBVQpK+7ccTUbEcxpIP4pdO/nHcfFTZdfWT9XADILKyrrrj0w+C?=
 =?us-ascii?Q?7Un/iA1dCfzJAhGFARaHb9GVftCQSuALumEKvL0DbDgwPPDXL9dBKRii+1/Z?=
 =?us-ascii?Q?lk4YfIL1LW2ihTjGz7nKdReVc4mXPTlfU92NqQ8NJt+fS8LRJlHJv9jWLSnx?=
 =?us-ascii?Q?GSbE7dpxOUJIGyRF6A1PtfkJiubKJKG8xId/hW2CA3kpNdlttzug2wQtihCp?=
 =?us-ascii?Q?Zo5Snci/SMBuzJ2QBtrs0icjl19lJ8tiyFsZQ4kR5ZKG4UQiR/8T59TmxAa3?=
 =?us-ascii?Q?3wtMZA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99673b18-0f42-43c2-8075-08d9fd0b2d31
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 11:44:29.8696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QGYM8wR0lzQLy9wf+WCWZEFddc9jKfEa8T2qRL6lCnJ9WqDLe/bVYEdoURNh/j1Ai62HfqmyOLelY9+hKeNOWEhDV5p4tI9mI/k3HQkCWOQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2646
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=862
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2203030056
X-Proofpoint-ORIG-GUID: oJ3hnQwkr4hx2gm-2r0yhZwe6poyy6pz
X-Proofpoint-GUID: oJ3hnQwkr4hx2gm-2r0yhZwe6poyy6pz
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FAKE_REPLY_C,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

Hi Yang,

url:    https://github.com/0day-ci/linux/commits/Yang-Shi/Make-khugepaged-collapse-readonly-FS-THP-more-consistent/20220301-075903
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: arm64-randconfig-m031-20220227 (https://download.01.org/0day-ci/archive/20220302/202203020034.2Ii9kTrs-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
include/linux/huge_mm.h:179 file_thp_enabled() warn: variable dereferenced before check 'vma->vm_file' (see line 177)
mm/khugepaged.c:468 hugepage_vma_check() error: we previously assumed 'vma->vm_file' could be null (see line 455)
include/linux/huge_mm.h:179 file_thp_enabled() warn: variable dereferenced before check 'vma->vm_file' (see line 177)

vim +179 include/linux/huge_mm.h

2224ed1155c07b Yang Shi     2022-02-28  175  static inline bool file_thp_enabled(struct vm_area_struct *vma)
2224ed1155c07b Yang Shi     2022-02-28  176  {
2224ed1155c07b Yang Shi     2022-02-28 @177  	struct inode *inode = vma->vm_file->f_inode;
                                                                      ^^^^^^^^^^^^^^
Dereference.

2224ed1155c07b Yang Shi     2022-02-28  178  
2224ed1155c07b Yang Shi     2022-02-28 @179  	return (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS)) && vma->vm_file &&
                                                                                                    ^^^^^^^^^^^^
Checked too late.

2224ed1155c07b Yang Shi     2022-02-28  180  	       (vma->vm_flags & VM_EXEC) &&
2224ed1155c07b Yang Shi     2022-02-28  181  	       !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode);
2224ed1155c07b Yang Shi     2022-02-28  182  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org