Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2212360pxm; Fri, 4 Mar 2022 11:29:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJz9mZzZrPALAJg++dJCjMql7De7sp7LCvSyRz9Y+QlxG3fdJmQ7tD0QAQVoRQR33v8pgM18 X-Received: by 2002:a17:902:f64e:b0:14d:20db:8478 with SMTP id m14-20020a170902f64e00b0014d20db8478mr42217617plg.158.1646422189454; Fri, 04 Mar 2022 11:29:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646422189; cv=none; d=google.com; s=arc-20160816; b=RTfEBrM9WAcNuli+gjrhTV9FUL5ghD3QfcX7pFbKpb6xU7Iw1lbpZ1fBbv8ZkjVpJy DlGMDGijo2/ZsLhb4PqT7onEJiC5h2SZ4lrNkOPxGw0SK+EmAG/S5FWEUqa1O+3fTRus tgCv1VSybY9xsm83/rtlXGeGjpasPXHKCIop1BgAymH6ZJGIadvfijDjJiMhVLw8idlF 7uQFPkMyBgWRV7cCSfrpMaDrYaSe8l91uzminG7QCpV6JBEwV8+kX6Pd4oG8xIXyuQ2U dsgytu7//p7E1c4fFFTMA1iXHvTNJiGen3354N2J73Z0l990pIlSvRq9PoEbidgNGN1R aG4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FfOImJllLJqmphH4LRFKDUX/RFMK65Kob49l+6sR3wE=; b=tyEPMiIvqsdRE9rlB1aHvT7/Qe59lVA+tV267HvJelWBDGdV3dfTVnKxAt/f8eFJEq eZetp+XDxSHvgDW7e7wDPiLWl8WHeBHiSfdDoYXTCoy22dtNpEX3yVo4qlJgUbQyP16b nWgjsShhspJhUZ+OH+LFI1lArdkwlmcYWLjlQ1JRp5NHBo0VengXnCD4doL81dq1SLuj jD8ApDVXUAcDSJw3uMKOI156qMMDOfmYtljfcmUnqV7ZDRK2TyMFZOaFGTUEVMs/JMjH 8GZin5qF2+rMywC7yZuHO2IqSG5PSMuJ89PEzKwafRTA1u0veMpGiOEF6N7QjZ799hdq 4zrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="nKzOU/Cy"; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id v190-20020a6389c7000000b0037c92962ee3si2741745pgd.21.2022.03.04.11.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 11:29:49 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="nKzOU/Cy"; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8FFC421416E; Fri, 4 Mar 2022 11:12:22 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241478AbiCDSC1 (ORCPT + 99 others); Fri, 4 Mar 2022 13:02:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241466AbiCDSCS (ORCPT ); Fri, 4 Mar 2022 13:02:18 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7F1A1C65D0; Fri, 4 Mar 2022 10:01:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=FfOImJllLJqmphH4LRFKDUX/RFMK65Kob49l+6sR3wE=; b=nKzOU/Cy42CV4CGN1okxM6keyy wcxMDRWNVQ5ygLlkQWYYVVPZIN/6LSKjfMFJmgWMn4IGLkT1Wz9w8LZOI+XLMrCX3KgzfytUR595A HJA2wz/7dNT+mGjb/M6iTmPu4zizZRj9ZHcoMBkBAjhI4eczNxztNTtSf7SXM/VRyr+xxwSb5Bzn7 6IOeHRSPbLhtXBGf+7UUqEQs9WpKJj2aVzRsLEMnvB+BYeUuSP1GkJzRx0s3tAWkoyOL3YU0tlEBI vkhcK1I/krHbfAsnL0ZW787zKWN2YO3s8kattoGllWV6pBnSB8a4guY/K5STxdDtMZIkAvoBXZRve 38xtOOUg==; Received: from [2001:4bb8:180:5296:cded:8d4b:ace6:f3c] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQCF1-00BUru-RD; Fri, 04 Mar 2022 18:01:24 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Song Liu , "Theodore Ts'o" , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org Subject: [PATCH 06/10] md-multipath: stop using bio_devname Date: Fri, 4 Mar 2022 19:01:01 +0100 Message-Id: <20220304180105.409765-7-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220304180105.409765-1-hch@lst.de> References: <20220304180105.409765-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Use the %pg format specifier to save on stack consuption and code size. Signed-off-by: Christoph Hellwig --- drivers/md/md-multipath.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/md/md-multipath.c b/drivers/md/md-multipath.c index c056a7d707b09..bc38a6133cda3 100644 --- a/drivers/md/md-multipath.c +++ b/drivers/md/md-multipath.c @@ -294,7 +294,6 @@ static void multipathd(struct md_thread *thread) md_check_recovery(mddev); for (;;) { - char b[BDEVNAME_SIZE]; spin_lock_irqsave(&conf->device_lock, flags); if (list_empty(head)) break; @@ -306,13 +305,13 @@ static void multipathd(struct md_thread *thread) bio->bi_iter.bi_sector = mp_bh->master_bio->bi_iter.bi_sector; if ((mp_bh->path = multipath_map (conf))<0) { - pr_err("multipath: %s: unrecoverable IO read error for block %llu\n", - bio_devname(bio, b), + pr_err("multipath: %pg: unrecoverable IO read error for block %llu\n", + bio->bi_bdev, (unsigned long long)bio->bi_iter.bi_sector); multipath_end_bh_io(mp_bh, BLK_STS_IOERR); } else { - pr_err("multipath: %s: redirecting sector %llu to another IO path\n", - bio_devname(bio, b), + pr_err("multipath: %pg: redirecting sector %llu to another IO path\n", + bio->bi_bdev, (unsigned long long)bio->bi_iter.bi_sector); *bio = *(mp_bh->master_bio); bio->bi_iter.bi_sector += -- 2.30.2