Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2225814pxm; Fri, 4 Mar 2022 11:48:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNZAdwVlHI9rWdJPgJg3vRCTI9wTMLgh3LtbM7Cs3opAx25YcLDgzoaA585MmonZIPqhl4 X-Received: by 2002:a05:6a00:1687:b0:4e1:45d:3ded with SMTP id k7-20020a056a00168700b004e1045d3dedmr337511pfc.0.1646423294112; Fri, 04 Mar 2022 11:48:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646423294; cv=none; d=google.com; s=arc-20160816; b=WejyXt4EezNzgTFgzxbumuZKgKQaQ0Awq6BdVk5z15xW1QpN+rqtWqh6yCoA4W4Twl 90iulv0Ov+J4I79gmzOkscrSOLqAu8ub7Tn6u1YPqViy/enIBxkMbQwpL8H+tjmDi57k nnKgQFQHDbSt/iXamivmLX5VlGIGc5UvhskpxS4y5A4a1EZJ0jYNS2mBa8TrMZvW4T5m T8I1wQphE8mWlQeLdFN+Cz08cLeO/vvBAyIhXjqq/RGF9Q1UmD1qT+GEcw7xvUh7J/t+ XBa2j4bOFttgHuiMp5fZI/1ZmN40d0keUDfbuc/wlqw2IbYDjc1lgMI/eRMi0zoEqWbj P/Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BaIHIZlLazxRYvfXMbsewKFh2wR3b0EOd5xjfmUnWbk=; b=ZydteqhSCF36GK9mgP0xghY+WyMWufL7TE+33gIoNLhfOCDlX5ET/JD3UNHedrc04B l6ZAyBZ4U4CASMfr/x3wT96R5f0Z52R8hXL5Dv1crcxVcPPcsCgJRLDL7hBQ1RTwr79q gp/F9RBSKkovDK8mg9Kbhu4liKVF8CYXpD4nXXpySTBj0UiSyvHrWoLNlRvCwbN53EfT 4sXQFX8ilMpVaur8R+ybamC0bZP80WL/BANesKTt2LsklZJGIF5KFLys87gxExa8m3sS TZ0fMFOaQtimsI0MuUdHqKzv1wQXxM+BxMMBXIgtCeROwTjltsvwtfzbNgaYHAWusWqe J/Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Vg9argHF; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id bg10-20020a056a02010a00b00368dffe8d4fsi5561236pgb.752.2022.03.04.11.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 11:48:14 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Vg9argHF; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 84C43E6860; Fri, 4 Mar 2022 11:19:09 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241462AbiCDSC2 (ORCPT + 99 others); Fri, 4 Mar 2022 13:02:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241475AbiCDSCY (ORCPT ); Fri, 4 Mar 2022 13:02:24 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA9841CFA12; Fri, 4 Mar 2022 10:01:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=BaIHIZlLazxRYvfXMbsewKFh2wR3b0EOd5xjfmUnWbk=; b=Vg9argHFmqvLJAjvcusF4BWl6D sCOKpJ5ArqMM94ijLAYBUPCe9oW+EWq4QJCkqQbHA1fyCW8dCg2YHTpUaaQ+tn4uf7qoe+2cVM0uT ZKG2vfrkQ9sPTof1RZVgw5hNRV/QZw0KRtCm8qIZp85DEPQnnjFk2axIPoSgInwJh2i+Aa8410OnJ m6EWlnKZ6OIqSthmRJ0EoE7pyVBBRITaMlDz0k2FY86oXKSAE3FA6lEE+8tZlJJlOK03xbilRwZ0O IXmhwk4BXur05kEi9MP9MUfL2Gd06zpusFnp2Yl2uVXurxLj5lsYsiA2Xl+p4cQZrj6Qk1+uSETfS +tSdF14A==; Received: from [2001:4bb8:180:5296:cded:8d4b:ace6:f3c] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQCF7-00BUwa-6Z; Fri, 04 Mar 2022 18:01:29 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Song Liu , "Theodore Ts'o" , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org Subject: [PATCH 08/10] raid5-ppl: stop using bio_devname Date: Fri, 4 Mar 2022 19:01:03 +0100 Message-Id: <20220304180105.409765-9-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220304180105.409765-1-hch@lst.de> References: <20220304180105.409765-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Use the %pg format specifier to save on stack consuption and code size. Signed-off-by: Christoph Hellwig --- drivers/md/raid5-ppl.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c index 93d9364a930e3..845db0ba7c17f 100644 --- a/drivers/md/raid5-ppl.c +++ b/drivers/md/raid5-ppl.c @@ -416,12 +416,10 @@ static void ppl_log_endio(struct bio *bio) static void ppl_submit_iounit_bio(struct ppl_io_unit *io, struct bio *bio) { - char b[BDEVNAME_SIZE]; - - pr_debug("%s: seq: %llu size: %u sector: %llu dev: %s\n", + pr_debug("%s: seq: %llu size: %u sector: %llu dev: %pg\n", __func__, io->seq, bio->bi_iter.bi_size, (unsigned long long)bio->bi_iter.bi_sector, - bio_devname(bio, b)); + bio->bi_bdev); submit_bio(bio); } @@ -589,9 +587,8 @@ static void ppl_flush_endio(struct bio *bio) struct ppl_log *log = io->log; struct ppl_conf *ppl_conf = log->ppl_conf; struct r5conf *conf = ppl_conf->mddev->private; - char b[BDEVNAME_SIZE]; - pr_debug("%s: dev: %s\n", __func__, bio_devname(bio, b)); + pr_debug("%s: dev: %pg\n", __func__, bio->bi_bdev); if (bio->bi_status) { struct md_rdev *rdev; @@ -634,7 +631,6 @@ static void ppl_do_flush(struct ppl_io_unit *io) if (bdev) { struct bio *bio; - char b[BDEVNAME_SIZE]; bio = bio_alloc_bioset(bdev, 0, GFP_NOIO, REQ_OP_WRITE | REQ_PREFLUSH, @@ -642,8 +638,7 @@ static void ppl_do_flush(struct ppl_io_unit *io) bio->bi_private = io; bio->bi_end_io = ppl_flush_endio; - pr_debug("%s: dev: %s\n", __func__, - bio_devname(bio, b)); + pr_debug("%s: dev: %ps\n", __func__, bio->bi_bdev); submit_bio(bio); flushed_disks++; -- 2.30.2