Received-SPF: softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220304180105.409765-1-hch@lst.de> <20220304180105.409765-8-hch@lst.de>
In-Reply-To: <20220304180105.409765-8-hch@lst.de>
From:   Song Liu <song@kernel.org>
Date:   Fri, 4 Mar 2022 11:14:41 -0800
Message-ID: <CAPhsuW6vmKx6tgsnM9gifW2Szi2cQX4kY77_BRfNwfq9RXniuQ@mail.gmail.com>
Subject: Re: [PATCH 07/10] raid1: stop using bio_devname
To:     Christoph Hellwig <hch@lst.de>
Cc:     Jens Axboe <axboe@kernel.dk>, "Theodore Ts'o" <tytso@mit.edu>,
        linux-block@vger.kernel.org, dm-devel@redhat.com,
        linux-raid <linux-raid@vger.kernel.org>,
        linux-ext4@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Mar 4, 2022 at 10:01 AM Christoph Hellwig <hch@lst.de> wrote:
>
> Use the %pg format specifier to save on stack consuption and code size.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Song Liu <song@kernel.org>

> ---
>  drivers/md/raid1.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index c180c188da574..97574575ad0b4 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -2069,15 +2069,14 @@ static int fix_sync_read_error(struct r1bio *r1_bio)
>                 } while (!success && d != r1_bio->read_disk);
>
>                 if (!success) {
> -                       char b[BDEVNAME_SIZE];
>                         int abort = 0;
>                         /* Cannot read from anywhere, this block is lost.
>                          * Record a bad block on each device.  If that doesn't
>                          * work just disable and interrupt the recovery.
>                          * Don't fail devices as that won't really help.
>                          */
> -                       pr_crit_ratelimited("md/raid1:%s: %s: unrecoverable I/O read error for block %llu\n",
> -                                           mdname(mddev), bio_devname(bio, b),
> +                       pr_crit_ratelimited("md/raid1:%s: %pg: unrecoverable I/O read error for block %llu\n",
> +                                           mdname(mddev), bio->bi_bdev,
>                                             (unsigned long long)r1_bio->sector);
>                         for (d = 0; d < conf->raid_disks * 2; d++) {
>                                 rdev = conf->mirrors[d].rdev;
> --
> 2.30.2
>