Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Mar 2022 15:46:28 +0530
From:   Ojaswin Mujoo <ojaswin@linux.ibm.com>
To:     fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Cc:     riteshh@linux.ibm.com
Subject: Re: [PATCH v2 0/2] tests/ext4: Ensure resizes with sparse_super2 are
 handled correctly
Message-ID: <Yics/N8zx8PgVhhr@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
References: <cover.1645549521.git.ojaswin@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1645549521.git.ojaswin@linux.ibm.com>
MIME-Version: 1.0
Precedence: bulk

Greetings,

Just a gentle reminder to kindly let me know if any changes are 
needed in this patchset.

Thank you,
Ojaswin

On Tue, Feb 22, 2022 at 11:20:51PM +0530, Ojaswin Mujoo wrote:
> As detailed in the patch [1], kernel currently does not support resizes
> with sparse_super2 enabled.  Before the above patch, if we used the
> EXT4_IOC_RESIZE_FS ioctl directly, wiht sparse_super2 enabled, the
> kernel used to still try the resize and ultimatley leave the fs in an
> inconsistent state. This also led to corruption and kernel BUGs.
> 
> This patchset adds a test for ext4 to ensure that the kernel handles
> resizes with sparse_super2 correctly, and returns -EOPNOTSUPP. 
> 
> Summary:
> 
>   Patch 1: Fix the src/ext4_resize.c script to return accurate error
>            codes.
>   Patch 2: Add the ext4 test for checking resize functionality
> 
> Changes since v1 [2]
> 
>   *  In patch 2, don't iterate if the expected errno is returned
>   *  Code cleanup and additional comments for clarity (also see extra
>      note in patch 2)
>   *  No changes in patch 1
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b1489186cc8391e0c1e342f9fbc3eedf6b944c61
> [2] https://lore.kernel.org/fstests/cover.1644217569.git.ojaswin@linux.ibm.com/ 
> 
> Ojaswin Mujoo (2):
>   src/ext4_resize.c: Refactor code and ensure accurate errno is returned
>   ext4: Test to ensure resize with sparse_super2 is handled correctly
> 
>  src/ext4_resize.c  |  46 +++++++++++++------
>  tests/ext4/056     | 108 +++++++++++++++++++++++++++++++++++++++++++++
>  tests/ext4/056.out |   2 +
>  3 files changed, 142 insertions(+), 14 deletions(-)
>  create mode 100755 tests/ext4/056
>  create mode 100644 tests/ext4/056.out
> 
> -- 
> 2.27.0
>