Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: Re: [PATCH v2 1/5] ext4: convert i_fc_lock to spinlock
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     "harshadshirwadkar@gmail.com" <harshadshirwadkar@gmail.com>
CC:     "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
        "riteshh@linux.ibm.com" <riteshh@linux.ibm.com>,
        "jack@suse.cz" <jack@suse.cz>, "tytso@mit.edu" <tytso@mit.edu>,
        Daejun Park <daejun7.park@samsung.com>
Message-ID: <20220315071028epcms2p2c9d25549f30cbccdcc208f311651977b@epcms2p2>
Date:   Tue, 15 Mar 2022 16:10:28 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20220315071028epcms2p2c9d25549f30cbccdcc208f311651977b@epcms2p2>
Precedence: bulk

Hi Harshad Shirwadkar,

...
>@@ -427,11 +427,11 @@ static int __track_dentry_update(struct inode *inode, void *arg, bool update)
> 	struct dentry *dentry = dentry_update->dentry;
> 	struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
> 
>-	mutex_unlock(&ei->i_fc_lock);
>+	spin_unlock(&ei->i_fc_lock);
> 	node = kmem_cache_alloc(ext4_fc_dentry_cachep, GFP_NOFS);
Is it sleep-safe with spinlock?

> 	if (!node) {
> 		ext4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_NOMEM, NULL);
>-		mutex_lock(&ei->i_fc_lock);
>+		spin_lock(&ei->i_fc_lock);
> 		return -ENOMEM;
> 	}
> 

Thanks,
Daejun