Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Mar 2022 10:25:43 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     Alistair Popple <apopple@nvidia.com>,
        Felix Kuehling <felix.kuehling@amd.com>,
        Alex Sierra <alex.sierra@amd.com>, linux-mm@kvack.org,
        rcampbell@nvidia.com, linux-ext4@vger.kernel.org,
        linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com,
        willy@infradead.org, akpm@linux-foundation.org
Subject: Re: [PATCH v1 1/3] mm: split vm_normal_pages for LRU and non-LRU
 handling
Message-ID: <20220317132543.GW11336@nvidia.com>
References: <20220310172633.9151-1-alex.sierra@amd.com>
 <20220310172633.9151-2-alex.sierra@amd.com>
 <07401a0a-6878-6af2-f663-9f0c3c1d88e5@redhat.com>
 <1747447c-202d-9195-9d44-57f299be48c4@amd.com>
 <87lex98dtg.fsf@nvdebian.thelocal>
 <ab26f7a0-728e-9627-796b-e8e850402aae@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ab26f7a0-728e-9627-796b-e8e850402aae@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J6C8pjwvlzu66CRyYH4zIwtwRe/07xVd9RIPYw0+hpOLXlxCNb+dAg+ZZpF1?=
 =?us-ascii?Q?pG8x4uFfUwPdAWiUnlC6Hos08lqW5d62Qv0oT5iEFG5lt+rHLLCpkY7A5hx9?=
 =?us-ascii?Q?WFarAi2/3He4Jg6g2BCixkgMdTVnpfwKSIACkeukOKJGs/ATU/uoevs72LIp?=
 =?us-ascii?Q?2iCZAQtTcSN4QJ0zz9xOWrE2AxZeUFx4yQ/eGHHfae9WnQ99U4PKSodCyPl2?=
 =?us-ascii?Q?YHeGUMlGV5Nvlq5SevX0FpbKiTMoZAFpdGucbs9AtqAf52F1pdYLMDVcC0k/?=
 =?us-ascii?Q?XavpJ7qsIWqrYX9LM3heocf1mg48XyvVWq9bcCeRyTnz+fib9/i7qd+JKc2P?=
 =?us-ascii?Q?gKfztUXfN1tqUryfKKwh7RJ9XlQM1CE9dgGqH/ymHoFUjO880hYbA8tLjYUJ?=
 =?us-ascii?Q?ibAhc2Mgfx/WeKCx2rhLnrV9EEkR2JfrNDvlu5rlldTDmaDOMV9PK2CXYk8M?=
 =?us-ascii?Q?RUS9Me0FzikNKSUfGclpz/4SdzNsuBEH4k/HvEeX2oWqFAdNaU53Yb2Zq1H5?=
 =?us-ascii?Q?f6mebYnN/mT8Rll8QHk9ha0xyrBlp58e4QTDaLi+z30kAlsMwwxlRXM7ym2R?=
 =?us-ascii?Q?GcYAwdBB0YsFf5GV1pvLc8k93zS97ipJlwmq3O2aFyHx5Y42aqaGyJqmGSxH?=
 =?us-ascii?Q?6dht6QXlGJgN68223EIRxBv4xz8F/hNyn/+gD3hHtZDvoCzSyGEYk8RO9yJN?=
 =?us-ascii?Q?UYFle6vPXc8t/UzZtwhoV+pCH42VYHWomaYIW7XOwOBkeVuqMjvNEs+Nxa1i?=
 =?us-ascii?Q?WqI4gXvaTmpHxTkuS19HVjdzWbhCFOyDmdwnPe4BmM/900klhSD1HiW4DLFj?=
 =?us-ascii?Q?olgZPAIXI5giO63oJQRZScnsa+/5oDGXF1wKRmfoju02CGTSqVvT+LlOA1kf?=
 =?us-ascii?Q?+JZ1ZOT7Hhf9bzdyS1oeMq2XiFCfWPyVbtwRAUd/KJg3vlena4s8hmv9X9cC?=
 =?us-ascii?Q?n9SBERaixAxmOiRVJszYFFZvdPF9fhsV7NImpSpdbj5kkM86sVh8Yyt+IJyV?=
 =?us-ascii?Q?Xy8TSImliVSRsVFjYtoAjaH/5F0TlM/oDI51anb7JnqmBYs52Rx1Wd5GSPdR?=
 =?us-ascii?Q?3O7yzbXgtnPkh/KUBnAjjdxrfYxLXwoxcc3XK17TBbiRcQZmGOf/Ii6neLkv?=
 =?us-ascii?Q?95XqpsT+m+RMh7ITGMRsuVqr8udW1mitvzX5AfNhVOWPA/Y3zCJi9IBX5Pg8?=
 =?us-ascii?Q?sjVz7mYdQ8dv8upB93topqyernO/uUEFGb5ky4t++qgEk/YAc2bS80SCdATs?=
 =?us-ascii?Q?5KBkE/MMIDc2J5G8X8VDIm4AfZS8dnEAPOiyAVOUH2+eHZqrTon8IqN/1gdi?=
 =?us-ascii?Q?oAUJU7hb0/UguReKTYxXcC8q6hULsTnsgLDxycF8YSZWvNS24co+7b00qYzM?=
 =?us-ascii?Q?6t2L6KAEe5T4Fe0NW6TyUsKvYYhNADGi4JF9cch5Ev1RMcR4QEqnRVnaVbMR?=
 =?us-ascii?Q?WxmQ+qVDQKJhcckhFtsAmoCxkSWzdgwg?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ab39593-c216-40ba-8e25-08da0819a41c
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2022 13:25:44.8604
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hni5aDahCsZ/0yMzVaTKlXbKvgsD3Ei6AZ42yBUoWl8J30aqzjEoaTCafl8vZHMy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5320
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Thu, Mar 17, 2022 at 09:13:50AM +0100, David Hildenbrand wrote:
> On 17.03.22 03:54, Alistair Popple wrote:
> > Felix Kuehling <felix.kuehling@amd.com> writes:
> > 
> >> On 2022-03-11 04:16, David Hildenbrand wrote:
> >>> On 10.03.22 18:26, Alex Sierra wrote:
> >>>> DEVICE_COHERENT pages introduce a subtle distinction in the way
> >>>> "normal" pages can be used by various callers throughout the kernel.
> >>>> They behave like normal pages for purposes of mapping in CPU page
> >>>> tables, and for COW. But they do not support LRU lists, NUMA
> >>>> migration or THP. Therefore we split vm_normal_page into two
> >>>> functions vm_normal_any_page and vm_normal_lru_page. The latter will
> >>>> only return pages that can be put on an LRU list and that support
> >>>> NUMA migration, KSM and THP.
> >>>>
> >>>> We also introduced a FOLL_LRU flag that adds the same behaviour to
> >>>> follow_page and related APIs, to allow callers to specify that they
> >>>> expect to put pages on an LRU list.
> >>>>
> >>> I still don't see the need for s/vm_normal_page/vm_normal_any_page/. And
> >>> as this patch is dominated by that change, I'd suggest (again) to just
> >>> drop it as I don't see any value of that renaming. No specifier implies any.
> >>
> >> OK. If nobody objects, we can adopts that naming convention.
> > 
> > I'd prefer we avoid the churn too, but I don't think we should make
> > vm_normal_page() the equivalent of vm_normal_any_page(). It would mean
> > vm_normal_page() would return non-LRU device coherent pages, but to me at least
> > device coherent pages seem special and not what I'd expect from a function with
> > "normal" in the name.
> > 
> > So I think it would be better to s/vm_normal_lru_page/vm_normal_page/ and keep
> > vm_normal_any_page() (or perhaps call it vm_any_page?). This is basically what
> > the previous incarnation of this feature did:
> > 
> > struct page *_vm_normal_page(struct vm_area_struct *vma, unsigned long addr,
> >                             pte_t pte, bool with_public_device);
> > #define vm_normal_page(vma, addr, pte) _vm_normal_page(vma, addr, pte, false)
> > 
> > Except we should add:
> > 
> > #define vm_normal_any_page(vma, addr, pte) _vm_normal_page(vma, addr, pte, true)
> > 
> 
> "normal" simply tells us that this is not a special mapping -- IOW, we
> want the VM to take a look at the memmap and not treat it like a PFN
> map. What we're changing is that we're now also returning non-lru pages.
> Fair enough, that's why we introduce vm_normal_lru_page() as a
> replacement where we really can only deal with lru pages.
> 
> vm_normal_page vs vm_normal_lru_page is good enough. "lru" further
> limits what we get via vm_normal_page, that's even how it's implemented.

This naming makes sense to me.

Jason