Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Yang Shi <shy828301@gmail.com>
CC:     Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        "linmiaohe@huawei.com" <linmiaohe@huawei.com>,
        Rik van Riel <riel@surriel.com>,
        Matthew Wilcox <willy@infradead.org>, Zi Yan <ziy@nvidia.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "tytso@mit.edu" <tytso@mit.edu>,
        "adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
        "darrick.wong@oracle.com" <darrick.wong@oracle.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
        "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
        "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [v2 PATCH 0/8] Make khugepaged collapse readonly FS THP more
 consistent
Thread-Topic: [v2 PATCH 0/8] Make khugepaged collapse readonly FS THP more
 consistent
Thread-Index: AQHYOlmGNQgmUdDgp0OWw19sweVp7azEVTeA
Date:   Fri, 18 Mar 2022 01:10:30 +0000
Message-ID: <96F2D93B-2043-44C3-8062-C639372A0212@fb.com>
References: <20220317234827.447799-1-shy828301@gmail.com>
In-Reply-To: <20220317234827.447799-1-shy828301@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e8OlCamG/tvr99z3XEkudLjbGyGANpLkxsuc1e0zSFmpXBr/Py1o919madEl?=
 =?us-ascii?Q?XPkJAF3NEvqA8DuBKP58usOF8xQZfVkTnnESH8+z37BNDGl/bWIi7EMQ600b?=
 =?us-ascii?Q?I9173IbWRTYCo0XELRnXAjFhqb/hV1cjYXZ3GrSEu0pZIhdZLY5yD5HhuVei?=
 =?us-ascii?Q?jIyNiXdmKCSZXOozXgbygxEd2K4wvZ/+necCKJAxmIws21wc+9eaq5pHEHWd?=
 =?us-ascii?Q?tkMQCdXBeoDgZ+FSck2CBvklek7XglZEJ4GwLwwbocQ1BQU1pSLrmYVOez3A?=
 =?us-ascii?Q?sWySY13FOTeNqslQgY+XFGmJukc0NPdtAu3zgF57Dh+RqR5mAegmqZwZfEiW?=
 =?us-ascii?Q?Sgh8sV1SoRN4sxhp7RdrbBD5e5qIebrAeNuoQObLnLBlh0pMoENawnawonWV?=
 =?us-ascii?Q?tQz4dJp3mdZToAMqWAB8iryhEmZX3ZrEHPGZCkyip+sDP0OKocXMRsX4cuUI?=
 =?us-ascii?Q?BwTiRlNMFl0xGevtc12/yW3yp+U+NSH4SzbkeLhHwDgztcpvRDudixBIus/K?=
 =?us-ascii?Q?VF7haq2hXl0YYtdBAl5S6GYGwrlrVgw97GnrH9QDdiNKH4bbiZr/BW8Z6w4L?=
 =?us-ascii?Q?9cIM5JkLxeT5/UycFyfgEBd8flX1homB32NsaTeZ4b3GRZvX33VicZk+fbJM?=
 =?us-ascii?Q?qynJm7MgVg5SQTFyZI4zF1mIgSQf1oW46MKRIczHpZDm4AhOaskOoZllEuS7?=
 =?us-ascii?Q?NJoAQlikFl/NA0ciDpjLXTG6BBXyfkteiM5rYnxpd/NkDXTZZ817xSAKpJfe?=
 =?us-ascii?Q?FD/MKXNNxzkD9IFcA4C29JYhaUKLKaIlw0XBWE1uw/hqH9hT3xv1ZzyMhee1?=
 =?us-ascii?Q?LjGDgp7hxbCD08ZSKIh3LyPBtniYYdjKxxTK2aRXjTwLnab8elUDSsZkXM1V?=
 =?us-ascii?Q?I0kgh/AVx+3WE3yPpUB1hveeJMNc5B41DJ9Qkeb/pTv5sszcOsq7xx5jOvsv?=
 =?us-ascii?Q?8dmR4p+C8KbJMhIi4nxg5g+GWw+tyxaIi+HmW1N7q2K539ZiPyo0HeWnS01O?=
 =?us-ascii?Q?42lrEkY+6fm7K+0yyTA3JFRCcm3xzXm1lObbhIaJiRTu3teT8cqqLP6GBmmb?=
 =?us-ascii?Q?Cgm3sgFacEtuBZkAevpcnRXZOjAFIks9ItwKJ5SqJY8qMeQEQrW411sSKM5f?=
 =?us-ascii?Q?KP44vOVdLjOY5JvLVOM5IjB28/HEX+M3urvHOawfxO0FaDX+hY/SJKVabkJd?=
 =?us-ascii?Q?bzW27ogKKQfH8IrDjPgRFLaBSPgkbHc9Nc9bu91wfJH8HV7Yf5+siv93B2dZ?=
 =?us-ascii?Q?FQ6TtjNcrLiRvpxitNRojo36IPV5Eo3yYRD2nw2N3aF9Qx8o87qzOd+lWjuY?=
 =?us-ascii?Q?ioxRGNylnY+9/iKiMt0QtvN8vy0lDx6Hcr5mNMp9UneWNQkMVya/SKGH9Gkt?=
 =?us-ascii?Q?0FCJxXQdrbCSHLlDA6rEgvDnZCGHXB8BSS3NrNSFRH/6nyxWYagSAC35IU8V?=
 =?us-ascii?Q?0k150uKVb/51Td4MgtAu5hBdl9b2kCPkTeJ2KJyeX8t+aVAdDUMzcFLXt1ay?=
 =?us-ascii?Q?toh6MrFFF73jmMA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0636B14C8F0EE044AFAE647D0AC3B5A7@namprd15.prod.outlook.com>
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7942aaf5-f7da-4ac6-3b54-08da087c1850
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2022 01:10:30.2599
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0xBtxny9QBCChVByJzJJbWwNGuynrrlIX0x7+SKUcmSMHZhgDtasrrtSWRGzh1Mh3cAoqcGQfQ8AclwU++4Mkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR15MB2321
X-Proofpoint-ORIG-GUID: zDZMzu2GFpY1dElYZiNG1owQmrbOmJhP
X-Proofpoint-GUID: zDZMzu2GFpY1dElYZiNG1owQmrbOmJhP
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-03-17_07,2022-03-15_01,2022-02-23_01
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org


> On Mar 17, 2022, at 4:48 PM, Yang Shi <shy828301@gmail.com> wrote:
> 
> 
> Changelog
> v2: * Collected reviewed-by tags from Miaohe Lin.
>    * Fixed build error for patch 4/8.
> 
> The readonly FS THP relies on khugepaged to collapse THP for suitable
> vmas.  But it is kind of "random luck" for khugepaged to see the
> readonly FS vmas (see report: https://lore.kernel.org/linux-mm/00f195d4-d039-3cf2-d3a1-a2c88de397a0@suse.cz/) since currently the vmas are registered to khugepaged when:
>  - Anon huge pmd page fault
>  - VMA merge
>  - MADV_HUGEPAGE
>  - Shmem mmap
> 
> If the above conditions are not met, even though khugepaged is enabled
> it won't see readonly FS vmas at all.  MADV_HUGEPAGE could be specified
> explicitly to tell khugepaged to collapse this area, but when khugepaged
> mode is "always" it should scan suitable vmas as long as VM_NOHUGEPAGE
> is not set.
> 
> So make sure readonly FS vmas are registered to khugepaged to make the
> behavior more consistent.
> 
> Registering the vmas in mmap path seems more preferred from performance
> point of view since page fault path is definitely hot path.
> 
> 
> The patch 1 ~ 7 are minor bug fixes, clean up and preparation patches.
> The patch 8 converts ext4 and xfs.  We may need convert more filesystems,
> but I'd like to hear some comments before doing that.
> 
> 
> Tested with khugepaged test in selftests and the testcase provided by
> Vlastimil Babka in https://lore.kernel.org/lkml/df3b5d1c-a36b-2c73-3e27-99e74983de3a@suse.cz/
> by commenting out MADV_HUGEPAGE call.

LGTM. For the series:

Acked-by: Song Liu <song@kernel.org>

> 
> 
> b/fs/ext4/file.c                 |    4 +++
> b/fs/xfs/xfs_file.c              |    4 +++
> b/include/linux/huge_mm.h        |    9 +++++++
> b/include/linux/khugepaged.h     |   69 +++++++++++++++++++++----------------------------------------
> b/include/linux/sched/coredump.h |    3 +-
> b/kernel/fork.c                  |    4 ---
> b/mm/huge_memory.c               |   15 +++----------
> b/mm/khugepaged.c                |   71 ++++++++++++++++++++++++++++++++++++++++++++-------------------
> b/mm/shmem.c                     |   14 +++---------
> 9 files changed, 102 insertions(+), 91 deletions(-)
>