Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2219254pxb; Fri, 25 Mar 2022 13:16:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2eT7OSZ/Hs+tN+epWRuxzmY0YDLT+z4C9/4jzPwo/l6eVfs+bfPPdnySbjrhl0pX39Nj7 X-Received: by 2002:a63:5d4d:0:b0:381:c98b:ce72 with SMTP id o13-20020a635d4d000000b00381c98bce72mr966481pgm.466.1648239401056; Fri, 25 Mar 2022 13:16:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648239401; cv=none; d=google.com; s=arc-20160816; b=DiPO28EblZ6TQAD1r4IVHqa57i6BR8qg2PpZbHnsTx/KOJRot0V0S9iKbN+4tlAbEK l0UeHD8Gxx8zyH0BYFkqRraJVLEWNakwOzgaZitHHy3zZcQ1UCwWGPkeZTF0YBxYknDe A9tkE96YFoZkAMnmX3dxy6dYylB1E8T24DiQsTJYdLvNsGKytpfcs/pmsKUuK5qCKrpw X+8QYlPtvznD8V8fP7ZSwEu+Zzk6vQmznRUEPHIHwSoTWmDYbKAYyd0An3f3z52lD3ww H/xdf2pha9Hs793GqEceTo8GRHHcagWDKcqZs1o2l5ZKPggdA7OZO76bPpIhbDYzJZUl 25sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=41tBvIoVVxpnOM6k6ygITeBpz0TyI69sU4HGwbt0OTk=; b=I+YLGOfNetSczo3M24+8usXS3e7qnuwfeEeWQ7EiNLaQbrNXy98NXIVOoxSRD4g0+P P7ys16KQuZThGGmplK10tORoiD3nCLpOj9hMr8d+lsxMjW88mxZu/OprcbiQXyqPwzn0 UbyAUKneUztjJn1Lvn1cirIhO7ciw6zWwSMQ5tEdJ+/IzSCmaKENFVWdinjQqICbzfsN NibuR9DTMmnE1AXBY0JX7iI4CnlDC/9vqMKo11M7p3MWCMBynGN539vmPoSpJ4aWnvQz n/yfKB3gcsvBeoo3SxV8lD4q2rn1sr+Roifb1KAHZqFT3ZDORvsQde2RdqRKWjGlEQ1t jHdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id ep13-20020a17090ae64d00b001c66f2284b7si3259949pjb.49.2022.03.25.13.16.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 13:16:40 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1A401FE41F; Fri, 25 Mar 2022 12:24:45 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229572AbiCYT0R (ORCPT + 99 others); Fri, 25 Mar 2022 15:26:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbiCYT0O (ORCPT ); Fri, 25 Mar 2022 15:26:14 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF22C1DB3C2 for ; Fri, 25 Mar 2022 11:58:24 -0700 (PDT) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 22PInqbB024473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Mar 2022 14:49:53 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id AF40815C0038; Fri, 25 Mar 2022 14:49:52 -0400 (EDT) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Artem Blagodarenko Cc: "Theodore Ts'o" , adilger.kernel@dilger.ca, Andrew Perepechko Subject: Re: [PATCH v2] ext4: truncate during setxattr leads to kernel panic Date: Fri, 25 Mar 2022 14:49:50 -0400 Message-Id: <164823418309.637667.12757298463000030100.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220312231830.103920-1-artem.blagodarenko@gmail.com> References: <20220312231830.103920-1-artem.blagodarenko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, 12 Mar 2022 18:18:30 -0500, Artem Blagodarenko wrote: > From: Andrew Perepechko > > When changing a large xattr value to a different large xattr value, > the old xattr inode is freed. Truncate during the final iput causes > current transaction restart. Eventually, parent inode bh is marked > dirty and kernel panic happens when jbd2 figures out that this bh > belongs to the committed transaction. > > [...] Applied, thanks! [1/1] ext4: truncate during setxattr leads to kernel panic commit: c7cded845fc192cc35a1ca37c0cd957ee35abdf8 Best regards, -- Theodore Ts'o