Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 4 Apr 2022 14:38:58 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Felix Kuehling <felix.kuehling@amd.com>
Cc:     Christoph Hellwig <hch@lst.de>, Alex Sierra <alex.sierra@amd.com>,
        david@redhat.com, linux-mm@kvack.org, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org,
        akpm@linux-foundation.org
Subject: Re: [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages
 only
Message-ID: <20220404173858.GQ2120790@nvidia.com>
References: <20220330212537.12186-1-alex.sierra@amd.com>
 <20220330212537.12186-2-alex.sierra@amd.com>
 <20220331085341.GA22102@lst.de>
 <82ed845d-2534-490c-f9b9-a875e0283cc9@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <82ed845d-2534-490c-f9b9-a875e0283cc9@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hnr1vzfh1ED8SBc/kdvoO4l+IVlu3YpXhBlGAKbUNJS3MR1yV8f6TVFRiELr?=
 =?us-ascii?Q?mL4z7nrFz8BAkf9utQ+zD/wCX+qxM9HiuFdrmS+3EJZkADG9ulgUwVyu3/f5?=
 =?us-ascii?Q?A5dBX61LeR2m6Gi4RKMCDc574RShFlhmmotQzkjq8pdpb/OHQtJ2fo51hGC3?=
 =?us-ascii?Q?a1l8Qi1syZt4Ktd7MgNKJCHe4LVLkUk9OPn+ZcRwHIeNze/8xIVTnewZkD1U?=
 =?us-ascii?Q?kCyVtJBbJdsxRAe9b4RpBPoqDYNkfj37mpaBhaKbe4MGPQoGJo3GuaDOTFD2?=
 =?us-ascii?Q?yzfjwRcQ/qQvWIUSqqRzZY/K0CYDAlOSouE/rIL/b+yh3lRCiN0srQ0dVe/Y?=
 =?us-ascii?Q?qyRjw+owoesBymD92AOlh2P0QopNQPGss9fmGTmOX+B5toy4cZyiW71q5rbX?=
 =?us-ascii?Q?O5PvZyEXJhjHudaHVZrV55OKaYgVh5pBQTesTeXVUjbyu01Erisg1J60077V?=
 =?us-ascii?Q?/uKuYl8qF/ntUuSxRnSp1ZH9YhPArGoFwvYk93g7V4TWDl2khk7yf5zemmio?=
 =?us-ascii?Q?nqcfIyWZolyVDhImvlODBjwcEarkboHdkNPJq+S1JImUXyZBQ9HpZz31pYFv?=
 =?us-ascii?Q?qvZBZGF+2XIS5BbnClovFifsBxtdZQLa6roiYrUe7VPpnMQ+8T16Xs4YHy8p?=
 =?us-ascii?Q?lGVkJWB42zUvGXJsgOKA70cjRXTHX4MldfZwOltQOfGWk6Ba9jMd4LXv4D0P?=
 =?us-ascii?Q?QZdMQsY4/ulmASO6H27/W8R8+3E8G+OjJllYSFc9bJT8fSMqpDqbYz9h10tE?=
 =?us-ascii?Q?032Xq25Wtz6boIghn6XEyFrkcZlk+7RS3WrEBikIN4qe80H8/b4BKecUI/V7?=
 =?us-ascii?Q?EKJIE9iGx9LEuPnibl77ZUfl4k0VsjCX6G/IlHSmGxCx6G15Dzk5RXrmBK0V?=
 =?us-ascii?Q?UeuKs6ZXgINu2OiSB/tSCHcbSUAcW9S2hO1PtSlClcW+rsNpyI7Tdj0nMByB?=
 =?us-ascii?Q?jOrIJRGX7EaB3Jp/4Rkx7D+/WQDtfUknkIn4y68ZMIM208a4lD+fK2B5RC+5?=
 =?us-ascii?Q?+ZCSrIHWODxe26p0qP3E/QcDprFbOHMLN+bz62hD8moAI+TtBCZbvAF8dPUl?=
 =?us-ascii?Q?GYZdpjLDfksstUP3zZN7ajnlsJ8wpxeZ+IT/6oPr782wPoNAxASM5ebcWkDz?=
 =?us-ascii?Q?nxpfQ2RQAf1huM1PhudVcLT+Mgir+GQdBsLhsoa6PPWroF2mGcWAbXupM1AQ?=
 =?us-ascii?Q?n8U2MlZxcd7Te7jMVENK5SR2islAmskBcUi8k+1IbPmzGO5CUEMaLxQ1585f?=
 =?us-ascii?Q?H7mZqduw+9BGMisHuT6/YhMPNgJIjohwp75sEdNZ1y1oFM3mZwdidYPg/LvN?=
 =?us-ascii?Q?1GkhiS1dM6Us5bnPuedDcfYVsY5r9290SgMiOyZgygZ6trI383lPZj8H60LV?=
 =?us-ascii?Q?dgcx5+s+D7tpGjAWXGpv7ndt1BzLrZRp+ePm+CpyH7jOds+6uoJLxnzEc2WE?=
 =?us-ascii?Q?FUSGm496uTr0rmb0k0CiEN97PrWtMlOjl+PWAs72xMmWNrRwcK9MnabRufwJ?=
 =?us-ascii?Q?UU9+xrgZOkXvpWEHWF1nseteVzDTz37Ok8ebNqkCgCeLf7YUm6VRFnfMFiV3?=
 =?us-ascii?Q?DFUZcejOFxs6vjAvYK6qAdD2Vbki8f7+pAWhdGwjNcGOWXnSTDHTnjvWERUU?=
 =?us-ascii?Q?Lsuq+MgZDXNL2RjCpgW4TrPVYfYvb/mBqm4xBBrIOGWdDQ2UyR/O7Od+ZW0V?=
 =?us-ascii?Q?fTfc9bGtc2CApw9fsUcjWpZXWqnxuEHjXaNUonke8vlk6XzHYUUXyuJ/V7+w?=
 =?us-ascii?Q?9FIsxWvuLw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdd41846-42d3-45ed-2777-08da166200a3
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 17:39:00.2127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rhMsb9VNMgcgWYIyQHd8XLg3f4+HH0SAuZ8mU+S2FoRm/8jXCakFGLSO1hPnWYdH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1422
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Fri, Apr 01, 2022 at 04:08:35PM -0400, Felix Kuehling wrote:

> > In general I find the vm_normal_lru_page vs vm_normal_page
> > API highly confusing.  An explicit check for zone device pages
> > in the dozen or so spots that care has a much better documentation
> > value, especially if accompanied by comments where it isn't entirely
> > obvious.
> 
> OK. We can do that. It would solve the function naming problem, and we'd
> have more visibility of device page handling in more places in the kernel,
> which has educational value.

Personally I find the 'is page XYZ' pretty confusing, like I don't
know half of what the PageKsm annotations are for..

Testing against a specific property the code goes on to use right away
seems more descriptive to me.

Jason