Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
Cc:     Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        jfs-discussion@lists.sourceforge.net,
        linux-nvme@lists.infradead.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
        dm-devel@redhat.com, target-devel@vger.kernel.org,
        linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com,
        linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
        xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org,
        linux-um@lists.infradead.org, nbd@other.debian.org,
        linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 24/27] block: add a
 bdev_discard_granularity helper
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq135iph8lc.fsf@ca-mkp.ca.oracle.com>
References: <20220406060516.409838-1-hch@lst.de>
        <20220406060516.409838-25-hch@lst.de>
Date:   Wed, 06 Apr 2022 23:32:28 -0400
In-Reply-To: <20220406060516.409838-25-hch@lst.de> (Christoph Hellwig via
        Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:13 +0200")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8swuNszgtWladoaG2ebwZi/0ZzH6DeyV/bthpZusiDJQYxylmSbA5PRO7qqk?=
 =?us-ascii?Q?7VvYQHpjnVKcs4+A7satuAEMQnvnsFDCBEj3b9Xpgns3QrbvSvSb9sZ5U3NH?=
 =?us-ascii?Q?rLKuDQ+Zh4E1yctPsyKoTxG7Z8Wfd9A+O9dhc1Sf8LZJFWwB4wj1WwlJGVxD?=
 =?us-ascii?Q?lbSr6mSEEfD61JouYuRW6FIuYm5K2H5lync3tmP3xLxXx87mKS0HDKaDyBjo?=
 =?us-ascii?Q?wcuybuiUGt9Wx8qT26WAgBMFrqTcJdsc8PgWhdIu4Oe9xLgHg668qkHKTTRb?=
 =?us-ascii?Q?OcNN7Vp1iDl9y53W22ZMw1YmvjLlSda+Xi5WoupaTqeePxD4kJL8W8YrS9k1?=
 =?us-ascii?Q?5MXqgaFpz+k8zQdJ4k0XmIsJ2XFj9BEEY/W+f/w/QBJnlR+pQFhNsRZBV0gM?=
 =?us-ascii?Q?ArxFxFRQxVkbGi0aIEECqn+FcrzSuvkrDKu+uucg+uO96Z6zf4JOHeksq/98?=
 =?us-ascii?Q?nQl5ZPXqpG5hQlpbHtwNDhxigCd3tIjZkRvQnDxqshd5PwIrLj7xVNuet4mb?=
 =?us-ascii?Q?6pjlKHAOk71nkKVi//P6MvTQ7zIor0zVRqOxe2wIXnvRexAmssGDGM5dMX+U?=
 =?us-ascii?Q?bELptqKzy7PZJiXJ3GopBUHUSPrQnOqMQtiG98a7hxW0pPxHxGqgHf07BxGI?=
 =?us-ascii?Q?nCvZyyu95XACEbquobj7xaTgDa/GCCXswpbQCiN5WY56QrcktkedPaPc0/5p?=
 =?us-ascii?Q?huOfjf6smTgyU5IPoeHOE9zhn6b2jXJJO/CVw3ZrPW6TUWL68mQs+fhmNcUs?=
 =?us-ascii?Q?oPzRBn/D8gFKKFNnuyVbiMkS5FaZat3CKUzVNfWtlc0CzTq7SQbUJAYIKuak?=
 =?us-ascii?Q?Sa2On3EGoEZ/obAmO+/6SceIkNAA3YhQKuC6t/teDMxvwWrZfOEl0qSsnL4W?=
 =?us-ascii?Q?Xo7oA7d8Xx251pvSx4jLRe4uUFpXgpwT8aKmEsPl0YmQ0cXLEreV1OIkB028?=
 =?us-ascii?Q?ug4gAjeAdSw2lQHXB65EXyetLFaentH22o6QXieEgJ+9TtOfxjJsrgRMXT+E?=
 =?us-ascii?Q?0ZwTAuQRbojDATmBh77GnsRIpIbcbl8KL4sav6ScENnXR62MVs1ONADxT7QG?=
 =?us-ascii?Q?Zhtpe8/W5WF+hBlZ0m73lq+nZYQRHCZGi68sdgbC8bKOeY0IK/HQWbnuJRJl?=
 =?us-ascii?Q?JorA06/wHlXj1T/ESfgbaXGaW21mHefygocLmPQ/1tn+DSMiwAvrTjgfD/b5?=
 =?us-ascii?Q?Ttg3SEtVlfHizipMwVmb5G/9GfdS4r0jBJzNj3T6J+6f1KcnTS4lCTvFFXWu?=
 =?us-ascii?Q?Q2NzxQ6ABea2CN0LrYQzB6X1/n1/2195xk/ERh14WJAxy4cG5VeEB/BFLb14?=
 =?us-ascii?Q?V6qTl/T9g4k1KYp81ocVjLwT+kdI1Nkdk8/+DM7FQjXB2ZDnM6UVdWcWycc5?=
 =?us-ascii?Q?4uMburs8Vtf/K0E3huz8tFudnSkyK9MRPYRBLCc+M1a6Jz269Y9bGBdnSMNQ?=
 =?us-ascii?Q?xrDNjO9qEXwo7ptfJJFT/z4roRmVQ1pLKSzST1mqVbwXn0p5EEY+wtU1OgpK?=
 =?us-ascii?Q?FpCVF7PfWCM/JdiFeLIW4nAXOOix/uBy+PLdlzWzffh8XuheQXzJ4v2L6bDt?=
 =?us-ascii?Q?+oJpdFLVj/2VbaiG07pFBN4ZWNdaQV25c1I20QPtfCp1QPQQNvBgr25MqmD7?=
 =?us-ascii?Q?8tDSEMJnEykf7aewPfAJvdpYb1vU5CVTCV6IJGAWQX3Bd+kCvlBuVxZFqwfU?=
 =?us-ascii?Q?gXDlgusFFa6Oj78zk6O3u/uW64TR5IzzEu+lIQMOfrk1BUNGOraCJPRjgsxU?=
 =?us-ascii?Q?755pnrTMt+PRNTb6o2BFHe5QJY6jbZQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 073c7bad-f00d-4d5b-ec41-08da18473efc
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 03:32:30.6416
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hwGzzH7OhkF8PNNh3yM9ri4dh2R9VUt7jXac7Lm4rAo/rmhpAzJ3fZmkBEtZO72lGTEl96s8zj4YXk68qPq0GSp3vjt9qNgWQQclO0sGZLE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1618
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-06_13:2022-04-06,2022-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=926 spamscore=0
 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070017
X-Proofpoint-ORIG-GUID: i5ueGU4Do136tb5GM3VcintEL9nTn7F7
X-Proofpoint-GUID: i5ueGU4Do136tb5GM3VcintEL9nTn7F7
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org


Christoph,

> Abstract away implementation details from file systems by providing a
> block_device based helper to retreive the discard granularity.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering