Received: by 2002:a05:6a10:144:0:0:0:0 with SMTP id 4csp290077pxw; Fri, 8 Apr 2022 07:40:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqnN2YghRasqkhzU3nMntMSU/sWxbzcRsDuK04tuR8TdjS2PQhc8VQEZxByqQF2L+wujOQ X-Received: by 2002:a17:90b:3a87:b0:1c9:9eef:7a9 with SMTP id om7-20020a17090b3a8700b001c99eef07a9mr22300641pjb.103.1649428842083; Fri, 08 Apr 2022 07:40:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649428842; cv=none; d=google.com; s=arc-20160816; b=X607vKQ28Qz2wD9gYZOmRKwf7NSA2qOjDn5XAlsYvxiqjJ6HjH96yS1WeiHdiE/9sZ GjQULCjzWXhFigjy4z9XxmKESfb2fxfc7yG1Xbl6ZQT7b76yC/IN/LuVbKAzZ3387VVc zqekRcnYApo6se5dRyQOP1yIdJRbTi+Z2vfgJs7xc1KWjZQ0E2ugwZeiMrOqetakxobB GZ5wsCyKnk+bohJ9/sEID249vxqk1LSYejJKtd9Zi2KBDzr6SvpAJcxCiJawNp/5xA87 MmGsiQ9Q406GsunxBFuQsJmS711WinBa+T/QIkT97lRLuDUF0xfdSBZS4K3bbp+Iew7X Doiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:mail-followup-to:reply-to:message-id :subject:cc:to:from:date:dkim-signature:dkim-signature; bh=NntcuTEBNLs2a5PoQyJ5XTqfafqQKLdTMOol7WzzX0s=; b=0+n5yEZg1Fokf9GpmXoZw6yJgY+xTweAg8XEfLW5jVtKrsehtIrKJHjZktFwXEy/YR Lt89CLnGU98x4CSjnl1bX3a6W8nDBAH14z5+qIomImJRPUt2uwe6SbS0yFW/UtTdHkaK tnb7JCZB2soqUXjzQbnbCRbLiIdvsNqESoykjzlc3eaNsuMt96DKXwrqTsVvLGH71TaI Xwm2QCpEubrW5dOPosMXvhw5n128ZU0Jq1Lp58r1OVU3jXFdZ4BHdVt10JU2EtlXEYHv V0RvupMc0j1WndHKjaziAEdeDvvInQHet679XGIBDxaJDA6YLjAFxLwEmLqW5IcLVvSb M/rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=IOyS+CY4; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y7-20020a17090abd0700b001ca358df6fcsi1332759pjr.110.2022.04.08.07.40.15; Fri, 08 Apr 2022 07:40:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=IOyS+CY4; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236684AbiDHOEO (ORCPT + 99 others); Fri, 8 Apr 2022 10:04:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236424AbiDHOEN (ORCPT ); Fri, 8 Apr 2022 10:04:13 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95FC334BAE; Fri, 8 Apr 2022 07:02:07 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 33FF9215FD; Fri, 8 Apr 2022 14:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649426526; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NntcuTEBNLs2a5PoQyJ5XTqfafqQKLdTMOol7WzzX0s=; b=IOyS+CY4mKgPgZ8USr3nF2sek6nsoLhx0cr5TMVaaAs4Ag4bKj8Vi2sptagRUXESVfNODS Ln94gENJtPAW0xwa1YTvXkhHuvtN+PZVtUN04bIOD5Gb1FPiPxXvY9276x42sDgCevWU0p F0xk4+Bz9XncCGMfKPV4nKJOLviw8CE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649426526; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NntcuTEBNLs2a5PoQyJ5XTqfafqQKLdTMOol7WzzX0s=; b=YyECzpdo2dp1JJsJWW+9IUjgVDYVcTRsNKLbGqCSM7UYLC06N2gtmpywFUAHkgPWFPstwI YstMAkxeXK3nzLCA== Received: from ds.suse.cz (ds.suse.cz [10.100.12.205]) by relay2.suse.de (Postfix) with ESMTP id C18F6A3B87; Fri, 8 Apr 2022 14:02:05 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 03176DA80E; Fri, 8 Apr 2022 15:58:02 +0200 (CEST) Date: Fri, 8 Apr 2022 15:58:02 +0200 From: David Sterba To: cgel.zte@gmail.com Cc: dsterba@suse.com, tytso@mit.edu, clm@fb.com, josef@toxicpanda.com, sfrench@samba.org, matthew.garrett@nebula.com, jk@ozlabs.org, ardb@kernel.org, adilger.kernel@dilger.ca, rpeterso@redhat.com, agruenba@redhat.com, viro@zeniv.linux.org.uk, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-efi@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org, Lv Ruyi , Zeal Robot Subject: Re: [PATCH v2] fs: remove unnecessary conditional Message-ID: <20220408135802.GQ15609@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, cgel.zte@gmail.com, dsterba@suse.com, tytso@mit.edu, clm@fb.com, josef@toxicpanda.com, sfrench@samba.org, matthew.garrett@nebula.com, jk@ozlabs.org, ardb@kernel.org, adilger.kernel@dilger.ca, rpeterso@redhat.com, agruenba@redhat.com, viro@zeniv.linux.org.uk, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-efi@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org, Lv Ruyi , Zeal Robot References: <20220408021136.2493147-1-lv.ruyi@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408021136.2493147-1-lv.ruyi@zte.com.cn> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Apr 08, 2022 at 02:11:36AM +0000, cgel.zte@gmail.com wrote: > From: Lv Ruyi > > iput() has already handled null and non-null parameter, so it is no > need to use if(). > > This patch remove all unnecessary conditional in fs subsystem. > No functional changes. You'd need to split i by subsystem under fs/, each subdirectory has a differnt maintainer. I can take only the btrfs part.