Received: by 2002:a05:6a10:144:0:0:0:0 with SMTP id 4csp1484549pxw; Sun, 10 Apr 2022 04:05:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvjigW6bRCNYoRRsk97lbVRwUvwW+zUhpGS6ObQJ3tYObGXwAgBwmDlZWXOIwwHwdCfkVx X-Received: by 2002:a62:ce8c:0:b0:505:a23f:606a with SMTP id y134-20020a62ce8c000000b00505a23f606amr5427270pfg.67.1649588717423; Sun, 10 Apr 2022 04:05:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649588717; cv=none; d=google.com; s=arc-20160816; b=h+4/7fBHAQkOFMA1Cwke4PzP1pyP1Q4Pbb12D/NVAWMZWDU8GYU0WxM6WEF5UedQSc OU1JMSRPLPeqxlXTuCLT9GDmpuTRLDEVPD9HBAHF6FSIalab+1dVDbEWzUMIfbw80+rT fxqPTvSe/KojVixNVmw4VeaW3hMN3C4XUBzMx5PmfNFx8vSJ8L+KBQWTVVaMZvRIIaqP 0ca1cOtddpt69XjnNSKeA7rAZzY7CKJJMCXSi9gUwrJonb7FMEPml5titA7FCpbmCdeB xZJQ746oevMudmSUbRMFAeO7b4i7Y2nAguc9XQVZanq0iE8ss3xngTCyZxDJDkug5uI3 nBzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-signature; bh=BmOfl4NqddautzOtQrZ0dLuhiQSp1fB0SDxF8v7gYBA=; b=quNhZhpE07Y+xsCUPqDGoskn2E0EXyyerQYGD2vma2tslbPXAmFNqNeu7tDg2xclyq FritcxOdxIvd8Y2HvKR/HqAkspA/LEzYDN32dVnKGnfc8nh+pDxUPblzBrrnyCEUnsvl JsiA5m29SFKLf/RHYRyv5agoMen4ydRAC4g9PYvdPyImavbJQCD+2UXRzHUoytsfDVo2 Z5HRzqmlwgdHbFXXQFA59KIsHWJEX/EaULLQWAo5lMx8AsUmzN1sXtVp+xtiaTrZst0D Xqtn49TJ1nVLaaCRIq93sPbd8+5L2gAeEO+qGtC9Emqylo4kNwi172wMcgchFkudfcIR rxJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=SJlQufjn; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=yiH+qx8I; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q8-20020a170902dac800b001577e9cfa99si5838887plx.600.2022.04.10.04.04.55; Sun, 10 Apr 2022 04:05:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=SJlQufjn; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=yiH+qx8I; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229982AbiDIOfQ (ORCPT + 99 others); Sat, 9 Apr 2022 10:35:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbiDIOfP (ORCPT ); Sat, 9 Apr 2022 10:35:15 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2512A35879; Sat, 9 Apr 2022 07:33:07 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 207A11F864; Sat, 9 Apr 2022 14:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1649514786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BmOfl4NqddautzOtQrZ0dLuhiQSp1fB0SDxF8v7gYBA=; b=SJlQufjnXjTQtqgkhM6MsOUPDPwOMZ6xGLQ76UNS6RR1cEGIg2CW/GZ7A0Nq9xE2LKzjCQ zm4gbJFRwGS5ZR58/OOlzltxzH57NlfDQ1MS9kgXiNk7elM8N3NSClk0AEwvrheO6NCJzw l51uuNG8cURr+Q1l6/il4XbIWcEO2Fg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1649514786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BmOfl4NqddautzOtQrZ0dLuhiQSp1fB0SDxF8v7gYBA=; b=yiH+qx8I6hbeCP31rtrhbZE5qxMo8OqYiXG+UWOpJ9wghAOQqadl62X34RS7V0fnDyonaX HzX10h1d2uotqQBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F41913AA1; Sat, 9 Apr 2022 14:32:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id m2GpARiZUWLHIgAAMHmgww (envelope-from ); Sat, 09 Apr 2022 14:32:56 +0000 Message-ID: Date: Sat, 9 Apr 2022 22:32:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD Content-Language: en-US To: Christoph Hellwig Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Jens Axboe , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, "Martin K . Petersen" , =?UTF-8?Q?Christoph_B=c3=b6hmwalder?= , Ryusuke Konishi , David Sterba References: <20220409045043.23593-1-hch@lst.de> <20220409045043.23593-27-hch@lst.de> From: Coly Li In-Reply-To: <20220409045043.23593-27-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 4/9/22 12:50 PM, Christoph Hellwig wrote: > Secure erase is a very different operation from discard in that it is > a data integrity operation vs hint. Fully split the limits and helper > infrastructure to make the separation more clear. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen > Acked-by: Christoph Böhmwalder [drbd] > Acked-by: Ryusuke Konishi [nifs2] > Acked-by: Coly Li [drbd] Hi Christoph, My ACK is for bcache, not drbd here. Thanks. Coly Li > Acked-by: David Sterba [btrfs]