Received: by 2002:a05:6a10:87d6:0:0:0:0 with SMTP id g22csp461767pxr; Sun, 10 Apr 2022 21:14:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy78yyu9IYR4mZXU79bbJjscd+Z7Me5k+Db9o+TovmVD5mMRh9zaGghmCWSQfVnJXcoFfbx X-Received: by 2002:a63:5d4d:0:b0:398:fd64:3793 with SMTP id o13-20020a635d4d000000b00398fd643793mr24556890pgm.597.1649650478994; Sun, 10 Apr 2022 21:14:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649650478; cv=none; d=google.com; s=arc-20160816; b=Wdw+sS5bu2L5y66LuCaoiFieUdCNkeHeFPbyWfuyq5shakwQfYX//lC3wo3FE7QdmE fHW79cF1Gv2VOUr4/dThrle8d9rfjEY0fiBiw2uyika4HuQp06jiiVd26Uw+Nt2PxBfH RLgWatWr13u2Rs4GELvgWULbzZ6CXGD274mj4zYURuQ1X69L9W4jxszQ5MaUK5WQVOR8 npeu3OPzu5ehKfTa//gee9Lt95PAtlMiC8JVDFPm80HQOryZlzcKrskOycyEG1ectyt5 L+nELST0CV87eH4N9x2fqwT3035ZcV1CY7u9wCHob73BQbgg2c7X97NaCLy+Oh3Cw18G +7eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ReTqbfPvYOL5e7OV60JqE24oNyN9q4uiegyy86KDY98=; b=JBH2fKFL0DC5VQXkgpzNNDaT+5Sx6Colo4WcDeQwKYmhcPIkexB5Oudd+x4fj1fKPT v0HcPjxWLeyPASuNuz5nXQog+Pn5RjG7HJbcssF91+vM73nTWi7c51+Rk8G6EdL99De9 wmvGJ6L3YGveSGyZZ7gB6hpT0QRPL1yRRlhne8oeh47pbQZnEbjeKPc4ACNcYixQtBhe 7n3kqOJR/sWQ7+7PWD6ayNXXdZL7xu7iSdamyON7mRgcRds1WTTI9xkSBNpi0G/w/5Wm SXamLd29pWJYKFyD9oPBBkxgCsfOiBD5h1IvUCb+gWltEUE/1OTvwchpeSq7UmOGsL5S JUyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y28-20020a056a00181c00b004fa3a8dff53si7869610pfa.10.2022.04.10.21.14.09; Sun, 10 Apr 2022 21:14:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229994AbiDJG2k (ORCPT + 99 others); Sun, 10 Apr 2022 02:28:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232295AbiDJG2g (ORCPT ); Sun, 10 Apr 2022 02:28:36 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 039BD5A08F; Sat, 9 Apr 2022 23:26:25 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id E057168AFE; Sun, 10 Apr 2022 08:26:20 +0200 (CEST) Date: Sun, 10 Apr 2022 08:26:20 +0200 From: Christoph Hellwig To: Christoph =?iso-8859-1?Q?B=F6hmwalder?= Cc: Christoph Hellwig , dm-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Jens Axboe , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, "Martin K . Petersen" , Coly Li Subject: Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD Message-ID: <20220410062620.GA16234@lst.de> References: <20220409045043.23593-1-hch@lst.de> <20220409045043.23593-25-hch@lst.de> <72e9bd34-3380-e305-65f0-a17306f5bd08@linbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <72e9bd34-3380-e305-65f0-a17306f5bd08@linbit.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Apr 09, 2022 at 10:15:33AM +0200, Christoph B?hmwalder wrote: > On 09.04.22 06:50, Christoph Hellwig wrote: >> Just use a non-zero max_discard_sectors as an indicator for discard >> support, similar to what is done for write zeroes. >> >> The only places where needs special attention is the RAID5 driver, >> which must clear discard support for security reasons by default, >> even if the default stacking rules would allow for it. >> >> Signed-off-by: Christoph Hellwig >> Reviewed-by: Martin K. Petersen >> Acked-by: Christoph B?hmwalder [btrfs] > > I think you may have a typo there: my ACK was for drbd, not btrfs. Indeed, sorry.