Received-SPF: softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Gabriel Krisman Bertazi <krisman@collabora.com>
To:     Zhang Yi <yi.zhang@huawei.com>
Cc:     <linux-ext4@vger.kernel.org>, <tytso@mit.edu>,
        <adilger.kernel@dilger.ca>, <jack@suse.cz>, <yukuai3@huawei.com>,
        <yebin10@huawei.com>, <liuzhiqiang26@huawei.com>,
        <liangyun2@huawei.com>
Subject: Re: [RFC PATCH] ext4: add unmount filesystem message
Organization: Collabora
References: <20220412145320.2669897-1-yi.zhang@huawei.com>
Date:   Tue, 12 Apr 2022 12:01:37 -0400
In-Reply-To: <20220412145320.2669897-1-yi.zhang@huawei.com> (Zhang Yi's
        message of "Tue, 12 Apr 2022 22:53:20 +0800")
Message-ID: <87pmlmcmu6.fsf@collabora.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Zhang Yi <yi.zhang@huawei.com> writes:

> Now that we have kernel message at mount time, system administrator
> could acquire the mount time, device and options easily. But we don't
> have corresponding unmounting message at umount time, so we cannot know
> if someone umount a filesystem easily. Some of the modern filesystems
> (e.g. xfs) have the umounting kernel message, so add one for ext4
> filesystem for convenience.
>
>  EXT4-fs (sdb): mounted filesystem with ordered data mode. Quota mode: none.
>  EXT4-fs (sdb): unmounting filesystem.

I don't think sysadmins should be relying on the kernel log for this,
since the information can easily be overwritten by new messages there.
Is there a reason why you can't just monitor /proc/self/mountinfo?

> Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
> ---
>  fs/ext4/super.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 81749eaddf4c..bdecf62f4b55 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1199,6 +1199,9 @@ static void ext4_put_super(struct super_block *sb)
>  	int aborted = 0;
>  	int i, err;
>  
> +	if (___ratelimit(&ext4_mount_msg_ratelimit, "EXT4-fs unmount"))
> +		ext4_msg(sb, KERN_INFO, "unmounting filesystem.");
> +
>  	ext4_unregister_li_request(sb);
>  	ext4_quota_off_umount(sb);

-- 
Gabriel Krisman Bertazi