Received: by 2002:a19:f614:0:0:0:0:0 with SMTP id x20csp61593lfe; Fri, 15 Apr 2022 19:33:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeeKz87ovDotvBn/wutXPN2tgw1ysw9z54EYYU0tWNsJD7PqvLJQmE/9gY1JPFwV/19fkJ X-Received: by 2002:a05:6a00:174a:b0:4fd:ac35:6731 with SMTP id j10-20020a056a00174a00b004fdac356731mr1700071pfc.71.1650076428631; Fri, 15 Apr 2022 19:33:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650076428; cv=none; d=google.com; s=arc-20160816; b=E3Ms5ktPLTReBv+ru1rGpBvuUdmpYCPpm/vK+EGI3DqdWM5x37ZLUQbncM+w1FpPdK +2+VlnJYQ067GoVmbiZuW2BUQyEjCOkCBxt4v0uxP2SOMSZ0kIqRxvHAQlOTnYYJNQhI 4Lna6YXyIMIW6s1gwwJJzduU/d6n565Y+OV2Ki0ZLCG+tvDMnGUd1qkSFg4gWTT3IqQS MIEX6PcxiIFc0QFNowd2F9rS1AfgkjVLnRHdhkVaXTx6vqRc37PxcKGw6Mb+FQMLPLvq Fl8Q3XBuOmK6JOXVQnYN29KFxC2hncsLywTdsjVDBE5x8zH2fo/Ibs71ui0PdNj0c4d8 hOBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature :wdcironportexception:ironport-sdr:ironport-sdr:dkim-signature; bh=vKRwgfC4ED3wBU2n2i2ZES29ZkioKhUCaYEzFIzNAoM=; b=plytDv/Sz39a6k0zyTt4zl9CJjRyM6cJEBMjATwD3uGfYpOXt80eee2IkLpasMDmKn gxgj//NimtclcEWH/yZNNTrR4z+8N6YMLkO4fOTeXy1IeaZfvk56b0YObv+6rR31TKwZ fTzvlm3u4Cx+xe/9eZIfZ1Z/2AQiUECe1advQhkCBXdtqQkFLLZzvUq/OWf6oeLVLwm8 mAGRYtENLsiuUsf88GBDtRe9NSHxFkOi+mpqE7yTJa9W6BwAsMEAs1ab+eIY1uzCXntL xloNObbX0+QSdafC+Z7jTjhpjkJ9UaURQh5oDp9q50RTAxXVx3w0RkXX8Po5FhThf66/ vEPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=CeodHj5A; dkim=pass header.i=@opensource.wdc.com header.s=dkim header.b=ImgmXK0l; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=opensource.wdc.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q3-20020a17090a430300b001cb8978ee7csi5522743pjg.42.2022.04.15.19.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 19:33:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=CeodHj5A; dkim=pass header.i=@opensource.wdc.com header.s=dkim header.b=ImgmXK0l; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=opensource.wdc.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7D84AE6C63; Fri, 15 Apr 2022 18:43:37 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245693AbiDOFM7 (ORCPT + 99 others); Fri, 15 Apr 2022 01:12:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349924AbiDOFMv (ORCPT ); Fri, 15 Apr 2022 01:12:51 -0400 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A80A479390 for ; Thu, 14 Apr 2022 22:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1649999309; x=1681535309; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6js5zQuBI=; b=CeodHj5AU0alJr2r4eFscU+D8m0kJXg1ODgX9nrmamfCnysDgYDih22x A4/4CNNDVJqetnitRhP6wlNYKCh51OoqZs/JpkVdBXrzAw7MjvRXiCuCA sEGzd1ON9AuuxolKxnCdScJO0/KGz3U4+0aVIT2Oniu/0tRDxkDlefefE aBVcr4cb1mtfuWvGR70CKnKu0E9O8bgUM+ieBmu1if8AEiGLt0Iq876Ie RRwzUpkQndC5L1W1oyQJ1SMWwbPVZ4ELzZL/38iaxBRBDIHBD1UsLmqoG P4slNwlBXE8J3zUa0jzEzdJ7D1+/5RIjzNeVmCCxKHslzHDp9bp2H9SE3 w==; X-IronPort-AV: E=Sophos;i="5.90,261,1643644800"; d="scan'208";a="309936196" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 15 Apr 2022 13:08:28 +0800 IronPort-SDR: C36ysDM3lMpuS5xMQ53aYXUZFqTmP8H9FxuYIslnDKLYrqC7U/Od37LG3BavX9lnIp0LZpf+2f ANB1WS4yLfl+u4cFvChqHVGmCy11ez+opTTTNmocYKQL0K0FLkiZMtZ7Je38TtQxtImhD1uztc lKIBpltFG4LropgCBpYOBwQyt+7Wgi3rsACZHa9ubIL/Cm6AOiR8jepPmmnnF/MzWeS13Fjt+p 6tOXj95EKktCMsCIL7g7vUGolj5sdaJrl7mAvJYiMvaszDJN5Fg6098lLBbzhA5uCUytFf8goM dlfv4tJCvOwD44aQa1shXiRm Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 21:38:52 -0700 IronPort-SDR: 2GH8CvK7k2e5nbErC3X7HHUEAHSJD1+rfjUUirQOVvb9H2MzrOWxaomq42juWWs0rI9qFXN9Fc ejH2JoTk/0Ph3v7H9BwxAZkuYz7vQihKKoW1MwLKPzsxAPfAQNyLVnijQSRifQGHCQtD91CFl0 hGe9eW7sUrRoeudpcMgkpJ9bUciq+SaUDtQgm9wyggi0TA4zyk1uQ8xv8DNAI2POVPGUtTi+gS x0wOjH5EaxPGgPRB/XO+jth/rG3xkJQgBpnB3b46DSMN9pma1Qar0q+4GrKX6LeOGZoZdciyJh JYA= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 22:08:28 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Kfkqv0Qlcz1Rwrw for ; Thu, 14 Apr 2022 22:08:26 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1649999306; x=1652591307; bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6 js5zQuBI=; b=ImgmXK0ljefxmjcwwGCZe/P1ZAiYRfxiStEm0q2wFeKQMvkTL85 MoEiv1WWngR6yiDdywhy6m6c7CHetStsP2KPL7aGmRBSEDoQ0BBkWf7uSl7GctxX seFLiVHTqharLpAbcplk3yzDBSQpNNHnyTWqCGnT6SDEQPGGz4njOldB2JpZjV0c Fn1jBi13ZsAeHMQyLgImvLHIeNwH3xSreGo+kohOYlio/FQU9mPmWWTRsJd3G6Vg s7uGQ1kCv0yoS1gOWClHM7ArPs0jj6m4kJVcJWYcgsITqalXpkzGP3XvQ+R3owbL r+qmM2ogk4tvzMNidepDhru5fT38QuGd/Yg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sFFYii8iGedy for ; Thu, 14 Apr 2022 22:08:26 -0700 (PDT) Received: from [10.225.163.9] (unknown [10.225.163.9]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Kfkqn6sCZz1Rvlx; Thu, 14 Apr 2022 22:08:21 -0700 (PDT) Message-ID: Date: Fri, 15 Apr 2022 14:08:20 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 27/27] direct-io: remove random prefetches Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-28-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220415045258.199825-28-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 4/15/22 13:52, Christoph Hellwig wrote: > Randomly poking into block device internals for manual prefetches isn't > exactly a very maintainable thing to do. And none of the performance > criticil direct I/O implementations still use this library function s/criticil/critical > anyway, so just drop it. > > Signed-off-by: Christoph Hellwig Looks good to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research