Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jonathan Corbet <corbet@lwn.net>
To:     "wangjianjian (C)" <wangjianjian3@huawei.com>, tytso@mit.edu,
        adilger.kernel@dilger.ca
Cc:     linux-ext4@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] ext4, doc: Fix incorrect h_reserved size
In-Reply-To: <34889f32-7dd9-125e-2f7a-734faa395d20@huawei.com>
References: <34889f32-7dd9-125e-2f7a-734faa395d20@huawei.com>
Date:   Sat, 16 Apr 2022 02:58:08 -0600
Message-ID: <87ee1x2yn3.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

"wangjianjian (C)" <wangjianjian3@huawei.com> writes:

> According to document and code, ext4_xattr_header's size is 32 bytes, so
> h_reserved size should be 3.
>
> Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
> ---
>  =C2=A0Documentation/filesystems/ext4/attributes.rst | 2 +-
>  =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/ext4/attributes.rst=20
> b/Documentation/filesystems/ext4/attributes.rst
> index 54386a010a8d..871d2da7a0a9 100644
> --- a/Documentation/filesystems/ext4/attributes.rst
> +++ b/Documentation/filesystems/ext4/attributes.rst
> @@ -76,7 +76,7 @@ The beginning of an extended attribute block is in
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - Checksum of the extended attribute bloc=
k.
>  =C2=A0=C2=A0=C2=A0 * - 0x14
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - \_\_u32
> -=C2=A0=C2=A0=C2=A0=C2=A0 - h\_reserved[2]
> +=C2=A0=C2=A0=C2=A0=C2=A0 - h\_reserved[3]
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - Zero.
>

So this patch looks whitespace-damaged, please be sure that you can send
applyable patches to the list.

Beyond that, though, while you're in the neighborhood, please fix the
unnecessary underscore escaping (i.e. s/\_/_/).

Thanks,

jon