Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp3296940pxb; Mon, 18 Apr 2022 22:11:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzf3WBpu/GpXy79CBYjWOT9AUOg+uQ7klQ0QdIAMR7Jx/4tVl12FepFONvrnBaCpMr+5zR6 X-Received: by 2002:aa7:943b:0:b0:505:70bd:61ab with SMTP id y27-20020aa7943b000000b0050570bd61abmr15875644pfo.58.1650345115618; Mon, 18 Apr 2022 22:11:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650345115; cv=none; d=google.com; s=arc-20160816; b=yeotUA/iUbFLRFRQBum+iWS58cvYgzTDTAL+ZywRxvzhAyVL6G9Hmgex6WTMICdm/4 J8Uv4B5OfzkGCjQ31ifnZhwYdBKxIfN+EgSTtxIPjL9lx09alDkXJV/nuoCExbgTQ5Ia i1GiB6paCq9DPMNHeTRmDppt+aFLiQBNcaU33JR/rCXy5slou0HOCgBnJKdiHKck2QNb FBQT3qGd5iK4He7QqOCkvLvq4jchb5nLiEgKwPthz68wxHoosKkMSefTgzb9FtNgl7+g /IKMWqsi5FSOXPUh7WCYGxT/QMOug/Xn46as6kCT8Wxk5Cxxx4VJlR1Ye0OZ2Y7O3Daj 0Zdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=UEL2P2nS0cJcM5KcI+bv5bEAj3HcrbPSGJjI9+iNMuQ=; b=na+fMrmpq99WwVGhxrUQ9RPRjz0Y7n32IOnJa8FwNg8oiY1tEdrhOjnVwrP7G2xlqH PVD5IJn3NCZtI27nSCAW8fppQnqGQC8pRJ0nWaUUhoIvNPj+K+3QEWwKItMU7aprRtVH iXQQAK6pKOGwmtObFVJOrYSE38pL1bIRoLew7aB4MpuMOOQAUvIrgod39MItWvZJPv1m iuleXVM/7a6FHORQDjmlEGfsHe72dbHpCzBqc+BSPLANwh0QK51qKMdBbOobe2QztlOD bhPpuJI60HxOM222wAp6+sV2G/Moc+digOkzQ3sTWfupAEmCWMmfl/8WY4tRA/nX3xS+ Pk3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="T/5WGBYl"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s9-20020a056a001c4900b004fa3a8e005dsi690960pfw.276.2022.04.18.22.11.30; Mon, 18 Apr 2022 22:11:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="T/5WGBYl"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229865AbiDSDVg (ORCPT + 99 others); Mon, 18 Apr 2022 23:21:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232721AbiDSDVf (ORCPT ); Mon, 18 Apr 2022 23:21:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF7BF2656A; Mon, 18 Apr 2022 20:18:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7A85EB8113A; Tue, 19 Apr 2022 03:18:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0840C385A7; Tue, 19 Apr 2022 03:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650338332; bh=n0VqmNp9Q/CWVDkX0UhhbO6xIAM/hOOSr1ptOPIdeoY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T/5WGBYlFp1gL2NKjukwwcRZ+bGenghfSir5xlz/lAF4nZAnqZWutAXfz9wAtVvzi DkuZEd0YZvOg3WoSnFIju4ScMq3nDqvNCcmfDMLtxXoDlMB8i9SinvpdQX0Vrzg4qX aBPaFwK47os5qhDOckOle3ldkuX35gNUN8FsqAHP0je0LnpCfyCZYOS/pKLo2dySIF UjBJRkaTo5RKM3QZEuTQnn6hfX2h0WjPE0JVrZl6cgESLIrhUfHNR4gWPWstl7Y7Js fgow71CxnmQCDuNj+cIbs+Y14N8iKvYHdOxP8wUe+ENpFPs7yXQ0xiQjZxo6gDhwjt 5wz5NjOWC+10Q== Date: Mon, 18 Apr 2022 20:18:50 -0700 From: Eric Biggers To: =?utf-8?B?5bi45Yek5qWg?= Cc: "jaegeuk@kernel.org" , "chao@kernel.org" , "tytso@mit.edu" , "adilger.kernel@dilger.ca" , "axboe@kernel.dk" , "linux-block@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" Subject: Re: [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt Message-ID: References: <20220418063312.63181-1-changfengnan@vivo.com> <20220418063312.63181-2-changfengnan@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Apr 19, 2022 at 03:14:51AM +0000, 常凤楠 wrote: > > Thanks for your explanation, this patchset has too many case to forget to handle... > Back to my first thought, maybe there should have one sysfs node to indicate the > device support inlinecrypt or not ? So user can know it's device not support inlinecrypt > and not for other reasons. > Linux v5.18 has that. See https://git.kernel.org/linus/20f01f1632036660 ("blk-crypto: show crypto capabilities in sysfs"). - Eric