Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 28 Apr 2022 12:53:13 +0800
From:   Zorro Lang <zlang@kernel.org>
To:     Theodore Ts'o <tytso@mit.edu>
Cc:     fstests@vger.kernel.org, djwong@kernel.org,
        linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] ext4/054,ext4/055: don't run when using DAX
Message-ID: <20220428045313.kntbytbqlpgummql@zlang-mailbox>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>, fstests@vger.kernel.org,
        djwong@kernel.org, linux-xfs@vger.kernel.org,
        linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org
References: <20220427005209.4188220-1-tytso@mit.edu>
 <20220427080540.o7tu3nz6g5ch6xpt@zlang-mailbox>
 <YmlY5NhDodhRRpkU@mit.edu>
 <20220427171923.ab2duujwkljyatyv@zlang-mailbox>
 <YmmdOvsw7gJXqu9X@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YmmdOvsw7gJXqu9X@mit.edu>
Precedence: bulk

On Wed, Apr 27, 2022 at 03:44:58PM -0400, Theodore Ts'o wrote:
> On Thu, Apr 28, 2022 at 01:19:23AM +0800, Zorro Lang wrote:
> > I just noticed that _scratch_mkfs_sized() and _scratch_mkfs_blocksized() both use
> > _scratch_mkfs_xfs for XFS, I'm wondering if ext4 would like to use _scratch_mkfs_ext4()
> > or even use _scratch_mkfs() directly in these two functions. Then you can do something
> > likes:
> >   MKFS_OPTIONS="$MKFS_OPTIONS -F -O quota"
> >   _scratch_mkfs_blocksized 1024
> > or:
> >   MKFS_OPTIONS="$MKFS_OPTIONS -F -O quota" _scratch_mkfs_blocksized 1024
> 
> I'd prefer to keep changing _scratch_mkfs_sized and
> _scatch_mkfs_blocksized to use _scratch_mfks_ext4 as a separate
> commit.  It makes sense to do that, but it does mean some behavioral
> changes; specifically in the external log case,
> "_scratch_mkfs_blocksized" will now create a file system using an
> external log.  It's probably a good change, but there is some testing
> I'd like to do first before makinig that change and I don't have time
> for it.

Sure, totally agree :)

> 
> > We just provide a helper to avoid someone forget 'dax', I don't object someone would
> > like to "exclude dax" by explicit method :) So if you don't have much time to do this
> > change, you can just do what you said above, then I'll take another time/chance to
> > change _scratch_mkfs_* things.
> 
> Hmm, one thing which I noticed when searching through things.  xfs/432
> does this:
> 
> _scratch_mkfs -b size=1k -n size=64k > "$seqres.full" 2>&1
> 
> So in {gce,kvm}-xfstests we have an exclude file entry in
> .../fs/xfs/cfg/dax.exclude:
> 
> # This test formats a file system with a 1k block size, which is not
> # compatible with DAX (at least with systems with a 4k page size).
> xfs/432
> 
> ... in order to suppress a test failure.
> 
> Arguably we should add an "_exclude_scratch_mount_option dax" to this
> test, as opposed to having an explicit test exclusion in my test
> runner.  Or we figure out how to change xfs/432 to use
> _scratch_mkfs_blocksized.  So there is a lot of cleanup that can be
> done here, and I suspect we should do this work incrementally.  :-)

Thanks for finding that, yes, we can do a cleanup later, if you have
a failed testing list welcome to provide to be references :)

> 
> > Maybe we should think about let all _scratch_mkfs_*[1] helpers use _scratch_mkfs
> > consistently. But that will change and affect too many things. I don't want to break
> > fundamental code too much, might be better to let each fs help to change and test
> > that bit by bit, when they need :)
> 
> Yep.   :-)
> 
> 						- Ted
> 
> P.S.  Here's something else that should probably be moved from my test
> runner into xfstests.  Again from .../xfs/cfg/dax.exclude:
> 
> # mkfs.xfs options which now includes reflink, and reflink is not
> # compatible with DAX
> xfs/032
> xfs/205
> xfs/294

Yes, xfs reflink can't work with DAX now, I don't know if it *will*, maybe
Darrick knows more details.

> 
> Maybe _scratch_mkfs_xfs should be parsing the output of mkfs.xfs to
> see if reflink is enabled, and then automatically asserting an
> "_exclude_scratch_mount_option dax", perhaps?

Hmm... good point, does it make sense to you, Darrick?

This patch can do what we talked in last patch, and welcome later patches from
extN forks:) I can help to deal with XFS part later. I don't know if btrfs has
similar troubles, welcome patches if they need too.

The change on _scratch_mkfs_blocksized will help common part, but can' help all
situations. Maybe better to let each fs change and test their fundamental helper
changes separately, to avoid regression :)

Thanks,
Zorro

>