Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp619074iob; Thu, 28 Apr 2022 08:45:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbR7pMeLqMsq9NNIvcx4QgCkom2IxFF6D9+MV3J3jTwmQeo45pE+39XqB7msgjS90FTUIz X-Received: by 2002:a17:90a:ec0e:b0:1d9:7f4d:23be with SMTP id l14-20020a17090aec0e00b001d97f4d23bemr22871530pjy.181.1651160708132; Thu, 28 Apr 2022 08:45:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651160708; cv=none; d=google.com; s=arc-20160816; b=L7fUWKeiKrRaUFJgoHEtlBgY7PLG2PW8o3dYp0n2SqsfMNkqWoQ+Crypp8OlJfHBnL YLKLNrw7m1paYtYDEN82DxkWyy6Xtr3Et8hb1Ck2uj700bjG1zJ10V4aMJBUpRKDN2se Yfci1bAJSUPsx2APJsvJ9f63VkTbvPgfiFvUmvijYCFO9nkFrotj9nYFKMzzgFL9tips ev28E8j0MeHyy5lG16oAyevntkzFq+F2lwATorTxTT1hr9wzNmtqjON9ldhw5BEv0vKs blnvWL/oGFFM95GFE+ToW6NVu543gws8fCyIrrrs/ZFch6bWqKbhcC+71K1QSWYOAMCW u0Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=sPt9llwQwfEn00zm9z8waLKoSA490KKs/M0hG5mo5j8=; b=hjDw5cmD8VPCm96el5LKncboetOKnao+XrbFJIVGPHxsTnfOKEa07VEa3IaeMoAW9z Rd7QMrXpYMo6juITLF/+Bc6kpSJrCnu2I44CWcD1Y4wirW0L+SmoL+tJFULPbzFQk8eO nmp4J9+b6RnS0P0wv/oZYpugLse/zEiMjKktOhjZMhsHZUhkW7tPawzVI9EAuPXAw7/1 DeeDzzHcP2vs0wEtEfAr0CfwSyfF0o3DeLDABYC2F7QosIwPbHs76weRKrxOVGNGPRex jMLYcGu9+0Xi2uT8v543QdcmrUZeOpO+YeTOM7tjSpwXgnkwn1QMVj1+PPEF/XEmUKTA jttA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w2-20020a170902e88200b001589d3cab77si4997584plg.388.2022.04.28.08.44.47; Thu, 28 Apr 2022 08:45:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348257AbiD1OrE (ORCPT + 99 others); Thu, 28 Apr 2022 10:47:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347623AbiD1OrD (ORCPT ); Thu, 28 Apr 2022 10:47:03 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3351C21E38 for ; Thu, 28 Apr 2022 07:43:49 -0700 (PDT) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 23SEhhKq032434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Apr 2022 10:43:43 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id F281615C3EA1; Thu, 28 Apr 2022 10:43:42 -0400 (EDT) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Lukas Czerner Cc: "Theodore Ts'o" , Nils Bars Subject: Re: [PATCH] e2fsprogs: add sanity check to extent manipulation Date: Thu, 28 Apr 2022 10:43:40 -0400 Message-Id: <165115689135.440993.1403044617589707642.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220421173148.20193-1-lczerner@redhat.com> References: <20220421173148.20193-1-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, 21 Apr 2022 19:31:48 +0200, Lukas Czerner wrote: > It is possible to have a corrupted extent tree in such a way that a leaf > node contains zero extents in it. Currently if that happens and we try > to traverse the tree we can end up accessing wrong data, or possibly > even uninitialized memory. Make sure we don't do that. > > Additionally make sure that we have a sane number of bytes passed to > memmove() in ext2fs_extent_delete(). > > [...] Applied, thanks! [1/1] libext2fs: add sanity check to extent manipulation commit: ab51d587bb9b229b1fade1afd02e1574c1ba5c76 Best regards, -- Theodore Ts'o