Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Sierra Guiza, Alejandro (Alex)" <Alex.Sierra@amd.com>
To:     "Sierra Guiza, Alejandro (Alex)" <Alex.Sierra@amd.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "apopple@nvidia.com" <apopple@nvidia.com>
CC:     "rcampbell@nvidia.com" <rcampbell@nvidia.com>,
        "willy@infradead.org" <willy@infradead.org>,
        "david@redhat.com" <david@redhat.com>,
        "Kuehling, Felix" <Felix.Kuehling@amd.com>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "jglisse@redhat.com" <jglisse@redhat.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
        "hch@lst.de" <hch@lst.de>
Subject: RE: [PATCH v1 04/15] mm: add device coherent checker to remove
 migration pte
Thread-Topic: [PATCH v1 04/15] mm: add device coherent checker to remove
 migration pte
Thread-Index: AQHYYMgGjgxyHrmtGk6QLDJATlgC2K0Qzsjg
Date:   Thu, 5 May 2022 21:38:07 +0000
Message-ID: <SN6PR12MB27173F2F37294D6DDBC3457CFDC29@SN6PR12MB2717.namprd12.prod.outlook.com>
References: <20220505213438.25064-1-alex.sierra@amd.com>
 <20220505213438.25064-5-alex.sierra@amd.com>
In-Reply-To: <20220505213438.25064-5-alex.sierra@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z96eIh5ESCSV5/dOLE/VRFh4gROWsa4oSxnft0n8d6psRoFH5vnJS6pNJYew?=
 =?us-ascii?Q?Y1a3CSrbIXbO4zSzwQlB5TFheBOGjuFDPEEkfeNyf92PkFMMdn91LsmV2Tqj?=
 =?us-ascii?Q?1bjx8tWuKP4Y8Z8fQ+GlNpD3UFN55uifMd4Rssm0cTeigm8pOtwFZdttU9eQ?=
 =?us-ascii?Q?EpcafKdwkmifKLYR6vbnZ8NvsfhIfA1uLeAf3Nf4xx0FPU3tpcSY4SLov5Vt?=
 =?us-ascii?Q?S/5hEYuw2pYeuDomss1Eb7L7CoognDQo259bNIA5riweVoZqk2c7x3TDjY6b?=
 =?us-ascii?Q?gfYSidq9NO32mVkxOoXriqM3sxmNXKSd72l2tNAt8RcqJixfQO9dg7cA7Di6?=
 =?us-ascii?Q?5u3AaCnBmpxNdFBacriWVjpBhrGto5e8eyY8xncIFg5TYTfADhJU9vDSNMDi?=
 =?us-ascii?Q?gFjdIfQTVMODvbek0gpxmsk+IFcpxQctb2JeYQLUf7w/kx5NSF50BDdJl/eW?=
 =?us-ascii?Q?U7xvz2jz+dnRWGk0bhL6ovzgeJyAAUMWCBAZyeLroo6vl564we+wxBrlSpCR?=
 =?us-ascii?Q?Y01HGBOgYGNgy4yM+cjESjtmZAPuKy3nqdGl1Tl+ThPCO9bzA0LJvCLDPV+j?=
 =?us-ascii?Q?ZCUJ9fUAEWBGAWAS9DDGTaNR/43dMYQD4hVC2M7y7kMQm+jN0Sr8HXOj94uW?=
 =?us-ascii?Q?oX22cgKEOZQfaS7VUh6cstmzw5TOaEza7Zl/M7g8IxlpbxUuv0dMxeSdttDl?=
 =?us-ascii?Q?CQY99Ky3VD22EevAljHKKOSyi25VU0HOvwUj/7FQzCq+brVq0Y11KJCY1QJq?=
 =?us-ascii?Q?N0B73oGk9I2d1jQfrpD5nxuAEWo7b1jlDUck6iCpeRE4cE3MIV8HbS4UWWVf?=
 =?us-ascii?Q?W5kI8IMFVjU/QvBJvHIXtuY/cyr25fnw3C/J9pDl800kCYt91vcqJszJtB9q?=
 =?us-ascii?Q?t+qkIJvv+a99UDzLzNaFvw7949Snom8UoUukwe/nXNYOQrOVOdib7/btYj9Z?=
 =?us-ascii?Q?Z6pjqoGPVuDEkxjYqrzhvukByoJw3s6Nzi1cgLaosn9SozqMNn4l/PyPb83O?=
 =?us-ascii?Q?1gIbXiYgvFJ9EAMEuJwYfSFAJJrgJm/U6tl3cF4xkgWN1N5e9DruQaJM3JGe?=
 =?us-ascii?Q?iF6yf9cmJzyrOV53H0ReriGb6ABqjCXUWZc2m2BuWWgMZmP+MW7vF4UC95ss?=
 =?us-ascii?Q?dmrAcjofZkfeoos5BHVCl1kAMxEOqKlVZc17/QRhMg8fMCj2VeZhuyPNirjk?=
 =?us-ascii?Q?qMztCruqPw+JKUQX7hf4ordxryQwkl8YjPMF0UcW46lq8irHoNVPYcdIKq87?=
 =?us-ascii?Q?rzxejnSE5Ek0mU1iXwPhrhcGgs+1LMOWFqzU18oqF1Ekau5lHK4vLDE3lI9s?=
 =?us-ascii?Q?9NrFResylkyC0fGPbsAZNTLYNPr9JyA4r7s9G416KXfaJJwihTwp6112GT8k?=
 =?us-ascii?Q?OhyBJwgQHiwIth7z2Ho9RhueBzxqgjke5v+TwnuIEg0gIx7/yMJFUPhrmJnq?=
 =?us-ascii?Q?MevYjhY7fNt2fngmBEXQci68lVMVeiNVs+AzdtXWai5siOOW8wvBTvOucl8T?=
 =?us-ascii?Q?dB4ZDRANOztOfdHikYhpN5IpcDZJq0DB/KbpM6EcVMXb060trMQcAMIWnFiZ?=
 =?us-ascii?Q?bwJJY32owKeuFuosSAdRXWgApWCwlaHBLPElF1pbhRVTo9pij90pUxMjun3O?=
 =?us-ascii?Q?m9rk6IoonFJk5lgYdFDg0TVZsYfKxjk0hOR8+2RJKkin4T5ojtKXhIGjcwH5?=
 =?us-ascii?Q?tAaV2sW++VrkTU5KSD7oZGTyy95oxLMhmja7E8Umi7brLmQH?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2717.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c917ea8-4da3-4a26-5ae6-08da2edf8b54
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2022 21:38:07.6023
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nUHSTSIuR/+r3WgTV+FI6dEwxezN9wOcWVxFbKaQXRPGTdtahlkmyXLKeIv2HyiPuGbSGOh7v34bNy1jm8hQBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5991
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

@apopple@nvidia.com Could you please check this patch? It's somehow related=
 to migrate_device_page() for long term device coherent pages.

Regards,
Alex Sierra
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex
> Sierra
> Sent: Thursday, May 5, 2022 4:34 PM
> To: jgg@nvidia.com
> Cc: rcampbell@nvidia.com; willy@infradead.org; david@redhat.com;
> Kuehling, Felix <Felix.Kuehling@amd.com>; apopple@nvidia.com; amd-
> gfx@lists.freedesktop.org; linux-xfs@vger.kernel.org; linux-mm@kvack.org;
> jglisse@redhat.com; dri-devel@lists.freedesktop.org; akpm@linux-
> foundation.org; linux-ext4@vger.kernel.org; hch@lst.de
> Subject: [PATCH v1 04/15] mm: add device coherent checker to remove
> migration pte
>=20
> During remove_migration_pte(), entries for device coherent type pages tha=
t
> were not created through special migration ptes, ignore _PAGE_RW flag. Th=
is
> path can be found at migrate_device_page(), where valid vma is not
> required. In this case, migrate_vma_collect_pmd() is not called and speci=
al
> migration ptes are not set.
>=20
> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
> ---
>  mm/migrate.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/mm/migrate.c b/mm/migrate.c index
> 6c31ee1e1c9b..e18ddee56f37 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -206,7 +206,8 @@ static bool remove_migration_pte(struct folio *folio,
>  		 * Recheck VMA as permissions can change since migration
> started
>  		 */
>  		entry =3D pte_to_swp_entry(*pvmw.pte);
> -		if (is_writable_migration_entry(entry))
> +		if (is_writable_migration_entry(entry) ||
> +		    is_device_coherent_page(pfn_to_page(pvmw.pfn)))
>  			pte =3D maybe_mkwrite(pte, vma);
>  		else if (pte_swp_uffd_wp(*pvmw.pte))
>  			pte =3D pte_mkuffd_wp(pte);
> --
> 2.32.0