Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 May 2022 15:50:12 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Alex Sierra <alex.sierra@amd.com>
Cc:     david@redhat.com, Felix.Kuehling@amd.com, linux-mm@kvack.org,
        rcampbell@nvidia.com, linux-ext4@vger.kernel.org,
        linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com,
        apopple@nvidia.com, willy@infradead.org, akpm@linux-foundation.org
Subject: Re: [PATCH v1 13/15] mm: handling Non-LRU pages returned by
 vm_normal_pages
Message-ID: <20220511185012.GM49344@nvidia.com>
References: <20220505213438.25064-1-alex.sierra@amd.com>
 <20220505213438.25064-14-alex.sierra@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220505213438.25064-14-alex.sierra@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VXeI4TGIR7OlomdUi3o61UcKGiMx/fblucIB5fmF7gqfjdgBmNp78Pa6VjuD?=
 =?us-ascii?Q?iQH9XiEoSKntOl/f5DHCwh/a3z/zH9sTSr2L3LvDDKRoILPHlW94lwBtP2SX?=
 =?us-ascii?Q?N/mzJm/H+bt5okXiynUqz966SZlu/IVy8N13F1LnAuhbzMo5N8oBTPH495+8?=
 =?us-ascii?Q?E6rxeNpW+btooTwRMocWxTgiiuUJlHHaVpt7SOmZw/OXuOWPZM9wJ1SQJlGD?=
 =?us-ascii?Q?yElu6BFv5uGkQIyaxctTQ2cFSVW7cp4/jtaj/Uk6DfzADvlvpOd6A67CSAGE?=
 =?us-ascii?Q?aIQ2r57ltUUHKCt3trm9wOWsHZdYKcSWNvYsWeP4v69c8Jao2wpE/V7wpfdZ?=
 =?us-ascii?Q?l8+6eVLGriK8A0JqDgYCK7FYm/dM1TVE9m8RS/f6LGUUuhvsShcULL9qx4tR?=
 =?us-ascii?Q?BBZ2CzKiGUhPzjtn50dNb/zL9fwJdEgVsQq9m5HmNM+AslCdjTaKS4I5zOWa?=
 =?us-ascii?Q?HuX4UFrTOV27OfIK/0AHLAcyXSFLCbN4vaC9azI9v2oOLIxigoWN0Ffa6LVV?=
 =?us-ascii?Q?8MpTcrGQzkbV6SgHhTnoILqelX+JNbPZnSBui3YfzwvSIerGvPbDAG4z2RU1?=
 =?us-ascii?Q?piLu1+n/MzfY5uqVsY3J1uHdV6Qbz/6spR2+KGXX4hDSVpNS6ftjPujqrXtS?=
 =?us-ascii?Q?v3Ef6pZJIoq0yo17hGyebeOyx673fU1lKC6y9MES/ga3+4xG2NB2wTpWzQSj?=
 =?us-ascii?Q?xtJJdB8q3Mi+g2Rk7MCtTrVK6Sk1CVemO75RDF/jXPoD98DvKiXfA86L3f8v?=
 =?us-ascii?Q?rR/i/mEeeVPl2fGderxTpv4yEiwd34Tm+vgxpXNu2PSHKOSt7KC3mqaKLDmV?=
 =?us-ascii?Q?wyT6xJQ8eyfZj+ly4gilD6lIL2pZDRfkCSiXP4HZ537r6nV66hngFsPgAXEJ?=
 =?us-ascii?Q?iLeDTLAUCHTZQlhOLJ2tvSzZKqiwOxkgZxbS6Fo44JnbBclT/wCHQ7S2zv7C?=
 =?us-ascii?Q?AcO1XUOV9SZRJzbWK2Tv0Zx9JYPjKOl6B25Ufis7n7gK8cXz3KY4DJP4dJaP?=
 =?us-ascii?Q?6C7RPReWiZMkRrk5l1aEPBN92JOWDYfrMNgKRZDsJIV14ZatVrmhvp4l9Yfo?=
 =?us-ascii?Q?2Hawu9uU3RMz1C0P+YHBeykYaUCzFwPM/YLp0plKswhCT/wykiW17qkVOQNu?=
 =?us-ascii?Q?bFLP04TvSmTMoKY5rcJPYLjqZH8Fw23Vds/w1i8MBhrSYLzBv/nOnDQaTzXb?=
 =?us-ascii?Q?XXSZ2jqfOh/bQjswRduA1XUfjPU8Gf2k8uaxBZk58BEb0hCv63yl1Ez7jpjv?=
 =?us-ascii?Q?5bw9PyFdMrUKnWxGn4lsqXKQjKmxmAFmVrZtCsnDxGWn7IstdFBIAgvPDc1k?=
 =?us-ascii?Q?KB20uSG2N9Xr3AOCd6GDYiH6TiefGBrVYs9s+Ep+pINyedUYOY0el3ndtk7e?=
 =?us-ascii?Q?p6fbuPixtsyeT1GYGOIpMyAb/l6M+MVgAaTZHEz9xPou6FQ5N4fisxGpCshM?=
 =?us-ascii?Q?fCqVWmbd6KVJjiccJLGzZeid9TKMZvAbSqhDILMSh3Phk4ZPCtajtd4QgLFt?=
 =?us-ascii?Q?utEL1JqYFSwuwb0HKRo0vJQEhG/zmMbaOY7wQMna2LNNA7+iN38WClr4TTPX?=
 =?us-ascii?Q?A27lsTopsLpVfaVMr2bJLnipGxm6SDAKbCKdgOyf6dccEuc7V/wpAEvXmauj?=
 =?us-ascii?Q?vk2aYk45pXxKkRIiPCmuNIQXCJRbCq4f4XuTCbOA90GFSw5XI5zc5+aG8CZw?=
 =?us-ascii?Q?W5hUAoMXK1XwnBAxFQ0tp3x3SK8W/NkJYktic7Dam46q3rfntgqvATw66hNu?=
 =?us-ascii?Q?IqMxZ8j9zA=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 975e0cb6-1cae-42e3-6680-08da337f14f1
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 18:50:13.3136
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iSzZ/Sju3P7QEIdvF9dnGCNImeuiNe/1R7vKVUcPHkRhwZlvo4+fTw4Q1R3SjIBP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3281
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Thu, May 05, 2022 at 04:34:36PM -0500, Alex Sierra wrote:

> diff --git a/mm/memory.c b/mm/memory.c
> index 76e3af9639d9..892c4cc54dc2 100644
> +++ b/mm/memory.c
> @@ -621,6 +621,13 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr,
>  		if (is_zero_pfn(pfn))
>  			return NULL;
>  		if (pte_devmap(pte))
> +/*
> + * NOTE: Technically this should goto check_pfn label. However, page->_mapcount
> + * is never incremented for device pages that are mmap through DAX mechanism
> + * using pmem driver mounted into ext4 filesystem. When these pages are unmap,
> + * zap_pte_range is called and vm_normal_page return a valid page with
> + * page_mapcount() = 0, before page_remove_rmap is called.
> + */
>  			return NULL;

? Where does this series cause device coherent to be returned?

Wasn't the plan to not set pte_devmap() ?

Jason