Received: by 2002:a19:651b:0:0:0:0:0 with SMTP id z27csp841517lfb; Fri, 13 May 2022 21:28:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLlWII48KhOHmoE63d4L5BF18kSag60Gvvx8X55PWxTmbfQY5/9j/wyLCAu24t/bEFLraG X-Received: by 2002:a05:6000:1864:b0:20a:c3f3:8262 with SMTP id d4-20020a056000186400b0020ac3f38262mr6412519wri.372.1652502534466; Fri, 13 May 2022 21:28:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652502534; cv=none; d=google.com; s=arc-20160816; b=YsVz3wN9BxzDUxrKbMb9M4jQWBxcmWwYDMD+4i3uBjrd8fKfOd2P1C4V45GRJvDj1C rf9hpvG+QfutfbKnjfrk/oMEo2v/NjoFiiAowXENk553iO7yE/wEYNp5yd6y9TKj5nnC Obe5tRw33zf5/2dl82IpHHmvBQR4vPsRPJvSt2ahK/5RQpJnxyqvj1ANHAS1v0xnOQd8 Z9BjckYKNa5oFw58MgfDVSoX8xn0Fyy2FDho8PwFG25qYfDFCEyLS7yXT395sSsk9OW6 tfdTxLeeXjOq43J6FFIieaKHoZqxYkz7nXUM/R6JG+unLdsH3C9ZMXtmpuhFjwEbg2qb x76w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cvtH10wIW/qllaw6YhvAWlxdl4Ldk6y+ev2akrrJW/M=; b=byRvlzvAl1wHL85aklqWgMVn+pAp1GZzhOwQ3xfboPYysd7BXwIlrd5j3N1B2wsSDe DRHEG+FPG4ckf7Qzt+GtopV6ekVC5Ij9hRlOdfpRUU2dGKKmTlLhKSm8qem5STXtM4Sp tVVEmChRnH8Uq8vAh7Pw3ht+GAM6n0m60r5AfSLRaFxlo6113Tpe0rVdOtNEd5hLIXLU lGgCQv7zN7gUx68qiJ37EfIhGgWuquS7XeRJv2p6NY2P7Eu/Pj9QjjN5yrh2cbw+aZlW LBV6+/kJvosd95bV4VPYi3vZsA9WWkMvrGtyvsm+oo+yU6iZhIC0J+oerKuaVPN+b+k0 ygcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=Zmg8m4qs; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id l11-20020a5d6d8b000000b0020618827cf8si4502254wrs.561.2022.05.13.21.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 21:28:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=Zmg8m4qs; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A8DA63669DF; Fri, 13 May 2022 19:57:35 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231325AbiENC5N (ORCPT + 99 others); Fri, 13 May 2022 22:57:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231523AbiENC4X (ORCPT ); Fri, 13 May 2022 22:56:23 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AA8B321D66 for ; Fri, 13 May 2022 18:52:15 -0700 (PDT) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 24E1qBtt022837 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 May 2022 21:52:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1652493132; bh=cvtH10wIW/qllaw6YhvAWlxdl4Ldk6y+ev2akrrJW/M=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Zmg8m4qssGm0xR+cmcIwDS9Nv51Q4JMHOr/ELYenmWjcxYK5AMbd1Jdsdkf+cpnZZ B/uqFwv9PIyT3JwQZ8Jms5w66EOsAT33rMl0e131/ANaku25z7/MiXdAOMw9i1gmQS HmPt3UHAU41FJVpZW3cqtKAgdOYOboU793hKzhK09+CfWtSrzdpvnrq/rp9xW0q/hD fZKZ+ivm4pyifG3MFBQ1nyfoP4vNA1NoiU8RJTHGD1Wi/CVbtFDfniNihESiz8jKm2 LF3n31SHKhkag7e/Xmw+/GkwwesJUFc6ubugWClKViGfKaSVYd0wp/pZXERS3+Hk/9 jElxS5TaWsQ4Q== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 4B61F15C3F2A; Fri, 13 May 2022 21:52:11 -0400 (EDT) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Dmitry Monakhov Cc: "Theodore Ts'o" Subject: Re: [PATCH] ext4: mark group as trimmed only if it was fully scanned Date: Fri, 13 May 2022 21:52:10 -0400 Message-Id: <165249310227.638202.3921167990549958733.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <1650214995-860245-1-git-send-email-dmtrmonakhov@yandex-team.ru> References: <1650214995-860245-1-git-send-email-dmtrmonakhov@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun, 17 Apr 2022 20:03:15 +0300, Dmitry Monakhov wrote: > Otherwise nonaligned fstrim calls will works inconveniently for iterative > scanners, for example: > > // trim [0,16MB] for group-1, but mark full group as trimmed > fstrim -o $((1024*1024*128)) -l $((1024*1024*16)) ./m > // handle [16MB,16MB] for group-1, do nothing because group already has the flag. > fstrim -o $((1024*1024*144)) -l $((1024*1024*16)) ./m > > [...] Applied, thanks! [1/1] ext4: mark group as trimmed only if it was fully scanned commit: 326118d762e2eaaec580fcc151f853a96f3ad71a Best regards, -- Theodore Ts'o