Received: by 2002:a19:651b:0:0:0:0:0 with SMTP id z27csp842804lfb; Fri, 13 May 2022 21:31:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6rGSomzervjYw5BXwLlhreRQUW6NzWlvZtvL3sJ/9EgZ708UTBikhmPNLGatI6dICWdF8 X-Received: by 2002:a7b:c8c7:0:b0:394:9e02:baa with SMTP id f7-20020a7bc8c7000000b003949e020baamr17249580wml.26.1652502682388; Fri, 13 May 2022 21:31:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652502682; cv=none; d=google.com; s=arc-20160816; b=DawBMHu3+WKlNAN1zcnpHyo25fUKScbFis/iRNEGE0bROaBebTNZv/3f77b8AGO7Jp QvIRU7FzW61F9gU+X07e1MnZQmlEwywNA2/t4vzDW1RvwzowA3a4gEkzW8ySiq3P+Bi6 E8Tbpg9cwBhVvrErXAwxs1oqI9qec1h4jwHcgjPzxp5mz9XNL/l8eMBr6rYXTjWzbbWK lJN0i81jSQiX3wyq/oiYv/US61hS2s0t5O6jj9ib7pt+aV3s0FcPvTBGGQKakPJhY9jK fnC0yNQwJu6BaOWpCx28+RoBS6+cNr94zrEWm7N5IclRgQA085uWmS12yzIXOP9Z8f+f ogVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sFmzqkIeci57u6nHHwJ3RZ6bKRyy3u2QpbbxnT80U28=; b=dBNQfUcTl37DgZrghCeCCqyAhq65h79lw7DbQ4ptS7KU2RFm0QG4f80U18Afr8Buw0 qxTiZggsrA9ckGgV/hqS9vVJ+s8U3pDAtM/rzCFD0BstRltZp0zkrWglg7hF4FoHjbgy 2MktVtbmjZZd+K5/vVQhr4I8u/7RxgKlV+SU9K99Znwsw5otrgd0VsKr9VEsGA2Iuwgs 5KU81GL97tzAwykdpmNsx8CSj+iw8X27/GgDZSTu/DtF04+zMbm2xfh/6wvdmHLhBEGw oA5hnX4a0Tbsv1I0swfdKiN2zuf7XvxLdJGUKbfpMPDHWFCRTkuPVjeAjSmaBxKfNKAo sJKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=mxx6yK9t; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id a19-20020a05600c349300b00394481a7d66si7415032wmq.217.2022.05.13.21.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 21:31:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=mxx6yK9t; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DBFED338439; Fri, 13 May 2022 19:57:02 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231318AbiENC45 (ORCPT + 99 others); Fri, 13 May 2022 22:56:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231325AbiENC4U (ORCPT ); Fri, 13 May 2022 22:56:20 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31712D9E93; Fri, 13 May 2022 19:03:23 -0700 (PDT) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 24E23GDX027652 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 May 2022 22:03:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1652493798; bh=sFmzqkIeci57u6nHHwJ3RZ6bKRyy3u2QpbbxnT80U28=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mxx6yK9tTGz/EXWRPSsD9y1HlsrJLehKhvLirg43Gz6E75bazb57jOSow2szOuxqj vABckrFZbiAXiME0gNfco8F4hyWjrWQaddWm7oQxRux8XRq0Mu/oSJpoH+Yj3updeI CZnp+vVMLZzOuNdYXlTuNVJc257Tct9VOyLrxNM8Vc7UonNsaCNP9PBLmlZIwPw1jV icBu/0QCElbayJYzCoR0C4/q+/LvmgjqsUNlSlYR1s4cyeHXfQfjG2IsfJM6+FuT/Y MMY2SsoKHdpikJITrxEiHdSd2zoScFwnJWSj4/U/HstAzHBLY1NZ0Lrwqpb4XzfgzV 8H3TWGRE1lpnA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 441E615C3F2A; Fri, 13 May 2022 22:03:16 -0400 (EDT) From: "Theodore Ts'o" To: Ojaswin Mujoo , linux-ext4@vger.kernel.org Cc: "Theodore Ts'o" , linux-fsdevel@vger.kernel.org, Ritesh Harjani , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: Fix journal_ioprio mount option handling Date: Fri, 13 May 2022 22:03:15 -0400 Message-Id: <165249378801.644521.15436473858156116983.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220418083545.45778-1-ojaswin@linux.ibm.com> References: <20220418083545.45778-1-ojaswin@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 18 Apr 2022 14:05:45 +0530, Ojaswin Mujoo wrote: > In __ext4_super() we always overwrote the user specified journal_ioprio > value with a default value, expecting parse_apply_sb_mount_options() to > later correctly set ctx->journal_ioprio to the user specified value. > However, if parse_apply_sb_mount_options() returned early because of > empty sbi->es_s->s_mount_opts, the correct journal_ioprio value was > never set. > > [...] Applied, thanks! [1/1] ext4: Fix journal_ioprio mount option handling commit: 8d7b9890b5d18a593b7c7e10d23513340919b837 Best regards, -- Theodore Ts'o