Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 15 May 2022 10:15:49 +0530
From:   Ritesh Harjani <ritesh.list@gmail.com>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-ext4@vger.kernel.org, linux-fscrypt@vger.kernel.org,
        Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCHv2 1/3] ext4: Move ext4 crypto code to its own file
 crypto.c
Message-ID: <20220515044549.g63qnyuapp54kv76@riteshh-domain>
References: <cover.1652539361.git.ritesh.list@gmail.com>
 <4f6b9ff4411ced6591f858119feb025300ecf918.1652539361.git.ritesh.list@gmail.com>
 <YoB0lYeJv+Cm+C5Y@sol.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YoB0lYeJv+Cm+C5Y@sol.localdomain>
Precedence: bulk

On 22/05/14 08:33PM, Eric Biggers wrote:
> On Sat, May 14, 2022 at 10:52:46PM +0530, Ritesh Harjani wrote:
> > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> > index a743b1e3b89e..9100f0ba4a52 100644
> > --- a/fs/ext4/ext4.h
> > +++ b/fs/ext4/ext4.h
> > @@ -2731,6 +2731,9 @@ extern int ext4_fname_setup_ci_filename(struct inode *dir,
> >  					 struct ext4_filename *fname);
> >  #endif
> >
> > +/* ext4 encryption related stuff goes here crypto.c */
> > +extern const struct fscrypt_operations ext4_cryptops;
> > +
> >  #ifdef CONFIG_FS_ENCRYPTION
>
> Shouldn't the declaration of ext4_cryptops go in the CONFIG_FS_ENCRYPTION block?

Sure yes. I should move that within CONFIG_FS_ENCRYPTION block.

>
> Otherwise this patch looks good, thanks.
>
> Reviewed-by: Eric Biggers <ebiggers@google.com>

Thanks for the review.

-ritesh