Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp738024iob; Wed, 18 May 2022 11:50:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKf95e6dc2tPccnnx51hc4FM2g+JBXRgGxJg/bauu1NkEswVaAkHRV9eV1REOcR/fgLrAF X-Received: by 2002:a63:cc4f:0:b0:3c5:fc22:f6a with SMTP id q15-20020a63cc4f000000b003c5fc220f6amr679578pgi.67.1652899800077; Wed, 18 May 2022 11:50:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652899800; cv=none; d=google.com; s=arc-20160816; b=vb9Lrm/glLWT63DYSg2v5xPxbrlkl9w4QWSF1/aKkzQW6TV520+bW1ZQAxWEutXwCQ 1ul5f0Me5P8cb+cZNr9+60CKR2K8wsjsjqyyKub92RKBQsDjFo7W0nOnSsd1eqaaC721 XI1EKJx1UXnyxH7wC274S5rgXVnR3bAGUBCKqXIhfMPN4BzznsoIS/ONe/ik9L00g+ep pq5kQ+NKU2tTBH7EPDQppz4Y1YkRWwPzTHaGJfgeUYF8Vn91m/lk0Ix06eTfnQQX9Ebp 4waI1vn+kA3lJdK4+zo/ZMZFr6S+YvGrb0FpuEnMQL7zv6lMOOS5i7jNpeJfHavxTuty xZuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZNmX6nNHzUV65tOQmC0MnBGl2bsZ85bjRjMmjVXuCic=; b=n2PNNA1Qaoj6a3b+R9cbtk3IXKj/L2UUSE0AjzhJwLy7ErilNYkh33qz+B7ZZ0KC+i K6F7sbvR3WkwR35e9ASqiCuQTfC4Vy6NdaPI/CgEQTamF9ajQuFhJxwspZ5Z1Ky7bIqX k9+dBWcWD/LLkmjobY5x87CyQFrImvU3xoaN1dtZds2yriArHiTLCklIrmdCAdIDBxt8 LQcSqhHbkNNZF9m/7EC+wQPRPVx+bu62iWSqf757xSRhk5mWcYabE6schpY18jT68xpS h3mih2f8LoTBs5EjDUAs7enUNkLJF/RRJR5bgc38aZbGeG7G3hX9bdlBW8HAkB7H8gOR wAGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H6ExxwSk; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 76-20020a63034f000000b003db0f2baa25si3476422pgd.90.2022.05.18.11.49.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 11:50:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H6ExxwSk; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 490C323BDD; Wed, 18 May 2022 11:49:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241612AbiERSt5 (ORCPT + 99 others); Wed, 18 May 2022 14:49:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241599AbiERSt4 (ORCPT ); Wed, 18 May 2022 14:49:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20B3323BDD for ; Wed, 18 May 2022 11:49:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B117D618CF for ; Wed, 18 May 2022 18:49:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6754C385A5; Wed, 18 May 2022 18:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652899794; bh=+Apu+Nel2cEDwc+hc9Dn71n7RNyqrWqJjXXdOwbxaDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H6ExxwSk+WU0hzWKNiP6k4MURxiYIRBOwkNNWsvVn/XELTkLBZBQTY0L6ojiC8538 Nu68TmKdYlI6sW8Cbqa1wTsBu26wHnUIDiHEmpoOI/mwQkyPIG4rmBP+MCZ5BT38oG 6SO+z/6VCtLV+pY+POMWSN/wYgDN4HTNwKu0bpYYGgE6iOBPPjNurfGEvTyhossmTW cE/ISHD6/1+JC+Izp+9PNhS6yRZ+YqCVn3oXvp+bUqHrBx5a+h7TZWDMPdool26Vq7 b90/I5bpponsYE8ALi52lgsoArwQgaiW+pbekAqb07EGocvR/tE0RIdMvnGIs8mIU+ gVXK26GpYsCDA== Date: Wed, 18 May 2022 11:49:52 -0700 From: Eric Biggers To: Gabriel Krisman Bertazi Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel@collabora.com Subject: Re: [PATCH v5 1/8] ext4: Simplify the handling of cached insensitive names Message-ID: References: <20220518172320.333617-1-krisman@collabora.com> <20220518172320.333617-2-krisman@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518172320.333617-2-krisman@collabora.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, May 18, 2022 at 01:23:13PM -0400, Gabriel Krisman Bertazi wrote: > Keeping it as qstr avoids the unnecessary conversion in ext4_match > > Signed-off-by: Gabriel Krisman Bertazi > > -- > Changes since v1: > - Simplify hunk (eric) > --- The changelog needs to be deleted (or moved below the scissors line). Otherwise this patch looks good: Reviewed-by: Eric Biggers - Eric