Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp767054iob; Wed, 18 May 2022 12:29:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOqgQ+PCYMFkzU1l7f0Cvw8MWJnkYwQNcLCXQo4jJ94vJKlZYONrTzrNq0Dqt5z9vn5oge X-Received: by 2002:a63:693:0:b0:3f5:ef4e:d359 with SMTP id 141-20020a630693000000b003f5ef4ed359mr829974pgg.540.1652902167829; Wed, 18 May 2022 12:29:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652902167; cv=none; d=google.com; s=arc-20160816; b=BkMPeRxF8WkSuGQBZ3brQNlCPXt8wdelaE7qwbtrdASmvwJob3iEt+tTioIKaekr8Q v+GfkbC6e8oYql/uofPzK0lTdgix57YQOSVBHNZyP/UXjRxc6Ra0jqnCOW9ArCKRWQEK zWmsbhdGUigWvZ46m9L9FWtH78h21fJuazxb8/PE+F7r7wTeFoX6KXAFt0tqsWd+bkjH tss30+xQ0nrFaylaEiLl5Roaf7JX10+4WYVPclCAUUy+wOgcYYF8/ffQ6ViSIt2YhV0L chHoL4/73bcRLrEvjinN2jCGkfHOfXdy6riYourFEGTfFMytSwvrfFU2X2dMd7kfKdta 3Lmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=j8+absFiRt71sQVT9HiVnziVhcGHmYgCjIpOBqkpKWw=; b=GpRLozrTECwxgMJTBM8ZfHi+8oI8DbFhPFLZqb93UcNPJBlptPy6Sgnac7TqXMURp0 PraU4VmbKpqQOKFqxL/04WBEtM632meJpxvGU7nmH7d1tBrzrqOL5aDbFim2AGE3SUnZ WLv3VzbI09ACMWsoNu+S4ULTUFOzfHWfL6dRuuoQUa14pS2B0O6plqhlmHkUEtj9ccQM JNxFQFVz5lLunqmCSudk7a8fWDQaN/gedCMCOoeJhBwufJNfE0GkDqYOgbamS/iAhBOy w2bCNeThfg32uwNK7rnHW5y+VrOX6cNWyNhMHW26PNcxAbkO+ve8EFRWCMJd+lo5F6bG v4FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="C2Wz/2Nv"; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id k18-20020a170902ce1200b001613652fdd6si3501412plg.221.2022.05.18.12.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 12:29:27 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="C2Wz/2Nv"; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A8D71580C1; Wed, 18 May 2022 12:27:00 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241973AbiERT06 (ORCPT + 99 others); Wed, 18 May 2022 15:26:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241962AbiERT06 (ORCPT ); Wed, 18 May 2022 15:26:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C45355211 for ; Wed, 18 May 2022 12:26:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE58C6191C for ; Wed, 18 May 2022 19:26:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CD69C385A5; Wed, 18 May 2022 19:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652902016; bh=6bK0g96KHKgmSLVgDc/esxHtkqrzJWXIyc5tLrYriNM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C2Wz/2Nvj4IMrE3hQMQPPRHCALP2EaKRug9MA4I0XX7WC/5AfQJY0lvZN+mFRZLkw RoxwlJF3mCK7hGxKuNfWOwCmr5JyS8BJm0mTLOINQpO2Oh6AA4yKBpcb3lz9AG6P04 DXJk4MimjTgMHrgYigXWoHY/VZd//Cj7wWBVvyi+v/JlW92EweUrqC1Pc/VFnbCWbB pAZl6zwc68mXSlm4nextD9sS38g6I8wg8jCuqccKA1pbNgANC6SZN9VBvi6dhHLQ8U hSG/e3nnI8tqJ5OKiJWVlncLTQVjvhEt8oGO9gUvnJuthqXwPfPshuIfN6ylaB/DYx tRRp4rE5HydQA== Date: Wed, 18 May 2022 12:26:54 -0700 From: Eric Biggers To: Gabriel Krisman Bertazi Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel@collabora.com Subject: Re: [PATCH v5 8/8] f2fs: Move CONFIG_UNICODE defguards into the code flow Message-ID: References: <20220518172320.333617-1-krisman@collabora.com> <20220518172320.333617-9-krisman@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518172320.333617-9-krisman@collabora.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, May 18, 2022 at 01:23:20PM -0400, Gabriel Krisman Bertazi wrote: > Instead of a bunch of ifdefs, make the unicode built checks part of the > code flow where possible, as requested by Torvalds. > > Signed-off-by: Gabriel Krisman Bertazi > > --- > Changes since v4: > - Drop stub removal for !CONFIG_UNICODE case (eric) > --- > fs/f2fs/namei.c | 11 +++++------ > fs/f2fs/super.c | 8 ++++---- > 2 files changed, 9 insertions(+), 10 deletions(-) Reviewed-by: Eric Biggers - Eric