Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1014019iob; Wed, 18 May 2022 19:17:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjhZZM/+KF+eEnvxMVtXEdLS8LrEVpwKs/yXRqVY2HgA2rBaXtqA+J29Eq5uxd6/SZ798w X-Received: by 2002:a17:907:3fa7:b0:6fe:8a4e:5ff1 with SMTP id hr39-20020a1709073fa700b006fe8a4e5ff1mr2152811ejc.665.1652926662549; Wed, 18 May 2022 19:17:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652926662; cv=none; d=google.com; s=arc-20160816; b=Vgh6Qx/+weI0MTb5gLJZglpZTS4V/emzB1Wm9kfZTZCPc14nZEa7dB0PkZ0HwIZREa nPnU11koZvFcpI2ZpsPk3sosSNMvoHaUv4LS++Ak+y7yBTaFe10Lms/Alj6JsnwP0ggD mbCudMl/+Z7LywGN06s9f2Ayw4nyfemVDlca2dge4Kc5MKycJZY6U8XYQHeiEg2pfYdB 7vGKPyoy3uS9Lm0AVBVvNDl4WnjcMLOYD9EQ6s3mOxl/FivRjwdPuLfyYo9ZRpg2eR2u 6VBTkL4lyU8R3pOCFGxTVTz6UYZLoe9XYnjiJgRwJ9l9Qu+HVZAbBo5TMBzWRFEuIgjJ hDYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pcjxFOhySjekWfGdUnbaIeFGicbs/FvtrliG44D1WJ0=; b=WBH7szi9L8tcgxJUHcJwItLg099MgPRRnGKq0uUFdstR6214Iqa2JJVtL5QUZrrNwy P7xTD64jdjH8g9OMt9d6wAmJWcszIM7zJHNsyEWDipMF/mNTVwPistEhjX0EMX5/OPho ulHMpbViQWImnkbJ71CwwUVyYBFsxDBt1AcUGWm95//xFsVWczgECqnFEsGY3UYcWygt uVE4JqFiuqP9fOVbn5LdD/WLFvPJSV4G83HzYQ3BBf2CU2WU+r3qQcUra4Jzvvxxj2R/ wJpccI8XVTGfmSImls0YRuISA2tvYV8NnQcUeZkyaiG6Foauzk0oN/vB7VDB6jZdEFVj nbOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=Sjpyetr7; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l11-20020a056402254b00b00428b437b779si4669015edb.557.2022.05.18.19.17.17; Wed, 18 May 2022 19:17:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=Sjpyetr7; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232540AbiESCFa (ORCPT + 99 others); Wed, 18 May 2022 22:05:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231614AbiESCFa (ORCPT ); Wed, 18 May 2022 22:05:30 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6CDF51315; Wed, 18 May 2022 19:05:28 -0700 (PDT) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 24J25D0R018585 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 May 2022 22:05:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1652925915; bh=pcjxFOhySjekWfGdUnbaIeFGicbs/FvtrliG44D1WJ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Sjpyetr7C/w1KXTsWYgZ+LbKFIHW8eY6kDOulUtIEPGnxDJ4L22/fYNx2aDUCEg2D dtGBxF/CrN2KnW3ZYWueiKIsmaE9dzTnfrHdtDCi+eTV0m/2MM1450LqSQ00AsA3s9 tzRZDP6WYb+GlWoSPyli5xbr7OY9MM4dS3ChD9VbLEMZf/Axj7xViJbhIu24CoKl8k pFUxKaAwx5mWOGDfoNun1/Y9zFXao++mBMo3HeIDSYf8slHwJoyVN1eBPbvvDOWXVX 0hsxdBEvyOm/4wKqguvyj6eI09Sq8lYnQJnsZSS14Lf1geeilW9gRa0yPrh3oiJSst U5jdk0WDjD1Mw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 9EC2115C3EC0; Wed, 18 May 2022 22:05:13 -0400 (EDT) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Eric Biggers Cc: "Theodore Ts'o" , fstests@vger.kernel.org, Lukas Czerner Subject: Re: [PATCH] ext4: reject the 'commit' option on ext2 filesystems Date: Wed, 18 May 2022 22:05:13 -0400 Message-Id: <165292590335.1201976.332165676131707881.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220510183232.172615-1-ebiggers@kernel.org> References: <20220510183232.172615-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, 10 May 2022 11:32:32 -0700, Eric Biggers wrote: > From: Eric Biggers > > The 'commit' option is only applicable for ext3 and ext4 filesystems, > and has never been accepted by the ext2 filesystem driver, so the ext4 > driver shouldn't allow it on ext2 filesystems. > > This fixes a failure in xfstest ext4/053. > > [...] Applied, thanks! [1/1] ext4: reject the 'commit' option on ext2 filesystems commit: cb8435dc8ba33bcafa41cf2aa253794320a3b8df Best regards, -- Theodore Ts'o