Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 19 May 2022 13:20:54 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Gabriel Krisman Bertazi <krisman@collabora.com>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
        linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        kernel@collabora.com
Subject: Re: [PATCH v6 4/8] ext4: Reuse generic_ci_match for ci comparisons
Message-ID: <YoampjUJ9Qe060AH@sol.localdomain>
References: <20220519014044.508099-1-krisman@collabora.com>
 <20220519014044.508099-5-krisman@collabora.com>
 <YoW8yx9Fw9Rwiaja@sol.localdomain>
 <87h75lnvv9.fsf@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87h75lnvv9.fsf@collabora.com>
Precedence: bulk

On Thu, May 19, 2022 at 03:52:10PM -0400, Gabriel Krisman Bertazi wrote:
> > It's hard to reason about, though.  f2fs does things in a much cleaner way, as
> > I've mentioned before, since it decides which type of match it wants at the
> > beginning, when initializing struct f2fs_filename.
> 
> Yes, this is quite confusing. Are these implementation documented
> anywhere?
> 

Not very well.  The f2fs implementation has some comments, though.  E.g. see
struct f2fs_filename and f2fs_setup_filename().

- Eric