Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Gabriel Krisman Bertazi <krisman@collabora.com>
To:     "Stephen E. Baker" <baker.stephen.e@gmail.com>
Cc:     linux-ext4@vger.kernel.org
Subject: Re: simplify ext4_sb_read_encoding regression
Organization: Collabora
References: <CAFDdnB38yRcZ+mQButh9UwGoh928xsZCgmjQ7r3HPEpEwdrZbg@mail.gmail.com>
        <87sfor85j1.fsf@collabora.com>
        <CAFDdnB3U67YJ7pivdHQaMB-CkdmvvTbcpxp1FXxBmFyAgJPknw@mail.gmail.com>
Date:   Thu, 02 Jun 2022 13:47:03 -0400
In-Reply-To: <CAFDdnB3U67YJ7pivdHQaMB-CkdmvvTbcpxp1FXxBmFyAgJPknw@mail.gmail.com>
        (Stephen E. Baker's message of "Mon, 30 May 2022 18:27:29 -0400")
Message-ID: <874k13t0tk.fsf@collabora.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

"Stephen E. Baker" <baker.stephen.e@gmail.com> writes:

> On Mon, May 30, 2022 at 10:21 AM Gabriel Krisman Bertazi
> <krisman@collabora.com> wrote:
>>
>> "Stephen E. Baker" <baker.stephen.e@gmail.com> writes:
>>
>> > Hello,
>> >
>> > I have a Samsung Chromebook Plus (rk3399-gru-kevin) which boots linux
>> > off an external ssd plugged into USB. The root filesystem is ext4 with
>> > unicode support, case folding is enabled only on some directories in
>> > my home directory.
>> >
>> > Since 5.17 the system has been unbootable. I ran a git bisect and it
>> > pointed to aa8bf298a96acaaaa3af07d09cf7ffeb9798e48a ext4: simplify
>> > ext4_sb_read_encoding
>>
>> Hi Stephen,
>>
>> This series moved the UTF-8 data tables to a kernel module; before it,
>> the module had to be built-in.
>>
>> Since you have your rootfs as a case-insensitive filesystem, either the
>> utf8data module needs to be available in the initramfs or unicode
>> needs to be built-in.  Are you building your own kernel?
>>
>> Can you confirm that utf8data.ko exists in your initramfs, and
>> regenerate it if missing?  Alternatively, make sure that you have
>> CONFIG_UNICODE=y in your kernel configuration file.
>>
> Thanks Gabriel, I've verified that CONFIG_UNICODE=y, as well as
> CONFIG_UNICODE_UTF8_DATA which exists in this patch for that
> purpose, though it was removed earlier.

Thanks for checking.  Indeed, UNICODE_UTF8_DATA was just transitional,
and went away right before being part of a release.  CONFIG_UNICODE=y
should have adressed it, if it was a problem with module not being
available early enough.

>
>> If that doesn't work, can you provide the kernel log?  If you can't
>> collect the console output, a photo of the screen displaying the error
>> will suffice.
>>
> I don't have any output to provide unfortunately. It fails before the
> backlight turns on, and nothing is written to disk. I seem to remember
> that someone else at Collabora had figured out a way to get a serial
> console on this device - perhaps Tomeu. I'm not equipped for that
> personally, particularly if it involves soldering.

I'm following the discussion with Ted on the other subthread, but I
don't have anything to add at the moment other than what is already
said.

Nothing stands out on that commit specifically and I couldn't reproduce
it in a vm.  I've reached out to Tomeu to get my hands on that exact
chromebook, to try to reproduce it there.  I will report back with my
findings.

-- 
Gabriel Krisman Bertazi