Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 3 Jun 2022 15:40:57 +0800
From:   Zorro Lang <zlang@redhat.com>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] ext4/053: update the test_dummy_encryption tests
Message-ID: <20220603074057.5l63o3opgouczueb@zlang-mailbox>
References: <20220530173044.156375-1-ebiggers@kernel.org>
 <20220603053143.ud42tcsxrdkr3mj2@zlang-mailbox>
 <YpmgrJHnrMR8BcOG@sol.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YpmgrJHnrMR8BcOG@sol.localdomain>
Precedence: bulk

On Thu, Jun 02, 2022 at 10:48:28PM -0700, Eric Biggers wrote:
> On Fri, Jun 03, 2022 at 01:31:43PM +0800, Zorro Lang wrote:
> > On Mon, May 30, 2022 at 10:30:44AM -0700, Eric Biggers wrote:
> > > From: Eric Biggers <ebiggers@google.com>
> > > 
> > > Kernel commit 5f41fdaea63d ("ext4: only allow test_dummy_encryption when
> > > supported") tightened the requirements on when the test_dummy_encryption
> > > mount option is accepted.  Update ext4/053 accordingly.
> > > 
> > > Move the test cases to later in the file to group them with the other
> > > test cases that use do_mkfs to add custom mkfs options instead of using
> > > the "default" filesystem that the test creates at the beginning.
> > > 
> > > Reviewed-by: Lukas Czerner <lczerner@redhat.com>
> > > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > > ---
> > > 
> > > v2: mention the commit ID now that it is merged, and add a Reviewed-by
> > 
> > Hi Eric,
> > 
> > If I don't remember wrong, it was a patchset with 2 patches. Now you only
> > send this patch out, do you hope to merge this one only, or merge both?
> > 
> > Thanks,
> > Zorro
> > 
> 
> Just this one for now.  The second patch would add a test for the bug fix
> https://lore.kernel.org/linux-ext4/20220526040412.173025-1-ebiggers@kernel.org,
> but that wasn't applied for 5.19 due to a cross-tree dependency.  I'll be
> resending that test patch later.  One step at a time...

Sure, thanks for clarify that :)

Thanks,
Zorro

> 
> - Eric
>