Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2314799iof; Wed, 8 Jun 2022 02:14:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrDbzqInxFsHuJ5Xmg/JCf1FOPXSgA04duPsd6UVUmbVgZjHRkE8ugSthA47PyhlZFOTpr X-Received: by 2002:a62:c146:0:b0:51b:8c73:acad with SMTP id i67-20020a62c146000000b0051b8c73acadmr33940281pfg.22.1654679640438; Wed, 08 Jun 2022 02:14:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654679640; cv=none; d=google.com; s=arc-20160816; b=E8Yvo0y7RPmXzAAxeaHJWthBYQpvp5H7Ktrgd5OJxMg6QbePQtX16DY4Jbkg+nLgOn B1JJwd+hWe9nq5+jbopBiACnwspcigAtytDEWEPEiIJ3tcX1MTY6Rc88ZDaa2z1s/5um CPWqitCW93WngnWpz0e05Ykk9i/bgaVDzpN/HGccrwbDWMS6am1grf4NwdRN63BqfKhv DVmxnQ52vci+JyCHxsAbwWZ9QF+1PzRl9RbN/fFIZedMzcbp9iLiqHkP+W8qLGhwPoUh G6wkpvcJGChl/4GKv9ZNyKbKUF7v3wodrEe5YjDo/OnFQvDCG2+ZhOy9G3bAl/K8sSqH gV0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Lmlll0xHee/vEiVot8MaIaDnFq94X7SQmNxMGuo2kIg=; b=LiYg5lr/tJh58T0j2BZRFoDZY5qrKD2qhfnImN8dpRyO4sO9Y/PeIlFDknpZuPJMtg g26kmUu47kPg3XHSHBfr2twgwXYu1RHLmMLncKw+ThV1yoHjOYr+orTGyp3L/vTRPbP/ TAgFQgcEc3m9K3DbGD3DC/TsoFY8qews3rb8gQdN+CwO3QqMSVhQIXOkfOrS3+tyS8bZ cAVNHHip9rYg+A7X7YClAHQlNOx/ZWJTJSd7+eiamB13gDRchSYT0Ekf63p7LD2Pgj9x iGErO75Rp9rr6gHvRl/z56ol83b7ffz+5ZCIvBicdVwpBw9FGLnKNTPYMhFEYFFpCG8N 8K4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=K99MhL27; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id l191-20020a6391c8000000b003fc7f1808e2si27217956pge.332.2022.06.08.02.13.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 02:14:00 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=K99MhL27; spf=softfail (google.com: domain of transitioning linux-ext4-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 08F37271A86; Wed, 8 Jun 2022 01:45:05 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231501AbiFHIpC (ORCPT + 99 others); Wed, 8 Jun 2022 04:45:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231588AbiFHIoV (ORCPT ); Wed, 8 Jun 2022 04:44:21 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F1A22348F5; Wed, 8 Jun 2022 01:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Lmlll0xHee/vEiVot8MaIaDnFq94X7SQmNxMGuo2kIg=; b=K99MhL27rbGpyk6oZoCQHDJStN ATHqNPOPl7fmyyQofTDK54G9VDdXR1JVCTiKCNsyr/ha1NjCveZwfyr+ElXb6XTm4WzMWeGZrNqoP 5YXYRBZ/7Jh9lheCch0n+4CO+bhipsSd9uBl3meB+fpXyr3N/vuS+NureIBbTXMUob/JPzY9Ita3n rPGXBOz7FEXZ8SjNR69uDCDib2RwXZNJiLNaSJtWaPlbu5qnHUXq3m6OFZVDMKd1O9sq9xB+VDKM5 Dm2DLmp0am4A0lVr3uXzeX8+FPn7RkWsYdGC0GKaalaGr3v/k6XOaJBNnhuKawVGhybCgpknzNBKc BwrsYkgw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyqeh-00Bo4j-Cp; Wed, 08 Jun 2022 08:03:07 +0000 Date: Wed, 8 Jun 2022 01:03:07 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 04/10] ext4: Convert mpage_map_and_submit_buffers() to use filemap_get_folios() Message-ID: References: <20220605193854.2371230-1-willy@infradead.org> <20220605193854.2371230-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220605193854.2371230-5-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,SUSPICIOUS_RECIPS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun, Jun 05, 2022 at 08:38:48PM +0100, Matthew Wilcox (Oracle) wrote: > The called functions all use pages, so just convert back to a page. Looks good: Reviewed-by: Christoph Hellwig