Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2694230iof; Wed, 8 Jun 2022 10:04:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1LQhZmlyVruYgm5PPDynJ92b8r8E58k0SyxCkGm+iPUBFiTuWUHlnCy+GO0oaosTYMz1D X-Received: by 2002:a17:902:7c90:b0:167:8898:f82b with SMTP id y16-20020a1709027c9000b001678898f82bmr13183513pll.171.1654707867251; Wed, 08 Jun 2022 10:04:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654707867; cv=none; d=google.com; s=arc-20160816; b=loZ96yHlLMU0TFhtr2C5sfVfvrf7gVBCkv4//V3VfgXJPp6ZKlzxUbiBeIEL/i/7ud 2XzNCA1oS8Hf31675+I5d1FSvD9d9AmgeA29BQ2uC1/TbmDshoxJcQYyYuB+v74qfxUF K8s5uFK2KjvgUw0Rq5LwzgpPxoCTZAenDRZIfFptm3HPIiMi6NwwTqdFi3ngbYUYa0Rr FwrEpkT+ajSnsluG4Q/7h2yGSIzcdSW+S/CLKt49aUkAxW2jR3wp/dK+lul2t++owtQM N9W8nf+kTutZ3LVNB69zDtaLPU4sCPzkSyGqXQ/3E6KxY5hxYlZ5qsYYfgsLSBZUA1hL QGTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yuOErhko23VBUcg027gdjVhvOvMdHidC/agADdmeN/Y=; b=XuMi2E8gnNqHtgIGq9WNMEJeTvqcjj+nN2WsZLHAkFuYbSigLgDUgHl7qDQpU3ldAx SLJ5jYzDy3HDfomT60/6+OPbSUB6KN4g1aCpFK14DXjgHWF80o76UygNJ/5RZngIYq+I Re79qCAkuB1db83kZvSnE33YIVRoWHEYNxPwcFB0GD3/mQUbYAMVqCtEcxGsiJ2xoncZ xkVYIMX20KQyL/S2LPEyn8dttNlpsnaG+SXSAm7wFNhstfk0vjylqyKZHv29GtcyBNHl 2SR7wjJLFhmLZLB9uYtU/iqPt+WAhy863cToMALH7TW+/KCQ14C81WCzptILl4Nq3/8I Cn4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=nK+QsAgy; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b10-20020a631b0a000000b003fddd130adesi10932046pgb.92.2022.06.08.10.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 10:04:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=nK+QsAgy; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A67A73104D8; Wed, 8 Jun 2022 09:33:11 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245500AbiFHQc7 (ORCPT + 99 others); Wed, 8 Jun 2022 12:32:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245186AbiFHQcz (ORCPT ); Wed, 8 Jun 2022 12:32:55 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B96302EB6A1; Wed, 8 Jun 2022 09:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yuOErhko23VBUcg027gdjVhvOvMdHidC/agADdmeN/Y=; b=nK+QsAgyGVY4TqcqJIoqZb6pH6 YH1l2lYZf2/HITuH4w313bKJpwgqgeL/Ajc+m5rAf7pnUDHd5+MIIqK9hox1IXUCjje8LUpumKfOs QEjG/a+V60NeULTByNwEGajh4NfgcD085VL6n+uTDiZlJ4QoXsBzw1tu8Uz6cY8dMROHVuLQLYmqG qmgcxmIS8DTwPbCCgU89ftwLODb+/P6u3LKC47leSNnpJ713XKmla3pD/TAZxU/Z/KXlxhXOgy684 zB+mPggGwK2XDitwHO4afJMsYTpIn0LQ8rEaDkJNUysQjD3kPC6FQJOHcCHCSsAkws+g1Sq8TP2wI T8qDvWvw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyybi-00CnSF-VW; Wed, 08 Jun 2022 16:32:35 +0000 Date: Wed, 8 Jun 2022 17:32:34 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 08/10] vmscan: Add check_move_unevictable_folios() Message-ID: References: <20220605193854.2371230-1-willy@infradead.org> <20220605193854.2371230-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,SUSPICIOUS_RECIPS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 08, 2022 at 01:07:32AM -0700, Christoph Hellwig wrote: > On Sun, Jun 05, 2022 at 08:38:52PM +0100, Matthew Wilcox (Oracle) wrote: > > Change the guts of check_move_unevictable_pages() over to use folios > > and add check_move_unevictable_pages() as a wrapper. > > The changes here look fine, but please also add patches for converting > the two callers (which looks mostly trivial to me). I do want to get rid of pagevecs entirely, but that conversion isn't going to happen in time for the next merge window. for_each_sgt_page() is a little intimidating.