Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1363939iog; Thu, 16 Jun 2022 05:00:18 -0700 (PDT) X-Google-Smtp-Source: AGRyM1utng7Bzhp2yc0u/Q4CGzmQ9daOduMGY1xtzf8tx3lht0t1zVOt5v2mkrdRGeH6lwp5mdS9 X-Received: by 2002:a05:6a00:4406:b0:51c:244f:85d8 with SMTP id br6-20020a056a00440600b0051c244f85d8mr4552054pfb.36.1655380818544; Thu, 16 Jun 2022 05:00:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655380818; cv=none; d=google.com; s=arc-20160816; b=vq29QPLpzY2LID0sRG/fXseHFIuzVJLMQQn4NW0/YCh6im3H8qYaDLAZPlmiWBO6nJ jsuAfVBI4+z41rKyv0AltOpjIBBuPFtbxtFjtMee72i4kFv/IQ2lCAWe9M3TsChhQb/x kGLQB3KvcGQZ2skOnmQNuYV7OhQs15eDQYP0c0RTa32b43Kix/jpYWjxXosishHF2hW1 GoXRPvJ6PeA9BZf+E3oOgo7YvKR3JCa3kh1EQrNOsK3QjO8eDawGs/DMnI83wgPhGJVd dyu6G5hH/qsLQ1s+RNfNik/IdGJ6uF+h0GN5DxCdB7dvb7fOqpnXOdElorHRqzQAARHp Oomw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JORvJ76YZUnXA8yViAI8KZykUORbRnZMMpR1ykLsjiU=; b=Gf4jm1ciwlMIuNj8zdK+YruCJjqsq9f6/6Vs7cGJMDMUbKgXUKx395+zVkKHkHgx2b r6y81FuRvdSGxZXYpeROFnSQvo1taRQogEpFgrgPu0Tg9XMza198q0ezrsfWqIb5y/KD bVWz/qsGlfQS3rtYejOpUEWV6yBlzSN4Y2lyrU5CmHzJj339bA+DhmVWbjxM8Dep2peu HMtl+xRjNfvXw2TM84pFXWK2kyGfHElL4y2h7zhbu1i1YIkH2U0grVgdoiNmVV0lNjoq qCc9KHcjgh+664fjur8VD1IbI7iAKhFmQdHOPPcI/ctYskiKWLlymUm4HB3pmSmTaXhE 2Vgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aGLfBwgW; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x71-20020a63864a000000b003fddd12f176si2198126pgd.861.2022.06.16.04.59.54; Thu, 16 Jun 2022 05:00:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aGLfBwgW; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377041AbiFPLzR (ORCPT + 99 others); Thu, 16 Jun 2022 07:55:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377051AbiFPLzH (ORCPT ); Thu, 16 Jun 2022 07:55:07 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7F355F26A for ; Thu, 16 Jun 2022 04:54:50 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id x4so1296999pfj.10 for ; Thu, 16 Jun 2022 04:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JORvJ76YZUnXA8yViAI8KZykUORbRnZMMpR1ykLsjiU=; b=aGLfBwgWivL31vY1/JScz2DMlDQMlIJ+SJK9m7Qtmo3Lw2PVwdStdQZ2UHC/XSwGYs YCgPTDh9HJMA93VleIWo73KdapZFBVcNBfTuCerqeExg000Q7iYlW+hUNhA+mA04mfBo lPV204NUKwd7s8ORyDftIeNh1kzL3cRxOAisc5r5mrgnyHd8IdrEvwzjC3Xv/mEObe/u xVRDmziPwK6IbjAZH4eBVJr5nezxO8wcqRp5Jrmgog4jllKfbzU8phYxmu2epQxPtZwx r7XQV1GXyj8FS4uTcj4XXIsaXTTVrx9uU5kxBPnb++OOHO6ADeaN5+9VNvrW+TWolPHr caGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JORvJ76YZUnXA8yViAI8KZykUORbRnZMMpR1ykLsjiU=; b=UHb4mvwopNwPMBnfDcVcSDIetDMF0J38ZfQBw4fs4Ue+/eR+053gPO9Y7AbVApl5TT BKBHteyQP7UzbawloFr6wTcF/s3z/1Y5IeLqJtazB2ZMF2VMw2EkAEt7dOueu9PGOYV6 LXuqnCBuamOBOr2WV/S/cVh4TuduruUrPRPrK7XAVXtJ4XurjcAOfhSzqR5PI2QMLXQN 8Bpdo39Mqq1s1sux6xW4Q3eRS8aXzpkKy15CPpTcbNAcUnxDd1YKGicft3bXBYcgBqZW /UMrw2tI1wLrXpj51S5ahqxJhYlvPgvFjvZbz5dBQ1BUoTQCcBDX6VEB4urA0KlljWwF NKQw== X-Gm-Message-State: AJIora8S9zR8rzA2B/siEra7+xVopG4eQ/6Z9ijSht/DmyhC2PJ5VfYk lvf18Gp8Y5QVfkLwRRH9vvw= X-Received: by 2002:a05:6a00:1705:b0:51c:26ae:569c with SMTP id h5-20020a056a00170500b0051c26ae569cmr4428558pfc.28.1655380486175; Thu, 16 Jun 2022 04:54:46 -0700 (PDT) Received: from localhost ([2406:7400:63:5d34:e6c2:4c64:12ae:aa11]) by smtp.gmail.com with ESMTPSA id c11-20020a621c0b000000b0051ba303f1c0sm1576895pfc.127.2022.06.16.04.54.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 04:54:45 -0700 (PDT) Date: Thu, 16 Jun 2022 17:24:40 +0530 From: Ritesh Harjani To: Jan Kara Cc: Ted Tso , linux-ext4@vger.kernel.org Subject: Re: [PATCH 0/10 v2] ext4: Fix possible fs corruption due to xattr races Message-ID: <20220616115440.ryjyecrwprgfoxp2@riteshh-domain> References: <20220614124146.21594-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220614124146.21594-1-jack@suse.cz> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 22/06/14 06:05PM, Jan Kara wrote: > Hello, > > this is the second version of my patches to fix the race in ext4 xattr handling > that led to assertion failure in jbd2 Ritesh has reported. The series is > completely reworked. This time it passes beating with "stress-ng --xattr 16". > Also I'm somewhat happier about the current solution because, although it is > still not trivial to use mbcache correctly, it is at least harder to use it > in a racy way :). Please let me know what you think about this series. I have tested this on my setup where I was able to reproduce the problem with stress-ng. It ran for several hours and also passed fstests (quick). So feel free to - Tested-by: Ritesh Harjani (IBM) -ritesh > > Changes since v1: > * Reworked the series to fix all corner cases and make API less errorprone. > > Honza > > Previous versions: > Link: http://lore.kernel.org/r/20220606142215.17962-1-jack@suse.cz # v1