Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1408786iog; Thu, 16 Jun 2022 05:56:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vLd2iOZfffb5T910YzyilRswqLHYwF0+zWKQrMOL2BquGqkgyoef7cqWdEf0LqhVMoIeW2 X-Received: by 2002:a05:6402:1713:b0:42d:cb5e:d799 with SMTP id y19-20020a056402171300b0042dcb5ed799mr6305534edu.34.1655384161962; Thu, 16 Jun 2022 05:56:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655384161; cv=none; d=google.com; s=arc-20160816; b=eXkqTnJlvcjfMqcEk/k+4B0q11URveE2Oos72sbuutyNcdSh/CiPFYyMxcYyQBozEF PQSITcFuzlNUzxGALYjHHRYo4AyUcc76uq/QUrzYkR0t8pYMr6E5YGi30G2JrxZvGucV b5tUQSs4DCPs868TbKjb3NNpAV5O8A/vFIbTNoJTveUkq9RiRyTlY0vkA1Wf/6dHKyO+ RMUmA/A7I+RhY5Dso18syXsomxjquh3z0nENGMHx7hzivk0IOsHpzeCoHY9F20fsZ4Pf s4Q7hEoEuz6n0qJM2qqkOEFxdhYhZ1IyysYCkUdg6L8Mqi4EeHBoZ2NShs9I5hzO59nM NKbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=EyduPko3ZtALa4oOrrk1ZaEmySl+TBijpQJfEjnfkdA=; b=Q5sW105vKVDuzSJpxgngzyBHZ75JbKwC0XuW7lZfnzGV7nx0+cvklwRdnGaZ3G9Tqp Fz4F/s4R+dMkZHIQ8NhK8Lgluz5G/5nqCic0YIZtrkvg8KOlp6yYZKtkkPCwftjQYR++ /vbWAapB/EjaapXrCRsKBdOc/RB2O3zPzFfxDDDei3FjhHEKPYXBvABz6UBjpahR9YcE 9hM7Wdk2pQN+kLahzRGJOUNeuUHXodueMiQjt07kBUbt6SZB45ubBXS9BU7w6H1+Ya1M Cc6xDZ42pe91bUsolmwRxMkwjrS5cRPxR5fAh0jS7hbJhbcmv/5TSV/NhyXuuuVUIgFO tBiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=0fESLNHo; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=BNTHxPIM; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne20-20020a1709077b9400b007121245807esi1930965ejc.708.2022.06.16.05.55.25; Thu, 16 Jun 2022 05:56:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=0fESLNHo; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=BNTHxPIM; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231578AbiFPMtu (ORCPT + 99 others); Thu, 16 Jun 2022 08:49:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbiFPMtu (ORCPT ); Thu, 16 Jun 2022 08:49:50 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06A521AD96 for ; Thu, 16 Jun 2022 05:49:49 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id B0B9E1F8C1; Thu, 16 Jun 2022 12:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1655383787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EyduPko3ZtALa4oOrrk1ZaEmySl+TBijpQJfEjnfkdA=; b=0fESLNHoG50xvsYY5inQK0WAf4j55uU432NB/q2WAetioYQ9vvbHXwuJSWRRWHR7yx/8W4 oMgkN/DoZeb7NxaNPNRWtCW2dRlUJmPsAYJDlM7od7NKjORuo+GHIX3GekvtcQaD4S8q+4 v3S1Mi5vQyy/xOwRT91acvoPKigsaFA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1655383787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EyduPko3ZtALa4oOrrk1ZaEmySl+TBijpQJfEjnfkdA=; b=BNTHxPIMheIf4WC7cPeVkn+OnzxDm/63q7yqHtArck42LF6WfcpWi5c3fgqyIT8bYOU85b 9/RYDOZX5Jh/KXBw== Received: from quack3.suse.cz (unknown [10.163.28.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 8C3572C141; Thu, 16 Jun 2022 12:49:47 +0000 (UTC) Received: by quack3.suse.cz (Postfix, from userid 1000) id F23D0A062E; Thu, 16 Jun 2022 14:49:46 +0200 (CEST) Date: Thu, 16 Jun 2022 14:49:46 +0200 From: Jan Kara To: Ritesh Harjani Cc: Jan Kara , Ted Tso , linux-ext4@vger.kernel.org Subject: Re: [PATCH 0/10 v2] ext4: Fix possible fs corruption due to xattr races Message-ID: <20220616124946.pzkhx6q6nzrvuhxy@quack3.lan> References: <20220614124146.21594-1-jack@suse.cz> <20220616115440.ryjyecrwprgfoxp2@riteshh-domain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616115440.ryjyecrwprgfoxp2@riteshh-domain> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu 16-06-22 17:24:40, Ritesh Harjani wrote: > On 22/06/14 06:05PM, Jan Kara wrote: > > Hello, > > > > this is the second version of my patches to fix the race in ext4 xattr handling > > that led to assertion failure in jbd2 Ritesh has reported. The series is > > completely reworked. This time it passes beating with "stress-ng --xattr 16". > > Also I'm somewhat happier about the current solution because, although it is > > still not trivial to use mbcache correctly, it is at least harder to use it > > in a racy way :). Please let me know what you think about this series. > > I have tested this on my setup where I was able to reproduce the problem with > stress-ng. It ran for several hours and also passed fstests (quick). > > So feel free to - > Tested-by: Ritesh Harjani (IBM) Thanks for testing! Honza -- Jan Kara SUSE Labs, CR