Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <02ed2cb7-3ad3-8ffc-6032-04ae1853e234@amd.com>
Date:   Fri, 17 Jun 2022 12:20:46 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v5 01/13] mm: add zone device coherent type memory support
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>, jgg@nvidia.com
Cc:     Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        hch@lst.de, jglisse@redhat.com, apopple@nvidia.com,
        willy@infradead.org, akpm@linux-foundation.org
References: <20220531200041.24904-1-alex.sierra@amd.com>
 <20220531200041.24904-2-alex.sierra@amd.com>
 <3ac89358-2ce0-7d0d-8b9c-8b0e5cc48945@redhat.com>
From:   "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>
In-Reply-To: <3ac89358-2ce0-7d0d-8b9c-8b0e5cc48945@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M291eWpIOFpzdWNwQnBTSGhvQmJtZVUwVVJEVFgvYWVaSE1oMjgwYkhtcVNN?=
 =?utf-8?B?UEpnSEZmc3p3eGZuZkUzZFppYVJocm1OTjVaelVxR25ORThFNzh2ZDMrQW5D?=
 =?utf-8?B?SXQ1Tml0L3hGRW5UVlV2bEQ2aTNSYURLMk9wNmxBWGZnRm9YNVR4RVh5WFlM?=
 =?utf-8?B?YVBYdDdSQ0RJbUdvMHFkQnRtMVNkMC9Vem4rSUxUWHJhU3VBeEVWZHBiYjBJ?=
 =?utf-8?B?Vml0ejZnU3NTNzc3eENDbFdnTU1tcHg3TWl6Yi9KZzE4bXBtbVRSSmhpNktO?=
 =?utf-8?B?RDVOWHhvMDlrcjI3WkZWaTFtdHdSR3JrbUhlWS9NdEdFR0dXVVA4T1ZDNzlC?=
 =?utf-8?B?TXBBTkszWFlRUEZFR0Fqd09GbGtReXRUUkxZUERHUmkrOHlUcmVGdXR1cjEv?=
 =?utf-8?B?dmpJd2lmR2tTZGVmbVNvNktFMHhYU2dxTVF2NklNVXZqVHBDck40RU9pWHVM?=
 =?utf-8?B?U2d2RUQvWVJjdTdjdmlsbC9icHIyQXhjblNULytRb21va2c2OENGTFNnT2Vi?=
 =?utf-8?B?M0VQWnRyVEdQRmNiRlhjTDM3MzQ2aXZmT2FxeTMyeXNsYUdjQ0VBY3lIWlB1?=
 =?utf-8?B?WFJKckhvSE84Q3BpTXFZZWlRMjU4UFBUS0lGSXdMQTBwV1RLSjVlUlRCekVQ?=
 =?utf-8?B?MjJIdWFsQ0dZT2FWWFhmWkhpNHh1Z3lDdGRtektqWFdSc1FiTXBkM1dWeVFu?=
 =?utf-8?B?ektmeVlYVmNlSm9HWGIxeksycVZjVG9wWHlFZnVjNGtmSEJRQkQwRlZYTlpV?=
 =?utf-8?B?T1pqS1JjVHVWY2ExRWJuTEJrM1FJUnBWTDEyelR5YzdVWW9hcW5LbldEem5x?=
 =?utf-8?B?VDVtMDJ1ZlowU2xiRnE1NCtuNE1mNnZzSWUxNFFsdThMK1h0NSszTllROEdF?=
 =?utf-8?B?RHNyK3hqK1ZLU2lCeVZRTGVmOXppK1dnYUlOblE0OEc3bW15MkJLL2lmRnRB?=
 =?utf-8?B?N3dzWjhjRmxKYmI3YVd6VkRYamxiOFM4NDE4RzBIak52Y0Y0aDIwSHh4V0t6?=
 =?utf-8?B?QisvSklqNXJqZWpzcnlaODNHUzlvYS9wOUU5OFJPaFVIRUVBa2YxS3Y0cVpt?=
 =?utf-8?B?RFJaRGhrZWtGSS9pcERaWmVpS051dHh4TXhyQWpwbGJHVEVjYlVIamw2QUpw?=
 =?utf-8?B?YytYWjdUM2ZQSmhJRXFBb3dNck9XQ3B6ZklwZ1ZjMFBLQ1VrSjFMdENZY2FM?=
 =?utf-8?B?TzhEc29PNWhJL2hzTGxzN2VhOUpmZGxQbzdJQms3M092ZUY1Uk9VekJSbTV6?=
 =?utf-8?B?dk5jT0VsdHk0aHlqUklLZEI4TmN3Qm1sdk5OV3ZNbUkyVCt0S0ZheEEvTWNW?=
 =?utf-8?B?RElmU1hlSW1QdUlRamNYR0d3allLZm9FcVZ2WTA4NDl5NDdxMmJHU29hbWhx?=
 =?utf-8?B?R3hQRVplNHBld3lOZllNS0owSUpqdzltcGlJZVhZK3ovY1k2ci9vN1pGdzVi?=
 =?utf-8?B?dlJBdVNpVG9pK0tyWmNDOHhGajAySE4za21iQXFYTDF3Y0F2S1U3cUowUlEw?=
 =?utf-8?B?dFJKYkMwQllKVU0yak9vQ3NSeHpPYmFJVENxOEtMRHRQcnJxYnBKbjMrK0RG?=
 =?utf-8?B?bEFFNW02NzdEYVE4bFozSzNkVmhrREVLcWNqbDVhN0tJZTQwcEUxN3lHOXpL?=
 =?utf-8?B?U3QzMWtuSDlucktuZnkvWTIvRjRpaVZhRDJ3cml4QUhWWWF3WTJpN0UwUGhR?=
 =?utf-8?B?Y0t5Mm54dkVNakJrTGtSNjZ1L3lLNHEyVzRqeVBzUElIY3ZHTStWZ1ZKeSsz?=
 =?utf-8?B?aUtOaHY1SjBYM1dxbC95b2ZkK3hwU2NaYXdrRzYyYTNnbnNYajlqS2tLSVkx?=
 =?utf-8?B?eDA2bkhFMW5MNmF5MWpZc3dSdEJEdUNsUFRTbWRLK3RzVmIvTVdIcEFYRHdz?=
 =?utf-8?B?eFMybERDTGVYenpVWkVqUytHclM3NW5EaUh4UG5MZnRIL3UwV2ZTbW8vSW5B?=
 =?utf-8?B?NkY4a1ZOcW5EdGdlL2ZBS2xmcEgydnc0djFqd1ZtbklMQ2ZvNnRkeUkrWkly?=
 =?utf-8?B?VUFyZ3dzdmVBSHhHMWFnUGNSR1NtMmx4R2RJN1VGSkx3NDFFQTRuTElTOUto?=
 =?utf-8?B?dUNWOTRZdWlQN3dZZmQ1ZU1TLzRlM3U1Q2I3b0Q0cmdwRVcrU2g2eXFRWVli?=
 =?utf-8?B?S0hDQ05waFJLWE5jaGRicWZkQ0RxbVI1Mm9OOE5GdjI5L2FCNGNNZmdyTHlG?=
 =?utf-8?B?cFpzWmNMN2FYa20xOHhJOEp6OFVuSGRnUE9QMHBvSk5YeHVmZEZMcFFaaVpM?=
 =?utf-8?B?L0M3V253MHhLUHd3b0RyZkF0eC9RbFVlVWxyc0VwUHYzWGVSRVlnMldWM2Vu?=
 =?utf-8?B?Y3EwbC9wSENTY1QyVHRxUFVVOE1wT0ErK0hJeDNCWk8zckp2UGtGZz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5827a06-6820-452c-8f9d-08da5085ba36
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2717.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2022 17:20:51.3856
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bSta839moXOZISNH/bPEJtkwaX59KHY6Qo4TeoJj/H4k1G8fHUOAREtiE30K9r47qiFloXzANxU53zvN6c9zyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1789
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org


On 6/17/2022 4:40 AM, David Hildenbrand wrote:
> On 31.05.22 22:00, Alex Sierra wrote:
>> Device memory that is cache coherent from device and CPU point of view.
>> This is used on platforms that have an advanced system bus (like CAPI
>> or CXL). Any page of a process can be migrated to such memory. However,
>> no one should be allowed to pin such memory so that it can always be
>> evicted.
>>
>> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
>> Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>
>> Reviewed-by: Alistair Popple <apopple@nvidia.com>
>> [hch: rebased ontop of the refcount changes,
>>        removed is_dev_private_or_coherent_page]
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> ---
>>   include/linux/memremap.h | 19 +++++++++++++++++++
>>   mm/memcontrol.c          |  7 ++++---
>>   mm/memory-failure.c      |  8 ++++++--
>>   mm/memremap.c            | 10 ++++++++++
>>   mm/migrate_device.c      | 16 +++++++---------
>>   mm/rmap.c                |  5 +++--
>>   6 files changed, 49 insertions(+), 16 deletions(-)
>>
>> diff --git a/include/linux/memremap.h b/include/linux/memremap.h
>> index 8af304f6b504..9f752ebed613 100644
>> --- a/include/linux/memremap.h
>> +++ b/include/linux/memremap.h
>> @@ -41,6 +41,13 @@ struct vmem_altmap {
>>    * A more complete discussion of unaddressable memory may be found in
>>    * include/linux/hmm.h and Documentation/vm/hmm.rst.
>>    *
>> + * MEMORY_DEVICE_COHERENT:
>> + * Device memory that is cache coherent from device and CPU point of view. This
>> + * is used on platforms that have an advanced system bus (like CAPI or CXL). A
>> + * driver can hotplug the device memory using ZONE_DEVICE and with that memory
>> + * type. Any page of a process can be migrated to such memory. However no one
> Any page might not be right, I'm pretty sure. ... just thinking about special pages
> like vdso, shared zeropage, ... pinned pages ...

Hi David,

Yes, I think you're right. This type does not cover all special pages.  
I need to correct that on the cover letter.
Pinned pages are allowed as long as they're not long term pinned.

Regards,
Alex Sierra

>
>> + * should be allowed to pin such memory so that it can always be evicted.
>> + *
>>    * MEMORY_DEVICE_FS_DAX:
>>    * Host memory that has similar access semantics as System RAM i.e. DMA
>>    * coherent and supports page pinning. In support of coordinating page
>> @@ -61,6 +68,7 @@ struct vmem_altmap {
>>   enum memory_type {
>>   	/* 0 is reserved to catch uninitialized type fields */
>>   	MEMORY_DEVICE_PRIVATE = 1,
>> +	MEMORY_DEVICE_COHERENT,
>>   	MEMORY_DEVICE_FS_DAX,
>>   	MEMORY_DEVICE_GENERIC,
>>   	MEMORY_DEVICE_PCI_P2PDMA,
>> @@ -143,6 +151,17 @@ static inline bool folio_is_device_private(const struct folio *folio)
> In general, this LGTM, and it should be correct with PageAnonExclusive I think.
>
>
> However, where exactly is pinning forbidden?

Long-term pinning is forbidden since it would interfere with the device 
memory manager owning the
device-coherent pages (e.g. evictions in TTM). However, normal pinning 
is allowed on this device type.

Regards,
Alex Sierra

>