Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 18 Jun 2022 12:33:01 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Theodore Ts'o <tytso@mit.edu>
Cc:     adilger.kernel@dilger.ca,
        Ding Xiang <dingxiang@cmss.chinamobile.com>,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Subject: Re: [PATCH] ext4: change variable "count" to signed integer
Message-ID: <Yq2bzesQ5H+DrA47@kili>
References: <20220530100047.537598-1-dingxiang@cmss.chinamobile.com>
 <165552108974.634564.2634497659089601268.b4-ty@mit.edu>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <165552108974.634564.2634497659089601268.b4-ty@mit.edu>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gLU5ryi/6PaOBnfHnIFNlWHoVnTqDeMlScMow5a1UwHOzNkT41NjMePMKELq?=
 =?us-ascii?Q?HPK3zK4l33wOUC/Gk8Td88AINr9EC9FSZSf6T8CWZQOS5l0HwKLe9jBNKXr9?=
 =?us-ascii?Q?t8yfISfh4BoNWatEAIaDcKIekjsR2ok7zhcmjVZCBArv+nR0eIEuluEfIkp0?=
 =?us-ascii?Q?jN9DifjepEdJapZ/5JvBSTNVDOuBQDCZ978D1bVPsSIi1vN9nWqVK2tY2FOT?=
 =?us-ascii?Q?AAMK+zSOJDN8UEKqLcENlQoyKWRNn4DvCPBIDOQiFlF4H9nkwu/JZLqRs00B?=
 =?us-ascii?Q?czNSd+UwpRM6ZaCuNp4dJgZcDfEjsXXrNdYjbvdg4SI7iQak033p+fnaQRnN?=
 =?us-ascii?Q?Ho26wHvJxIe7/8ViatxqhaKqAbBCWL1+Dry5xR4SULlIw6XT4sezMfwx2wfz?=
 =?us-ascii?Q?9gdGuheva3T20JNjvGVbHFM5LQ89BlTS9wmzqZtukbawA9UC2h0nU9mNxazA?=
 =?us-ascii?Q?ZgoGFXaA13W6bN3jpm1tef74CBeLCq95hBh3LvqhSzi45MngCG2MByZy1LnE?=
 =?us-ascii?Q?tKq8/2LhOElZvjk4BLnwDc0CamBBF9AUOK2yBF5ghaSNtnfFmcmOaWzWhRfp?=
 =?us-ascii?Q?xfO8MhVodg29kIPpUo1ddibQFA8nhlootspTfecGMXr//jdx5YYXs+vpDw7H?=
 =?us-ascii?Q?eHALUvksqx4jYqpppRxGhZKEcB+wDn52k+2UHToIBwyPYF9V4NcWM+UEf7YO?=
 =?us-ascii?Q?EXKy7VRDujISHQV0fOADGUPaBYWK5Fi6ZMzDr3bygS6yDZotIvOmUSYpDrX4?=
 =?us-ascii?Q?LdYI9eV570dyyfBqP99fWKDQD2W69ys/oJ010cmIasTy3DrIcvoLwBlgg+l2?=
 =?us-ascii?Q?nQsXqPfzzrrB7yGcrFQ26fGxClpIj3AD6YvksnyrYaW5NMr2PLDntFdmfiMD?=
 =?us-ascii?Q?8GPfGbliXydV3Lhnj2bD2V6UwL8/L8yEJjadx96g3NB+EbdakMaexgbs1AP5?=
 =?us-ascii?Q?Cqmfc/xE/bfujGk2kE0avzoygxVa2b1z4zNq/JK95f61a8WpIUgL8LDMrryj?=
 =?us-ascii?Q?VjCgpJV1MWQ3SRz6TnYwvISmwa+zRzv04NFjyca6ur7/5Hmle0As9I+ru41M?=
 =?us-ascii?Q?NaetB0FOLJ+xkUj1le63pcZqiebKh/T5+DCjF9hN7uZdesFfWNfN7zQEgYl0?=
 =?us-ascii?Q?WX47GtgAucAr03Y7+YDT1EZUY0VNV+/h9z362h6hRVuYTGby1ilYhDLnJt2d?=
 =?us-ascii?Q?rEk0dX2tu7n9HSOOKKna1VEn2ULNFklGcUsE4fCpwZv8RG7tn8MCnsyg50ux?=
 =?us-ascii?Q?qGPdIEeFs42Tun5fnmgRr1buxVzts0sKymURJn4V6D/lyh21pv7UbQ8Cpgtt?=
 =?us-ascii?Q?oC8ldryzGVrGA41L4/Kuh7SxVMroMPiat8U4Y6xlFPEWXhtesR8oyFP6qJSh?=
 =?us-ascii?Q?RiRNkPbzrew1CdI5P4TOpW5+Yi/MB53DGqwma0gF4Nxde8wscxO3lfy77dQC?=
 =?us-ascii?Q?cP8/MrPKA+zFoOLNWcDIrZll6BbH/upodj65yLqGfVsDlNl1nw8Sgp9llE3t?=
 =?us-ascii?Q?sXE2X8FwrPcUMQdvCB4ZsFvhGKTodDX7x0A/P4FQ462MG2ikActNs7j15097?=
 =?us-ascii?Q?w2SsTvkTvyTMCx39eA9VBsWoTW1z8ugn1lMjUzObyxj1RXctZ5koRFdGk02n?=
 =?us-ascii?Q?pTxRYlS0PyZYDoBCS9+Feit/WwH3O3pc9pm/2adyj0KDB74ajWmqYLT0KB5k?=
 =?us-ascii?Q?gbjYsfqDd+T1l2IJkt6+jvRX2mzI4gp9nWjbuV4BCPzQ6wcOhW39SgC7prs5?=
 =?us-ascii?Q?jenWbnpPbg5Ysl8ZBe5TEv7kn6hICgo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c427cd9-724a-461c-db1b-08da510d90be
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2022 09:33:13.7291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WVx3NtkfJeVDXdjWd7iI5IaHkrx+WvnmBELKE3PUlMoIoXNmzCKFF8DKK+lygwuZ/USygav0/lS04MmYWPonT/LKz3l8jXVshqi6bQyyvJ8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2488
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-18_08:2022-06-17,2022-06-18 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 bulkscore=0 spamscore=0 adultscore=0 phishscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206180046
X-Proofpoint-ORIG-GUID: OwB4af0Rind_FDQ5qCte7xWwzAzxyogE
X-Proofpoint-GUID: OwB4af0Rind_FDQ5qCte7xWwzAzxyogE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Fri, Jun 17, 2022 at 10:59:01PM -0400, Theodore Ts'o wrote:
> On Mon, 30 May 2022 18:00:47 +0800, Ding Xiang wrote:
> > Since dx_make_map() may return -EFSCORRUPTED now,
> > so change "count" to signed integer.
> > 
> > 
> 
> Applied, thanks!
> 
> [1/1] ext4: change variable "count" to signed integer
>       commit: fefb759df063599ad483422eb07ef8e14c612cc2
> 

There was some kind of process error here...

1) That commit somehow never made it to linux-next.

2) No Fixes tag.  Presumably Greg searches for Fixes tags before he back
ports patches.  The original commit 46c116b920eb ("ext4: verify dir
block before splitting it") has been back ported to stable already.

3) I don't know why I didn't send a patch for this bug.  I looked at it
on May 23 but never sent a patch.  Sorry?

4) There are a dozen other static checkers which are supposed to have
warned about this.  I search lore.kernel.org for 46c116b920eb
and 46c116b920ebec58031f0a78c5ea9599b0d2a371 but I couldn't find any
static checker warnings.

regards,
dan carpenter